From: Tom Evans <tom_usenet@optusnet.com.au>
To: "arnd@arndb.de" <arnd@arndb.de>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: can: flexcan: Ancient Freescale Reference FlexCAN Driver and bug fixes so it works.
Date: Wed, 23 Dec 2015 11:53:29 +1100 [thread overview]
Message-ID: <5679F089.9080509@optusnet.com.au> (raw)
In-Reply-To: <56723869.5060900@optusnet.com.au>
On 17/12/15 15:22, Tom Evans wrote:
> On 11/12/15 09:53, Tom Evans wrote:
>> On 10/12/2015 11:44 PM, Marc Kleine-Budde wrote:
>>
>> The simplest path was to fix the simple and stupidly obvious
>> bugs in the existing driver rather than add new complicated bugs.
>
> There seems to be no end of bugs in this driver. It is a lesson
> in something.
The Bus Off Recovery doesn't work either. A Bus Off condition results in the
module being soft-reset and then never woken up again, mainly because the
calls to "mod_timer()" forget to add "jiffies", so the timer doesn't trigger.
Then the Auto/Manual mode recovery test is probably backwards. Then it tests
MDIS instead of HALT, so it never resets the module after the soft reset. If
you program it in "Auto Recovery" mode it resets it anyway.
Bugs detailed here:
https://community.freescale.com/message/599099#599099
There'll probably be a link on that page to the patches to fix it after I've
tested it some more.
Tom
WARNING: multiple messages have this Message-ID (diff)
From: tom_usenet@optusnet.com.au (Tom Evans)
To: linux-arm-kernel@lists.infradead.org
Subject: can: flexcan: Ancient Freescale Reference FlexCAN Driver and bug fixes so it works.
Date: Wed, 23 Dec 2015 11:53:29 +1100 [thread overview]
Message-ID: <5679F089.9080509@optusnet.com.au> (raw)
In-Reply-To: <56723869.5060900@optusnet.com.au>
On 17/12/15 15:22, Tom Evans wrote:
> On 11/12/15 09:53, Tom Evans wrote:
>> On 10/12/2015 11:44 PM, Marc Kleine-Budde wrote:
>>
>> The simplest path was to fix the simple and stupidly obvious
>> bugs in the existing driver rather than add new complicated bugs.
>
> There seems to be no end of bugs in this driver. It is a lesson
> in something.
The Bus Off Recovery doesn't work either. A Bus Off condition results in the
module being soft-reset and then never woken up again, mainly because the
calls to "mod_timer()" forget to add "jiffies", so the timer doesn't trigger.
Then the Auto/Manual mode recovery test is probably backwards. Then it tests
MDIS instead of HALT, so it never resets the module after the soft reset. If
you program it in "Auto Recovery" mode it resets it anyway.
Bugs detailed here:
https://community.freescale.com/message/599099#599099
There'll probably be a link on that page to the patches to fix it after I've
tested it some more.
Tom
next prev parent reply other threads:[~2015-12-23 0:53 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 11:33 [PATCH v2 0/5] Add flexcan support for LS1021A SoCs Bhupesh Sharma
2015-05-14 11:33 ` Bhupesh Sharma
2015-05-14 11:33 ` [PATCH v2 1/5] doc/bindings: Add 'endianess' optional-property for FlexCAN controller Bhupesh Sharma
2015-05-14 11:33 ` Bhupesh Sharma
2015-05-14 11:33 ` [PATCH v2 2/5] arm/dts: Add nodes for flexcan devices present on LS1021A SoC Bhupesh Sharma
2015-05-14 11:33 ` Bhupesh Sharma
2015-05-14 11:33 ` [PATCH v2 3/5] can: flexcan: Add ls1021a flexcan device entry Bhupesh Sharma
2015-05-14 11:33 ` Bhupesh Sharma
2015-05-14 15:38 ` Marc Kleine-Budde
2015-05-14 15:38 ` Marc Kleine-Budde
2015-05-14 11:33 ` [PATCH v2 4/5] can: flexcan: Remodel FlexCAN register r/w APIs for BE instances Bhupesh Sharma
2015-05-14 11:33 ` Bhupesh Sharma
2015-05-18 16:17 ` Enrico Weigelt, metux IT consult
2015-05-18 16:17 ` Enrico Weigelt, metux IT consult
2015-05-18 16:37 ` Sharma Bhupesh
2015-05-18 16:37 ` Sharma Bhupesh
2015-05-14 11:33 ` [PATCH v2 5/5] can: flexcan: Add support for non RX-FIFO mode Bhupesh Sharma
2015-05-14 11:33 ` Bhupesh Sharma
2015-05-14 15:41 ` Marc Kleine-Budde
2015-05-14 15:41 ` Marc Kleine-Budde
2015-05-14 15:44 ` Sharma Bhupesh
2015-05-14 15:44 ` Sharma Bhupesh
2015-12-10 11:05 ` Sharma Bhupesh
2015-12-10 11:05 ` Sharma Bhupesh
2015-12-10 11:44 ` can: flexcan: Ancient Freescale Reference FlexCAN Driver and bug fixes so it works Tom Evans
2015-12-10 12:44 ` Marc Kleine-Budde
2015-12-10 12:44 ` Marc Kleine-Budde
2015-12-10 22:53 ` Tom Evans
2015-12-10 22:53 ` Tom Evans
2015-12-17 4:22 ` Tom Evans
2015-12-17 4:22 ` Tom Evans
2015-12-23 0:53 ` Tom Evans [this message]
2015-12-23 0:53 ` Tom Evans
2015-12-10 12:19 ` [PATCH v2 5/5] can: flexcan: Add support for non RX-FIFO mode Marc Kleine-Budde
2015-12-10 12:19 ` Marc Kleine-Budde
2015-12-10 12:22 ` Sharma Bhupesh
2015-12-10 12:22 ` Sharma Bhupesh
2015-12-11 16:01 ` Robert Schwebel
2015-12-11 16:01 ` Robert Schwebel
2015-05-15 0:09 ` Tom Evans
2015-05-15 0:09 ` Tom Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5679F089.9080509@optusnet.com.au \
--to=tom_usenet@optusnet.com.au \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.