From: Jiang Qiu <qiujiang@huawei.com> To: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: Linus Walleij <linus.walleij@linaro.org>, Alexandre Courbot <gnurou@gmail.com>, Mika Westerberg <mika.westerberg@linux.intel.com>, Alan Tull <delicious.quinoa@gmail.com>, Jamie Iles <jamie@jamieiles.com>, charles.chenxin@huawei.com, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>, linuxarm@huawei.com Subject: Re: [PATCH v7 2/3] gpio: dwapb: convert device node to fwnode Date: Thu, 7 Apr 2016 19:14:27 +0800 [thread overview] Message-ID: <57064113.2040603@huawei.com> (raw) In-Reply-To: <CAHp75Vc-Pd4swDq5gVKtwmOGD9fALkmDpyt1qah0JGQo2+422w@mail.gmail.com> 在 2016/4/6 21:01, Andy Shevchenko 写道: > On Wed, Apr 6, 2016 at 10:07 AM, qiujiang <qiujiang@huawei.com> wrote: >> This patch converts device node to fwnode for dwapb driver, so >> as to provide a unified fwnode for DT and ACPI bindings. >> >> Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> >> Signed-off-by: qiujiang <qiujiang@huawei.com> > >> static struct dwapb_platform_data * >> -dwapb_gpio_get_pdata_of(struct device *dev) >> +dwapb_gpio_get_pdata(struct device *dev) > > I don't remember if I had asked already > does it fit now one row? Hi Andy, It dose not fit one row yet, checkpatch.pl will report a warning. > >> @@ -495,9 +493,10 @@ dwapb_gpio_get_pdata_of(struct device *dev) >> * Only port A can provide interrupts in all configurations of >> * the IP. >> */ >> - if (pp->idx == 0 && >> - of_property_read_bool(port_np, "interrupt-controller")) { >> - pp->irq = irq_of_parse_and_map(port_np, 0); >> + if (dev->of_node && pp->idx == 0 && > > is_of_fwnode() && ? > >> + fwnode_property_read_bool(fwnode, >> + "interrupt-controller")) { >> + pp->irq = irq_of_parse_and_map(to_of_node(fwnode), 0); >> if (!pp->irq) >> dev_warn(dev, "no irq for this bank\n"); > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Jiang Qiu <qiujiang@huawei.com> To: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: Linus Walleij <linus.walleij@linaro.org>, Alexandre Courbot <gnurou@gmail.com>, Mika Westerberg <mika.westerberg@linux.intel.com>, "Alan Tull" <delicious.quinoa@gmail.com>, Jamie Iles <jamie@jamieiles.com>, <charles.chenxin@huawei.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>, <linuxarm@huawei.com> Subject: Re: [PATCH v7 2/3] gpio: dwapb: convert device node to fwnode Date: Thu, 7 Apr 2016 19:14:27 +0800 [thread overview] Message-ID: <57064113.2040603@huawei.com> (raw) In-Reply-To: <CAHp75Vc-Pd4swDq5gVKtwmOGD9fALkmDpyt1qah0JGQo2+422w@mail.gmail.com> 在 2016/4/6 21:01, Andy Shevchenko 写道: > On Wed, Apr 6, 2016 at 10:07 AM, qiujiang <qiujiang@huawei.com> wrote: >> This patch converts device node to fwnode for dwapb driver, so >> as to provide a unified fwnode for DT and ACPI bindings. >> >> Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com> >> Signed-off-by: qiujiang <qiujiang@huawei.com> > >> static struct dwapb_platform_data * >> -dwapb_gpio_get_pdata_of(struct device *dev) >> +dwapb_gpio_get_pdata(struct device *dev) > > I don't remember if I had asked already > does it fit now one row? Hi Andy, It dose not fit one row yet, checkpatch.pl will report a warning. > >> @@ -495,9 +493,10 @@ dwapb_gpio_get_pdata_of(struct device *dev) >> * Only port A can provide interrupts in all configurations of >> * the IP. >> */ >> - if (pp->idx == 0 && >> - of_property_read_bool(port_np, "interrupt-controller")) { >> - pp->irq = irq_of_parse_and_map(port_np, 0); >> + if (dev->of_node && pp->idx == 0 && > > is_of_fwnode() && ? > >> + fwnode_property_read_bool(fwnode, >> + "interrupt-controller")) { >> + pp->irq = irq_of_parse_and_map(to_of_node(fwnode), 0); >> if (!pp->irq) >> dev_warn(dev, "no irq for this bank\n"); >
next prev parent reply other threads:[~2016-04-07 11:15 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-06 7:07 [PATCH v7 0/3] gpio: dwapb: add gpio-signaled acpi event support for power button qiujiang 2016-04-06 7:07 ` qiujiang 2016-04-06 7:07 ` [PATCH v7 1/3] gpio: dwapb: remove name from dwapb_port_property qiujiang 2016-04-06 7:07 ` qiujiang 2016-04-06 12:57 ` Andy Shevchenko 2016-04-07 11:45 ` Jiang Qiu 2016-04-07 11:45 ` Jiang Qiu 2016-04-06 7:07 ` [PATCH v7 2/3] gpio: dwapb: convert device node to fwnode qiujiang 2016-04-06 7:07 ` qiujiang 2016-04-06 13:01 ` Andy Shevchenko 2016-04-07 11:14 ` Jiang Qiu [this message] 2016-04-07 11:14 ` Jiang Qiu 2016-04-15 2:29 ` Kefeng Wang 2016-04-15 2:29 ` Kefeng Wang 2016-04-06 7:08 ` [PATCH v7 3/3] gpio: dwapb: add gpio-signaled acpi event support qiujiang 2016-04-06 7:08 ` qiujiang 2016-04-08 8:26 ` Linus Walleij 2016-04-08 8:38 ` Mika Westerberg 2016-04-11 12:43 ` Jiang Qiu 2016-04-11 12:43 ` Jiang Qiu 2016-04-12 6:46 ` Mika Westerberg 2016-04-12 6:55 ` Jiang Qiu 2016-04-12 6:55 ` Jiang Qiu 2016-04-15 7:40 ` Linus Walleij 2016-04-15 7:58 ` Jiang Qiu 2016-04-15 7:58 ` Jiang Qiu 2016-04-11 13:00 ` Linus Walleij 2016-04-11 12:33 ` Jiang Qiu 2016-04-11 12:33 ` Jiang Qiu 2016-04-06 13:03 ` [PATCH v7 0/3] gpio: dwapb: add gpio-signaled acpi event support for power button Andy Shevchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=57064113.2040603@huawei.com \ --to=qiujiang@huawei.com \ --cc=andy.shevchenko@gmail.com \ --cc=charles.chenxin@huawei.com \ --cc=delicious.quinoa@gmail.com \ --cc=gnurou@gmail.com \ --cc=jamie@jamieiles.com \ --cc=linus.walleij@linaro.org \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxarm@huawei.com \ --cc=mika.westerberg@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.