From: James Morse <james.morse@arm.com> To: Xiongfeng Wang <wangxiongfeng2@huawei.com> Cc: Mark Rutland <mark.rutland@arm.com>, Xie XiuQi <xiexiuqi@huawei.com>, christoffer.dall@linaro.org, marc.zyngier@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, fu.wei@linaro.org, rostedt@goodmis.org, hanjun.guo@linaro.org, shiju.jose@huawei.com, wuquanming@huawei.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, gengdongjiu@huawei.com, linux-acpi@vger.kernel.org, zhengqiang10@huawei.com, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 7/8] arm64: exception: handle asynchronous SError interrupt Date: Mon, 08 May 2017 18:27:46 +0100 [thread overview] Message-ID: <5910AA92.2010106@arm.com> (raw) In-Reply-To: <d20bb634-d70b-5ab9-20e2-46275675ce1f@huawei.com> Hi Xiongfeng Wang, On 28/04/17 03:55, Xiongfeng Wang wrote: >>> >> It is ok to just ignore the process following the ESB instruction in el0_sync, because the process will be sent SIGBUS signal. >> > >> > I don't understand. How will Linux know the process caused an error if we >> > neither take an SError nor read DISR_EL1 after an ESB? > I think there may be some misunderstanding here. The ESB instruction is placed in kernel_entry > of el0_sync and el0_irq. For the el0_sync, such as an syscall from userspace, after ESB is executed, > we check whether DISR.A is set. If it is not set, we go on to process the syscall. If it is set, we > jump to sError vector and then just eret. Ah, this looks like an early optimisation! We can't assume that the SError will result in the processing being killed, the AET bits of the SError ISS Encoding (page D7-2284 of ARM-ARM DDI0487B.a), has a 'corrected' error encoding. For these I would expect the SError-vector C code to do nothing and return to where it came from. In this case the syscall should still be run. Thanks, James
WARNING: multiple messages have this Message-ID (diff)
From: james.morse@arm.com (James Morse) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 7/8] arm64: exception: handle asynchronous SError interrupt Date: Mon, 08 May 2017 18:27:46 +0100 [thread overview] Message-ID: <5910AA92.2010106@arm.com> (raw) In-Reply-To: <d20bb634-d70b-5ab9-20e2-46275675ce1f@huawei.com> Hi Xiongfeng Wang, On 28/04/17 03:55, Xiongfeng Wang wrote: >>> >> It is ok to just ignore the process following the ESB instruction in el0_sync, because the process will be sent SIGBUS signal. >> > >> > I don't understand. How will Linux know the process caused an error if we >> > neither take an SError nor read DISR_EL1 after an ESB? > I think there may be some misunderstanding here. The ESB instruction is placed in kernel_entry > of el0_sync and el0_irq. For the el0_sync, such as an syscall from userspace, after ESB is executed, > we check whether DISR.A is set. If it is not set, we go on to process the syscall. If it is set, we > jump to sError vector and then just eret. Ah, this looks like an early optimisation! We can't assume that the SError will result in the processing being killed, the AET bits of the SError ISS Encoding (page D7-2284 of ARM-ARM DDI0487B.a), has a 'corrected' error encoding. For these I would expect the SError-vector C code to do nothing and return to where it came from. In this case the syscall should still be run. Thanks, James
next prev parent reply other threads:[~2017-05-08 17:27 UTC|newest] Thread overview: 139+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-30 10:31 [PATCH v3 0/8] arm64: acpi: apei: handle SEI notification type for ARMv8 Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` [PATCH v3 1/8] trace: ras: add ARM processor error information trace event Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 16:02 ` Steven Rostedt 2017-03-30 16:02 ` Steven Rostedt 2017-03-30 16:02 ` Steven Rostedt 2017-04-06 9:03 ` Xie XiuQi 2017-04-06 9:03 ` Xie XiuQi 2017-04-06 9:03 ` Xie XiuQi 2017-03-30 10:31 ` [PATCH v3 2/8] acpi: apei: handle SEI notification type for ARMv8 Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-31 16:20 ` James Morse 2017-03-31 16:20 ` James Morse 2017-04-06 9:11 ` Xie XiuQi 2017-04-06 9:11 ` Xie XiuQi 2017-04-06 9:11 ` Xie XiuQi 2017-03-30 10:31 ` [PATCH v3 3/8] arm64: apei: add a per-cpu variable to indecate sei is processing Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` [PATCH v3 4/8] APEI: GHES: reserve a virtual page for SEI context Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-31 16:22 ` James Morse 2017-03-31 16:22 ` James Morse 2017-04-06 9:25 ` Xie XiuQi 2017-04-06 9:25 ` Xie XiuQi 2017-04-06 9:25 ` Xie XiuQi 2017-03-30 10:31 ` [PATCH v3 5/8] arm64: KVM: add guest SEI support Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` [PATCH v3 6/8] arm64: RAS: add ras extension runtime detection Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` [PATCH v3 7/8] arm64: exception: handle asynchronous SError interrupt Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-04-13 8:44 ` Xiongfeng Wang 2017-04-13 8:44 ` Xiongfeng Wang 2017-04-13 8:44 ` Xiongfeng Wang 2017-04-13 10:51 ` Mark Rutland 2017-04-13 10:51 ` Mark Rutland 2017-04-13 10:51 ` Mark Rutland 2017-04-14 7:03 ` Xie XiuQi 2017-04-14 7:03 ` Xie XiuQi 2017-04-14 7:03 ` Xie XiuQi 2017-04-18 1:09 ` Xiongfeng Wang 2017-04-18 1:09 ` Xiongfeng Wang 2017-04-18 1:09 ` Xiongfeng Wang 2017-04-18 10:51 ` James Morse 2017-04-18 10:51 ` James Morse 2017-04-18 10:51 ` James Morse 2017-04-19 2:37 ` Xiongfeng Wang 2017-04-19 2:37 ` Xiongfeng Wang 2017-04-19 2:37 ` Xiongfeng Wang 2017-04-20 8:52 ` James Morse 2017-04-20 8:52 ` James Morse 2017-04-20 8:52 ` James Morse 2017-04-21 11:33 ` Xiongfeng Wang 2017-04-21 11:33 ` Xiongfeng Wang 2017-04-21 11:33 ` Xiongfeng Wang 2017-04-24 17:14 ` James Morse 2017-04-24 17:14 ` James Morse 2017-04-24 17:14 ` James Morse 2017-04-28 2:55 ` Xiongfeng Wang 2017-04-28 2:55 ` Xiongfeng Wang 2017-04-28 2:55 ` Xiongfeng Wang 2017-05-08 17:27 ` James Morse [this message] 2017-05-08 17:27 ` James Morse 2017-05-09 2:16 ` Xiongfeng Wang 2017-05-09 2:16 ` Xiongfeng Wang 2017-05-09 2:16 ` Xiongfeng Wang 2017-04-21 10:46 ` Xiongfeng Wang 2017-04-21 10:46 ` Xiongfeng Wang 2017-04-21 10:46 ` Xiongfeng Wang 2017-03-30 10:31 ` [PATCH v3 8/8] arm64: exception: check shared writable page in SEI handler Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-04-07 15:56 ` James Morse 2017-04-07 15:56 ` James Morse 2017-04-07 15:56 ` James Morse 2017-04-12 8:35 ` Xiongfeng Wang 2017-04-12 8:35 ` Xiongfeng Wang 2017-04-12 8:35 ` Xiongfeng Wang 2017-03-30 10:31 ` [PATCH v3 0/8] arm64: acpi: apei: handle SEI notification type for ARMv8 Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` [PATCH v3 1/8] trace: ras: add ARM processor error information trace event Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-04-14 20:36 ` Baicar, Tyler 2017-04-14 20:36 ` Baicar, Tyler 2017-04-17 3:08 ` Xie XiuQi 2017-04-17 3:08 ` Xie XiuQi 2017-04-17 3:08 ` Xie XiuQi 2017-04-17 3:16 ` Xie XiuQi 2017-04-17 3:16 ` Xie XiuQi 2017-04-17 3:16 ` Xie XiuQi 2017-04-17 17:18 ` Baicar, Tyler 2017-04-17 17:18 ` Baicar, Tyler 2017-04-18 2:22 ` Xie XiuQi 2017-04-18 2:22 ` Xie XiuQi 2017-04-18 2:22 ` Xie XiuQi 2017-03-30 10:31 ` [PATCH v3 2/8] acpi: apei: handle SEI notification type for ARMv8 Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` [PATCH v3 3/8] arm64: apei: add a per-cpu variable to indecate sei is processing Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` [PATCH v3 4/8] APEI: GHES: reserve a virtual page for SEI context Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` [PATCH v3 5/8] arm64: KVM: add guest SEI support Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` [PATCH v3 6/8] arm64: RAS: add ras extension runtime detection Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` [PATCH v3 7/8] arm64: exception: handle asynchronous SError interrupt Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` [PATCH v3 8/8] arm64: exception: check shared writable page in SEI handler Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi 2017-03-30 10:31 ` Xie XiuQi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5910AA92.2010106@arm.com \ --to=james.morse@arm.com \ --cc=catalin.marinas@arm.com \ --cc=christoffer.dall@linaro.org \ --cc=fu.wei@linaro.org \ --cc=gengdongjiu@huawei.com \ --cc=hanjun.guo@linaro.org \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=mark.rutland@arm.com \ --cc=rostedt@goodmis.org \ --cc=shiju.jose@huawei.com \ --cc=wangxiongfeng2@huawei.com \ --cc=will.deacon@arm.com \ --cc=wuquanming@huawei.com \ --cc=xiexiuqi@huawei.com \ --cc=zhengqiang10@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.