From: Xiaofei Tan <tanxiaofei@huawei.com> To: Johan Hovold <johan@kernel.org> Cc: <gregkh@linuxfoundation.org>, <jirislaby@kernel.org>, <linux-kernel@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>, <linuxarm@openeuler.org> Subject: Re: [PATCH 6/9] tty: hvc_console: Fix coding style issues of block comments Date: Thu, 20 May 2021 21:21:25 +0800 [thread overview] Message-ID: <7e63a708-64c4-b369-066b-7f83d65bf178@huawei.com> (raw) In-Reply-To: <YKYcFfKiHT39Gyey@hovoldconsulting.com> Hi Johan, On 2021/5/20 16:21, Johan Hovold wrote: > On Tue, May 18, 2021 at 12:01:22PM +0800, Xiaofei Tan wrote: >> Hi Johan, >> >> Thanks for reviewing this patch. >> >> On 2021/5/17 22:15, Johan Hovold wrote: >>> On Mon, May 17, 2021 at 02:37:10PM +0800, Xiaofei Tan wrote: >>>> Fix coding style issues of block comments, reported by checkpatch.pl. >>>> Besides, add a period at the end of the sentenses. >>>> >>>> Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com> >>>> --- >>>> drivers/tty/hvc/hvc_console.c | 15 ++++++++++----- >>>> 1 file changed, 10 insertions(+), 5 deletions(-) >>>> >>>> diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c >>>> index 39018e5..a61cdf0 100644 >>>> --- a/drivers/tty/hvc/hvc_console.c >>>> +++ b/drivers/tty/hvc/hvc_console.c >>>> @@ -177,7 +177,8 @@ static void hvc_console_print(struct console *co, const char *b, >>>> r = cons_ops[index]->put_chars(vtermnos[index], c, i); >>>> if (r <= 0) { >>>> /* throw away characters on error >>>> - * but spin in case of -EAGAIN */ >>>> + * but spin in case of -EAGAIN. >>>> + */ >>> >>> How is this an improvement? First, the multi-line comment style is >>> >>> /* >>> * ... >>> */ >>> >> >> Yes, mostly we use this style. I can follow it if new version is needed. > > This is the preferred style outside of networking. > >> BTW, How about add the '/*' check into checkpatch.pl? > > Checkpatch already has too many checks IMO and I'm a bit surprised that > it doesn't check this already. Perhaps it's because you used the -f to > run checkpatch on in-kernel code, which you should not. > >>> Second, that sentence is not capitalised so why do add a period? >>> >> >> How about capitalize the sentence, or just remove the period ? > > How about just leaving this unchanged? > OK And I will keep the patch 8/9, and combine space issues into one new patch, and remove the others. >>> Third, why are you sending checkpatch.pl cleanups for files outside of >>> staging? >>> >> >> I'm sorry, Is this a rule, or kind of tradition? I've never heard of >> this before. > > Many subsystems reject pure style changes unless you're also doing some > real changes to the code in question. This is a good default rule, even > if some maintainers may occasionally accept churn like this. > > You appear to be paid to do kernel work. Why don't you start fixing bugs > or help out reviewing new code instead of sending trivial patches like > this? We can always need another hand. > > But if all you you want is to increase your company patch count then > please go work in drivers/staging where most trivial style changes are > currently accepted. > >>> Unless doing some real changes to the files in question as well this is >>> mostly just churn and noise that makes it harder to backport fixes and >>> do code forensics for no real gain. >> >> I'm not sure. But if cleanup patches have made it hard to backport fixes >> and do code forensics, then the code quality may not be >> good enough. > > No, that has nothing to do with code quality, it's just that you > introduce noise in the logs and do pointless changes of context which > makes it harder to use tools like git blame and makes backporting harder > for no good reason. > > Johan > > . >
WARNING: multiple messages have this Message-ID (diff)
From: Xiaofei Tan <tanxiaofei@huawei.com> To: Johan Hovold <johan@kernel.org> Cc: gregkh@linuxfoundation.org, linuxppc-dev@lists.ozlabs.org, jirislaby@kernel.org, linux-kernel@vger.kernel.org, linuxarm@openeuler.org Subject: Re: [PATCH 6/9] tty: hvc_console: Fix coding style issues of block comments Date: Thu, 20 May 2021 21:21:25 +0800 [thread overview] Message-ID: <7e63a708-64c4-b369-066b-7f83d65bf178@huawei.com> (raw) In-Reply-To: <YKYcFfKiHT39Gyey@hovoldconsulting.com> Hi Johan, On 2021/5/20 16:21, Johan Hovold wrote: > On Tue, May 18, 2021 at 12:01:22PM +0800, Xiaofei Tan wrote: >> Hi Johan, >> >> Thanks for reviewing this patch. >> >> On 2021/5/17 22:15, Johan Hovold wrote: >>> On Mon, May 17, 2021 at 02:37:10PM +0800, Xiaofei Tan wrote: >>>> Fix coding style issues of block comments, reported by checkpatch.pl. >>>> Besides, add a period at the end of the sentenses. >>>> >>>> Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com> >>>> --- >>>> drivers/tty/hvc/hvc_console.c | 15 ++++++++++----- >>>> 1 file changed, 10 insertions(+), 5 deletions(-) >>>> >>>> diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c >>>> index 39018e5..a61cdf0 100644 >>>> --- a/drivers/tty/hvc/hvc_console.c >>>> +++ b/drivers/tty/hvc/hvc_console.c >>>> @@ -177,7 +177,8 @@ static void hvc_console_print(struct console *co, const char *b, >>>> r = cons_ops[index]->put_chars(vtermnos[index], c, i); >>>> if (r <= 0) { >>>> /* throw away characters on error >>>> - * but spin in case of -EAGAIN */ >>>> + * but spin in case of -EAGAIN. >>>> + */ >>> >>> How is this an improvement? First, the multi-line comment style is >>> >>> /* >>> * ... >>> */ >>> >> >> Yes, mostly we use this style. I can follow it if new version is needed. > > This is the preferred style outside of networking. > >> BTW, How about add the '/*' check into checkpatch.pl? > > Checkpatch already has too many checks IMO and I'm a bit surprised that > it doesn't check this already. Perhaps it's because you used the -f to > run checkpatch on in-kernel code, which you should not. > >>> Second, that sentence is not capitalised so why do add a period? >>> >> >> How about capitalize the sentence, or just remove the period ? > > How about just leaving this unchanged? > OK And I will keep the patch 8/9, and combine space issues into one new patch, and remove the others. >>> Third, why are you sending checkpatch.pl cleanups for files outside of >>> staging? >>> >> >> I'm sorry, Is this a rule, or kind of tradition? I've never heard of >> this before. > > Many subsystems reject pure style changes unless you're also doing some > real changes to the code in question. This is a good default rule, even > if some maintainers may occasionally accept churn like this. > > You appear to be paid to do kernel work. Why don't you start fixing bugs > or help out reviewing new code instead of sending trivial patches like > this? We can always need another hand. > > But if all you you want is to increase your company patch count then > please go work in drivers/staging where most trivial style changes are > currently accepted. > >>> Unless doing some real changes to the files in question as well this is >>> mostly just churn and noise that makes it harder to backport fixes and >>> do code forensics for no real gain. >> >> I'm not sure. But if cleanup patches have made it hard to backport fixes >> and do code forensics, then the code quality may not be >> good enough. > > No, that has nothing to do with code quality, it's just that you > introduce noise in the logs and do pointless changes of context which > makes it harder to use tools like git blame and makes backporting harder > for no good reason. > > Johan > > . >
next prev parent reply other threads:[~2021-05-20 13:21 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-17 6:37 [PATCH 0/9] tty: hvc_console: Fix some coding style issues Xiaofei Tan 2021-05-17 6:37 ` Xiaofei Tan 2021-05-17 6:37 ` [PATCH 1/9] tty: hvc_console: Fix spaces required around that '=' Xiaofei Tan 2021-05-17 6:37 ` Xiaofei Tan 2021-05-17 6:37 ` [PATCH 2/9] tty: hvc_console: Fix "foo * bar" should be "foo *bar" Xiaofei Tan 2021-05-17 6:37 ` Xiaofei Tan 2021-05-17 6:37 ` [PATCH 3/9] tty: hvc_console: Remove trailing whitespace Xiaofei Tan 2021-05-17 6:37 ` Xiaofei Tan 2021-05-17 6:37 ` [PATCH 4/9] tty: hvc_console: Fix issues of code indent should use tabs Xiaofei Tan 2021-05-17 6:37 ` Xiaofei Tan 2021-05-17 6:37 ` [PATCH 5/9] tty: hvc_console: Delete spaces prohibited around open parenthesis '(' and ')' Xiaofei Tan 2021-05-17 6:37 ` Xiaofei Tan 2021-05-17 6:37 ` [PATCH 6/9] tty: hvc_console: Fix coding style issues of block comments Xiaofei Tan 2021-05-17 6:37 ` Xiaofei Tan 2021-05-17 14:15 ` Johan Hovold 2021-05-17 14:15 ` Johan Hovold 2021-05-18 4:01 ` Xiaofei Tan 2021-05-18 4:01 ` Xiaofei Tan 2021-05-20 8:21 ` Johan Hovold 2021-05-20 8:21 ` Johan Hovold 2021-05-20 13:21 ` Xiaofei Tan [this message] 2021-05-20 13:21 ` Xiaofei Tan 2021-05-20 13:52 ` Johan Hovold 2021-05-20 13:52 ` Johan Hovold 2021-05-21 2:23 ` Xiaofei Tan 2021-05-21 2:23 ` Xiaofei Tan 2021-05-20 15:21 ` Joe Perches 2021-05-20 15:21 ` Joe Perches 2021-05-21 8:44 ` Johan Hovold 2021-05-21 8:44 ` Johan Hovold 2021-05-17 6:37 ` [PATCH 7/9] tty: hvc_console: Add a blank line after declarations Xiaofei Tan 2021-05-17 6:37 ` Xiaofei Tan 2021-05-17 6:37 ` [PATCH 8/9] tty: hvc_console: Remove the repeated words 'no' and 'from' Xiaofei Tan 2021-05-17 6:37 ` Xiaofei Tan 2021-05-17 6:37 ` [PATCH 9/9] tty: hvc_console: Move open brace { on the previous line Xiaofei Tan 2021-05-17 6:37 ` Xiaofei Tan 2021-05-20 15:11 ` [PATCH 0/9] tty: hvc_console: Fix some coding style issues Greg KH 2021-05-20 15:11 ` Greg KH 2021-05-21 2:18 ` Xiaofei Tan 2021-05-21 2:18 ` Xiaofei Tan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7e63a708-64c4-b369-066b-7f83d65bf178@huawei.com \ --to=tanxiaofei@huawei.com \ --cc=gregkh@linuxfoundation.org \ --cc=jirislaby@kernel.org \ --cc=johan@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxarm@openeuler.org \ --cc=linuxppc-dev@lists.ozlabs.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.