From: Xiaofei Tan <tanxiaofei@huawei.com> To: Greg KH <gregkh@linuxfoundation.org> Cc: <jirislaby@kernel.org>, <linux-kernel@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>, <linuxarm@openeuler.org> Subject: Re: [PATCH 0/9] tty: hvc_console: Fix some coding style issues Date: Fri, 21 May 2021 10:18:04 +0800 [thread overview] Message-ID: <ee765bed-f060-a31a-882f-4a8270366831@huawei.com> (raw) In-Reply-To: <YKZ8M8j5/bUJxLq5@kroah.com> Hi Greg, On 2021/5/20 23:11, Greg KH wrote: > On Mon, May 17, 2021 at 02:37:04PM +0800, Xiaofei Tan wrote: >> Fix some issues reported by checkpatch.pl. All of them are >> coding style issues, no function changes. >> >> Xiaofei Tan (9): >> tty: hvc_console: Fix spaces required around that '=' >> tty: hvc_console: Fix "foo * bar" should be "foo *bar" >> tty: hvc_console: Remove trailing whitespace >> tty: hvc_console: Fix issues of code indent should use tabs >> tty: hvc_console: Delete spaces prohibited around open parenthesis '(' >> and ')' >> tty: hvc_console: Fix coding style issues of block comments >> tty: hvc_console: Add a blank line after declarations >> tty: hvc_console: Remove the repeated words 'no' and 'from' >> tty: hvc_console: Move open brace { on the previous line >> >> drivers/tty/hvc/hvc_console.c | 37 ++++++++++++++++++++++--------------- >> 1 file changed, 22 insertions(+), 15 deletions(-) > > Do you use this driver? No, i don't use it. If so, great, I'm sure there are other "real" > issues in it that need some work. But as Johan points out, doing > drive-by checkpatch cleanups on random files that you do not use, isn't > the best thing to do. > Sure > If you just want to do this type of work, please do so in > drivers/staging/ as it is most welcome there if you wish to get involved > in kernel work to get experience before doing "real" stuff. > OK, thanks. > thanks, > g > reg k-h > > . >
WARNING: multiple messages have this Message-ID (diff)
From: Xiaofei Tan <tanxiaofei@huawei.com> To: Greg KH <gregkh@linuxfoundation.org> Cc: linuxppc-dev@lists.ozlabs.org, jirislaby@kernel.org, linux-kernel@vger.kernel.org, linuxarm@openeuler.org Subject: Re: [PATCH 0/9] tty: hvc_console: Fix some coding style issues Date: Fri, 21 May 2021 10:18:04 +0800 [thread overview] Message-ID: <ee765bed-f060-a31a-882f-4a8270366831@huawei.com> (raw) In-Reply-To: <YKZ8M8j5/bUJxLq5@kroah.com> Hi Greg, On 2021/5/20 23:11, Greg KH wrote: > On Mon, May 17, 2021 at 02:37:04PM +0800, Xiaofei Tan wrote: >> Fix some issues reported by checkpatch.pl. All of them are >> coding style issues, no function changes. >> >> Xiaofei Tan (9): >> tty: hvc_console: Fix spaces required around that '=' >> tty: hvc_console: Fix "foo * bar" should be "foo *bar" >> tty: hvc_console: Remove trailing whitespace >> tty: hvc_console: Fix issues of code indent should use tabs >> tty: hvc_console: Delete spaces prohibited around open parenthesis '(' >> and ')' >> tty: hvc_console: Fix coding style issues of block comments >> tty: hvc_console: Add a blank line after declarations >> tty: hvc_console: Remove the repeated words 'no' and 'from' >> tty: hvc_console: Move open brace { on the previous line >> >> drivers/tty/hvc/hvc_console.c | 37 ++++++++++++++++++++++--------------- >> 1 file changed, 22 insertions(+), 15 deletions(-) > > Do you use this driver? No, i don't use it. If so, great, I'm sure there are other "real" > issues in it that need some work. But as Johan points out, doing > drive-by checkpatch cleanups on random files that you do not use, isn't > the best thing to do. > Sure > If you just want to do this type of work, please do so in > drivers/staging/ as it is most welcome there if you wish to get involved > in kernel work to get experience before doing "real" stuff. > OK, thanks. > thanks, > g > reg k-h > > . >
next prev parent reply other threads:[~2021-05-21 2:18 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-17 6:37 [PATCH 0/9] tty: hvc_console: Fix some coding style issues Xiaofei Tan 2021-05-17 6:37 ` Xiaofei Tan 2021-05-17 6:37 ` [PATCH 1/9] tty: hvc_console: Fix spaces required around that '=' Xiaofei Tan 2021-05-17 6:37 ` Xiaofei Tan 2021-05-17 6:37 ` [PATCH 2/9] tty: hvc_console: Fix "foo * bar" should be "foo *bar" Xiaofei Tan 2021-05-17 6:37 ` Xiaofei Tan 2021-05-17 6:37 ` [PATCH 3/9] tty: hvc_console: Remove trailing whitespace Xiaofei Tan 2021-05-17 6:37 ` Xiaofei Tan 2021-05-17 6:37 ` [PATCH 4/9] tty: hvc_console: Fix issues of code indent should use tabs Xiaofei Tan 2021-05-17 6:37 ` Xiaofei Tan 2021-05-17 6:37 ` [PATCH 5/9] tty: hvc_console: Delete spaces prohibited around open parenthesis '(' and ')' Xiaofei Tan 2021-05-17 6:37 ` Xiaofei Tan 2021-05-17 6:37 ` [PATCH 6/9] tty: hvc_console: Fix coding style issues of block comments Xiaofei Tan 2021-05-17 6:37 ` Xiaofei Tan 2021-05-17 14:15 ` Johan Hovold 2021-05-17 14:15 ` Johan Hovold 2021-05-18 4:01 ` Xiaofei Tan 2021-05-18 4:01 ` Xiaofei Tan 2021-05-20 8:21 ` Johan Hovold 2021-05-20 8:21 ` Johan Hovold 2021-05-20 13:21 ` Xiaofei Tan 2021-05-20 13:21 ` Xiaofei Tan 2021-05-20 13:52 ` Johan Hovold 2021-05-20 13:52 ` Johan Hovold 2021-05-21 2:23 ` Xiaofei Tan 2021-05-21 2:23 ` Xiaofei Tan 2021-05-20 15:21 ` Joe Perches 2021-05-20 15:21 ` Joe Perches 2021-05-21 8:44 ` Johan Hovold 2021-05-21 8:44 ` Johan Hovold 2021-05-17 6:37 ` [PATCH 7/9] tty: hvc_console: Add a blank line after declarations Xiaofei Tan 2021-05-17 6:37 ` Xiaofei Tan 2021-05-17 6:37 ` [PATCH 8/9] tty: hvc_console: Remove the repeated words 'no' and 'from' Xiaofei Tan 2021-05-17 6:37 ` Xiaofei Tan 2021-05-17 6:37 ` [PATCH 9/9] tty: hvc_console: Move open brace { on the previous line Xiaofei Tan 2021-05-17 6:37 ` Xiaofei Tan 2021-05-20 15:11 ` [PATCH 0/9] tty: hvc_console: Fix some coding style issues Greg KH 2021-05-20 15:11 ` Greg KH 2021-05-21 2:18 ` Xiaofei Tan [this message] 2021-05-21 2:18 ` Xiaofei Tan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ee765bed-f060-a31a-882f-4a8270366831@huawei.com \ --to=tanxiaofei@huawei.com \ --cc=gregkh@linuxfoundation.org \ --cc=jirislaby@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxarm@openeuler.org \ --cc=linuxppc-dev@lists.ozlabs.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.