From: Kalle Valo <kvalo@codeaurora.org> To: Greg KH <gregkh@linuxfoundation.org> Cc: Ajay.Kathat@microchip.com, devel@driverdev.osuosl.org, Venkateswara.Kaja@microchip.com, Sripad.Balwadgi@microchip.com, linux-wireless@vger.kernel.org, Nicolas.Ferre@microchip.com, johannes@sipsolutions.net Subject: Re: [PATCH v7 00/17] wilc1000: move out of staging Date: Fri, 26 Jun 2020 08:34:48 +0300 [thread overview] Message-ID: <87a70qe6fb.fsf@codeaurora.org> (raw) In-Reply-To: <20200624145254.GA1876138@kroah.com> (Greg KH's message of "Wed, 24 Jun 2020 16:52:54 +0200") Greg KH <gregkh@linuxfoundation.org> writes: > On Wed, Jun 24, 2020 at 12:49:24PM +0300, Kalle Valo wrote: >> Greg KH <gregkh@linuxfoundation.org> writes: >> >> > On Wed, Jun 24, 2020 at 11:50:07AM +0300, Kalle Valo wrote: >> >> <Ajay.Kathat@microchip.com> writes: >> >> >> >> > From: Ajay Singh <ajay.kathat@microchip.com> >> >> > >> >> > This patch series is to review and move wilc1000 driver out of staging. >> >> > Most of the review comments received in [1] & [2] are addressed in the >> >> > latest code. >> >> > Please review and provide your inputs. >> >> > >> >> > [1]. https://lore.kernel.org/linux-wireless/1537957525-11467-1-git-send-email-ajay.kathat@microchip.com/ >> >> > [2]. https://lore.kernel.org/linux-wireless/1562896697-8002-1-git-send-email-ajay.kathat@microchip.com/ >> >> > >> >> > Changes since v6: >> >> > - added Reviewed-by tag received for DT binding document patch earlier. >> >> > * https://lore.kernel.org/linux-wireless/20200405013235.GA24105@bogus >> >> > - merged latest driver and included --base commit as suggested. >> >> >> >> Greg, in preparation for moving the driver to drivers/net/wireless can I >> >> ask you to not to take wilc1000 patches for the time being? I think that >> >> way it would be easier to move the driver between trees if there are no >> >> changes after v5.8-rc1. Or is there a better way handle the move? >> > >> > The best way is for there to be a series of patches that just adds the >> > driver to the "real" part of the tree, and when that is merged, let me >> > know and I will just delete the driver version in the staging tree. >> > >> > Does that work for you? >> >> It would be fine for me but won't that approach break the build (eg. >> allyesconfig) due to two duplicate versions of the same driver in >> wireless-drivers-next? > > For maybe one day, yes, but that's all. > >> What I was thinking that Ajay would create a patch moving the driver >> from drivers/staging/wilc1000 to >> drivers/net/wireless/microchip/wilc1000. Using 'git mv' and 'git >> format-patch --find-renames' the patch should be really small, mostly >> just renames and small changes to Kconfig, Makefile and MAINTAINERS >> files. But this of course would require that there are no wilc1000 >> patches in your tree until you get the driver move commit during the >> next merge window, otherwise we would see conflicts between staging-next >> and wireless-drivers-next. >> >> But I don't have any strong opinions, whatever is easiest for everyone :) > > It's kind of hard to review patches that do moves, but if you all want > to do that, that's fine with me. Actually we have been reviewing the driver with full diffs, one file per patch style[1], so I think everyone are happy. At least I have not heard any complaints. And Ajay already submitted that the simple rename patch proposed, thanks Ajay! https://patchwork.kernel.org/patch/11625025/ And indeed the patch is simple as it can get. So Greg, if it's ok for you I would like to apply that simple patch to wireless-drivers-next. > Note, I can't guarantee that I'll not take any wilc1000 patches, I'll > probably forget, but git mv will handle all of that just fine. Good point. To be on the safe side one option is that if I create a topic branch for this simple patch and use v5.8-rc1 as the baseline. Then I would pull the topic branch to wireless-drivers-next and you could pull it to staging-next. That way you would not have wilc1000 in your tree anymore and no accidental submission or commits either :) What do you think? [1 ] https://patchwork.kernel.org/project/linux-wireless/list/?series=307223&state=*&order=date -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org> To: Greg KH <gregkh@linuxfoundation.org> Cc: devel@driverdev.osuosl.org, Ajay.Kathat@microchip.com, Venkateswara.Kaja@microchip.com, linux-wireless@vger.kernel.org, Nicolas.Ferre@microchip.com, Sripad.Balwadgi@microchip.com, johannes@sipsolutions.net Subject: Re: [PATCH v7 00/17] wilc1000: move out of staging Date: Fri, 26 Jun 2020 08:34:48 +0300 [thread overview] Message-ID: <87a70qe6fb.fsf@codeaurora.org> (raw) In-Reply-To: <20200624145254.GA1876138@kroah.com> (Greg KH's message of "Wed, 24 Jun 2020 16:52:54 +0200") Greg KH <gregkh@linuxfoundation.org> writes: > On Wed, Jun 24, 2020 at 12:49:24PM +0300, Kalle Valo wrote: >> Greg KH <gregkh@linuxfoundation.org> writes: >> >> > On Wed, Jun 24, 2020 at 11:50:07AM +0300, Kalle Valo wrote: >> >> <Ajay.Kathat@microchip.com> writes: >> >> >> >> > From: Ajay Singh <ajay.kathat@microchip.com> >> >> > >> >> > This patch series is to review and move wilc1000 driver out of staging. >> >> > Most of the review comments received in [1] & [2] are addressed in the >> >> > latest code. >> >> > Please review and provide your inputs. >> >> > >> >> > [1]. https://lore.kernel.org/linux-wireless/1537957525-11467-1-git-send-email-ajay.kathat@microchip.com/ >> >> > [2]. https://lore.kernel.org/linux-wireless/1562896697-8002-1-git-send-email-ajay.kathat@microchip.com/ >> >> > >> >> > Changes since v6: >> >> > - added Reviewed-by tag received for DT binding document patch earlier. >> >> > * https://lore.kernel.org/linux-wireless/20200405013235.GA24105@bogus >> >> > - merged latest driver and included --base commit as suggested. >> >> >> >> Greg, in preparation for moving the driver to drivers/net/wireless can I >> >> ask you to not to take wilc1000 patches for the time being? I think that >> >> way it would be easier to move the driver between trees if there are no >> >> changes after v5.8-rc1. Or is there a better way handle the move? >> > >> > The best way is for there to be a series of patches that just adds the >> > driver to the "real" part of the tree, and when that is merged, let me >> > know and I will just delete the driver version in the staging tree. >> > >> > Does that work for you? >> >> It would be fine for me but won't that approach break the build (eg. >> allyesconfig) due to two duplicate versions of the same driver in >> wireless-drivers-next? > > For maybe one day, yes, but that's all. > >> What I was thinking that Ajay would create a patch moving the driver >> from drivers/staging/wilc1000 to >> drivers/net/wireless/microchip/wilc1000. Using 'git mv' and 'git >> format-patch --find-renames' the patch should be really small, mostly >> just renames and small changes to Kconfig, Makefile and MAINTAINERS >> files. But this of course would require that there are no wilc1000 >> patches in your tree until you get the driver move commit during the >> next merge window, otherwise we would see conflicts between staging-next >> and wireless-drivers-next. >> >> But I don't have any strong opinions, whatever is easiest for everyone :) > > It's kind of hard to review patches that do moves, but if you all want > to do that, that's fine with me. Actually we have been reviewing the driver with full diffs, one file per patch style[1], so I think everyone are happy. At least I have not heard any complaints. And Ajay already submitted that the simple rename patch proposed, thanks Ajay! https://patchwork.kernel.org/patch/11625025/ And indeed the patch is simple as it can get. So Greg, if it's ok for you I would like to apply that simple patch to wireless-drivers-next. > Note, I can't guarantee that I'll not take any wilc1000 patches, I'll > probably forget, but git mv will handle all of that just fine. Good point. To be on the safe side one option is that if I create a topic branch for this simple patch and use v5.8-rc1 as the baseline. Then I would pull the topic branch to wireless-drivers-next and you could pull it to staging-next. That way you would not have wilc1000 in your tree anymore and no accidental submission or commits either :) What do you think? [1 ] https://patchwork.kernel.org/project/linux-wireless/list/?series=307223&state=*&order=date -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-06-26 5:35 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-23 11:00 [PATCH v7 00/17] wilc1000: move out of staging Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 01/17] wilc1000: add hif.h Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 02/17] wilc1000: add hif.c Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 03/17] wilc1000: add wlan_if.h Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 04/17] wilc1000: add wlan_cfg.h Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 05/17] wilc1000: add wlan_cfg.c Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 06/17] wilc1000: add cfg80211.c Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-24 9:00 ` Johannes Berg 2020-06-24 9:00 ` Johannes Berg 2020-06-23 11:00 ` [PATCH v7 07/17] wilc1000: add cfg80211.h Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 08/17] wilc1000: add netdev.h Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 09/17] wilc1000: add netdev.c Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 10/17] wilc1000: add mon.c Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 12/17] wilc1000: add wlan.h Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 11/17] wilc1000: add spi.c Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 13/17] wilc1000: add wlan.c Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 15/17] wilc1000: add fw.h Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 14/17] wilc1000: add sdio.c Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 17/17] wilc1000: add Makefile and Kconfig files for wilc1000 compilation Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-23 14:52 ` kernel test robot 2020-06-23 14:52 ` kernel test robot 2020-06-23 14:52 ` kernel test robot 2020-06-24 5:26 ` Ajay.Kathat 2020-06-24 5:26 ` Ajay.Kathat 2020-06-24 5:26 ` Ajay.Kathat 2020-06-23 11:00 ` [PATCH v7 16/17] dt: bindings: net: add microchip,wilc1000.yaml Ajay.Kathat 2020-06-23 11:00 ` Ajay.Kathat 2020-06-24 8:50 ` [PATCH v7 00/17] wilc1000: move out of staging Kalle Valo 2020-06-24 8:50 ` Kalle Valo 2020-06-24 9:10 ` Greg KH 2020-06-24 9:10 ` Greg KH 2020-06-24 9:49 ` Kalle Valo 2020-06-24 9:49 ` Kalle Valo 2020-06-24 14:52 ` Greg KH 2020-06-24 14:52 ` Greg KH 2020-06-26 5:34 ` Kalle Valo [this message] 2020-06-26 5:34 ` Kalle Valo 2020-06-26 13:46 ` Greg KH 2020-06-26 13:46 ` Greg KH 2020-07-02 7:05 ` Kalle Valo 2020-07-02 7:05 ` Kalle Valo 2020-06-29 13:26 ` Pali Rohár 2020-06-29 13:26 ` Pali Rohár 2020-06-30 3:17 ` Ajay.Kathat 2020-06-30 3:17 ` Ajay.Kathat 2020-07-01 7:55 ` Pali Rohár 2020-07-01 7:55 ` Pali Rohár 2020-07-01 7:56 ` Pali Rohár 2020-07-01 7:56 ` Pali Rohár 2020-07-06 8:12 ` Ulf Hansson 2020-07-06 8:12 ` Ulf Hansson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87a70qe6fb.fsf@codeaurora.org \ --to=kvalo@codeaurora.org \ --cc=Ajay.Kathat@microchip.com \ --cc=Nicolas.Ferre@microchip.com \ --cc=Sripad.Balwadgi@microchip.com \ --cc=Venkateswara.Kaja@microchip.com \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@linuxfoundation.org \ --cc=johannes@sipsolutions.net \ --cc=linux-wireless@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.