Re: [PATCH] ARM: Avoid discarding sections that might have SMP_ON_UP fixups

[Dave Martin <dave.martin@linaro.org>]

On Thu, Feb 10, 2011 at 2:46 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Thu, Feb 10, 2011 at 02:13:13PM +0000, Dave Martin wrote:
>> On Thu, Feb 10, 2011 at 2:11 PM, Dave Martin <dave.martin@linaro.org> wrote:
>> > Hi, apologies-- didn't see my mail for a bit.
>> >
>> > I get the problem with this tree and config (which builds with
>> > SMP_ON_UP and THUMB2_KERNEL for omap3/4):
>> >
>> > Tree: git://git.linaro.org/people/dmart/linux-2.6-arm.git
>> > dirty/arm/omap-thumb2+merged
>> > Config: http://people.linaro.org/~dmart/arm_omap-thumb2+v2_config
>
> Thanks for the config.
>
>> Note that this tree contains some extra patches (though I believe
>> nothing is there which should cause the problem), and does not contain
>> everything from rmk/devel -- so it's possible this has been fixed in
>> the meantime or no longer occurs for some other reason...
>
> No need - I now have some modules which contain SMP alternatives, so we
> do need to fix the module loader for this, and keep the SMP alternatives
> replacement code around.  It's not worth eliminating the code as if we
> include an informative printk() to say why we're refusing to load the
> module, the string would be larger than the code it eliminates.  So, I
> think we need to merge the patch below to avoid run-time problems.

I thought the problem was not caused by removal of the fixup code, but
rather by the removal of code referenced by fixups?

Cheers
---Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html