From: Linus Walleij <linus.walleij@linaro.org> To: H Hartley Sweeten <hartleys@visionengravers.com>, Grant Likely <grant.likely@secretlab.ca> Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Lee Jones <lee.jones@linaro.org>, Jonas Aaberg <jonas.aberg@stericsson.com> Subject: Re: [PATCH 02/10] mach-u300: rewrite gpio driver, move to drivers/gpio Date: Thu, 28 Apr 2011 09:07:33 +0200 [thread overview] Message-ID: <BANLkTikc7B5J0Z_aiS5kXCxMSxcFrfSRxw@mail.gmail.com> (raw) In-Reply-To: <0D753D10438DA54287A00B027084269764D2650215@AUSP01VMBX24.collaborationhost.net> 2011/4/27 H Hartley Sweeten <hartleys@visionengravers.com>: > On Wednesday, April 27, 2011 6:13 AM, Linus Walleij wrote: >> From: Linus Walleij <linus.walleij@linaro.org> >> >> This rewrites the U300 GPIO driver using gpiolib and the irq_chip >> abstractions, makes it runtime-configured rather than compile-time, >> and moves it to the drivers/gpio subsystem where it belongs, >> depopulating the ARM tree of one more driver. >> >> Cc: Jonas Aaberg <jonas.aberg@stericsson.com> >> Acked-by: Arnd Bergmann <arnd@arndb.de> >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > > If this and other platform-specific GPIO drivers are going to be > moved to the drivers/gpio subsystem, the Kconfig and Makefile should > probably be updated to reflect this. > > In drivers/gpio/Kconfig: > > # > # platform-neutral GPIO infrastructure and expanders > # > > And in drivers/gpio/Makefile: > > # generic gpio support: dedicated expander chips, etc > # > # NOTE: platform-specific GPIO drivers don't belong in the > # drivers/gpio directory; put them with other platform setup > # code, IRQ controllers, board init, etc. Yeah, you're right. I can take these comments out, simply. I'll review the files as bit to make sure there aren't any more statements like that. > The Makefile should probably be reordered, either alphabetically > or grouped by type (arch/mmio/i2c/spi/pci/etc) and then > alphabetically in order to reduce merge conflicts. Yes, but if I do that in my patchset I will screw up Grants GPIO tree completely, so I prefer that Grant do this. And maybe after pulling in my GPIO consolidation tree to his in that case, so we don't get undesired collisions. So leaving this for the GPIO maintainer. Yours, Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 02/10] mach-u300: rewrite gpio driver, move to drivers/gpio Date: Thu, 28 Apr 2011 09:07:33 +0200 [thread overview] Message-ID: <BANLkTikc7B5J0Z_aiS5kXCxMSxcFrfSRxw@mail.gmail.com> (raw) In-Reply-To: <0D753D10438DA54287A00B027084269764D2650215@AUSP01VMBX24.collaborationhost.net> 2011/4/27 H Hartley Sweeten <hartleys@visionengravers.com>: > On Wednesday, April 27, 2011 6:13 AM, Linus Walleij wrote: >> From: Linus Walleij <linus.walleij@linaro.org> >> >> This rewrites the U300 GPIO driver using gpiolib and the irq_chip >> abstractions, makes it runtime-configured rather than compile-time, >> and moves it to the drivers/gpio subsystem where it belongs, >> depopulating the ARM tree of one more driver. >> >> Cc: Jonas Aaberg <jonas.aberg@stericsson.com> >> Acked-by: Arnd Bergmann <arnd@arndb.de> >> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > > If this and other platform-specific GPIO drivers are going to be > moved to the drivers/gpio subsystem, the Kconfig and Makefile should > probably be updated to reflect this. > > In drivers/gpio/Kconfig: > > # > # platform-neutral GPIO infrastructure and expanders > # > > And in drivers/gpio/Makefile: > > # generic gpio support: dedicated expander chips, etc > # > # NOTE: platform-specific GPIO drivers don't belong in the > # drivers/gpio directory; put them with other platform setup > # code, IRQ controllers, board init, etc. Yeah, you're right. I can take these comments out, simply. I'll review the files as bit to make sure there aren't any more statements like that. > The Makefile should probably be reordered, either alphabetically > or grouped by type (arch/mmio/i2c/spi/pci/etc) and then > alphabetically in order to reduce merge conflicts. Yes, but if I do that in my patchset I will screw up Grants GPIO tree completely, so I prefer that Grant do this. And maybe after pulling in my GPIO consolidation tree to his in that case, so we don't get undesired collisions. So leaving this for the GPIO maintainer. Yours, Linus Walleij
next prev parent reply other threads:[~2011-04-28 7:07 UTC|newest] Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-04-27 13:13 [PATCH 02/10] mach-u300: rewrite gpio driver, move to drivers/gpio Linus Walleij 2011-04-27 13:13 ` Linus Walleij 2011-04-27 18:23 ` H Hartley Sweeten 2011-04-27 18:23 ` H Hartley Sweeten 2011-04-28 7:07 ` Linus Walleij [this message] 2011-04-28 7:07 ` Linus Walleij 2011-04-28 7:10 ` Linus Walleij 2011-04-28 7:10 ` Linus Walleij 2011-04-28 17:41 ` H Hartley Sweeten 2011-04-28 17:41 ` H Hartley Sweeten 2011-05-13 14:51 ` Linus Walleij 2011-05-13 14:51 ` Linus Walleij 2011-05-19 8:56 ` Shawn Guo 2011-05-19 8:56 ` Shawn Guo 2011-05-19 12:21 ` Linus Walleij 2011-05-19 12:21 ` Linus Walleij 2011-05-19 13:56 ` Shawn Guo 2011-05-19 13:56 ` Shawn Guo 2011-05-19 19:11 ` Sascha Hauer 2011-05-19 19:11 ` Sascha Hauer 2011-05-19 19:30 ` Nicolas Pitre 2011-05-19 19:30 ` Nicolas Pitre 2011-05-20 3:18 ` Shawn Guo 2011-05-20 3:18 ` Shawn Guo 2011-05-20 3:43 ` Kyungmin Park 2011-05-20 3:43 ` Kyungmin Park 2011-05-20 3:54 ` Nicolas Pitre 2011-05-20 3:54 ` Nicolas Pitre 2011-05-19 21:18 ` H Hartley Sweeten 2011-05-19 21:18 ` H Hartley Sweeten 2011-05-20 1:50 ` Jamie Iles 2011-05-20 1:50 ` Jamie Iles 2011-05-20 22:07 ` H Hartley Sweeten 2011-05-20 22:07 ` H Hartley Sweeten 2011-05-21 13:03 ` Jamie Iles 2011-05-21 13:03 ` Jamie Iles 2011-05-20 7:01 ` Grant Likely 2011-05-20 7:01 ` Grant Likely 2011-05-20 7:47 ` Linus Walleij 2011-05-20 7:47 ` Linus Walleij 2011-05-19 11:11 ` Barry Song 2011-05-19 11:38 ` Barry Song 2011-05-19 11:38 ` Barry Song 2011-05-19 12:25 ` Linus Walleij 2011-05-19 12:25 ` Linus Walleij 2011-05-19 12:35 ` Barry Song 2011-05-19 12:35 ` Barry Song 2011-05-19 13:17 ` Linus Walleij 2011-05-19 13:17 ` Linus Walleij 2011-05-19 14:05 ` Barry Song 2011-05-19 14:05 ` Barry Song 2011-05-20 6:58 ` Grant Likely 2011-05-20 6:58 ` Grant Likely 2011-05-20 6:52 ` Grant Likely 2011-05-20 6:52 ` Grant Likely 2011-05-20 7:46 ` Linus Walleij 2011-05-20 7:46 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=BANLkTikc7B5J0Z_aiS5kXCxMSxcFrfSRxw@mail.gmail.com \ --to=linus.walleij@linaro.org \ --cc=grant.likely@secretlab.ca \ --cc=hartleys@visionengravers.com \ --cc=jonas.aberg@stericsson.com \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.