From: Andrey Konovalov <andreyknvl@google.com> To: Marco Elver <elver@google.com> Cc: Catalin Marinas <catalin.marinas@arm.com>, Vincenzo Frascino <vincenzo.frascino@arm.com>, Dmitry Vyukov <dvyukov@google.com>, Alexander Potapenko <glider@google.com>, Andrew Morton <akpm@linux-foundation.org>, Will Deacon <will.deacon@arm.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Peter Collingbourne <pcc@google.com>, Evgenii Stepanov <eugenis@google.com>, Branislav Rankov <Branislav.Rankov@arm.com>, Kevin Brodsky <kevin.brodsky@arm.com>, kasan-dev <kasan-dev@googlegroups.com>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Linux Memory Management List <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 02/12] kasan, mm: optimize kmalloc poisoning Date: Tue, 2 Feb 2021 18:15:58 +0100 [thread overview] Message-ID: <CAAeHK+xzBpdzO7BmdVZe3_g5Di+-AGyYAO5zBVvOpEUtXD8koA@mail.gmail.com> (raw) In-Reply-To: <YBl9C+q84BqiFd4F@elver.google.com> On Tue, Feb 2, 2021 at 5:25 PM Marco Elver <elver@google.com> wrote: > > > +#ifdef CONFIG_KASAN_GENERIC > > + > > +/** > > + * kasan_poison_last_granule - mark the last granule of the memory range as > > + * unaccessible > > + * @addr - range start address, must be aligned to KASAN_GRANULE_SIZE > > + * @size - range size > > + * > > + * This function is only available for the generic mode, as it's the only mode > > + * that has partially poisoned memory granules. > > + */ > > +void kasan_poison_last_granule(const void *address, size_t size); > > + > > +#else /* CONFIG_KASAN_GENERIC */ > > + > > +static inline void kasan_poison_last_granule(const void *address, size_t size) { } ^ > > + > > +#endif /* CONFIG_KASAN_GENERIC */ > > + > > /* > > * Exported functions for interfaces called from assembly or from generated > > * code. Declarations here to avoid warning about missing declarations. > > @@ -96,6 +92,16 @@ void kasan_poison(const void *address, size_t size, u8 value) > > } > > EXPORT_SYMBOL(kasan_poison); > > > > +#ifdef CONFIG_KASAN_GENERIC > > +void kasan_poison_last_granule(const void *address, size_t size) > > +{ > > + if (size & KASAN_GRANULE_MASK) { > > + u8 *shadow = (u8 *)kasan_mem_to_shadow(address + size); > > + *shadow = size & KASAN_GRANULE_MASK; > > + } > > +} > > +#endif > > The function declaration still needs to exist in the dead branch if > !IS_ENABLED(CONFIG_KASAN_GENERIC). It appears in that case it's declared > (in kasan.h), but not defined. We shouldn't get linker errors because > the optimizer should remove the dead branch. Nevertheless, is this code > generally acceptable? The function is defined as empty when !CONFIG_KASAN_GENERIC, see above.
WARNING: multiple messages have this Message-ID (diff)
From: Andrey Konovalov <andreyknvl@google.com> To: Marco Elver <elver@google.com> Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>, Branislav Rankov <Branislav.Rankov@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Kevin Brodsky <kevin.brodsky@arm.com>, Will Deacon <will.deacon@arm.com>, LKML <linux-kernel@vger.kernel.org>, kasan-dev <kasan-dev@googlegroups.com>, Linux Memory Management List <linux-mm@kvack.org>, Alexander Potapenko <glider@google.com>, Evgenii Stepanov <eugenis@google.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Andrew Morton <akpm@linux-foundation.org>, Vincenzo Frascino <vincenzo.frascino@arm.com>, Peter Collingbourne <pcc@google.com>, Dmitry Vyukov <dvyukov@google.com> Subject: Re: [PATCH 02/12] kasan, mm: optimize kmalloc poisoning Date: Tue, 2 Feb 2021 18:15:58 +0100 [thread overview] Message-ID: <CAAeHK+xzBpdzO7BmdVZe3_g5Di+-AGyYAO5zBVvOpEUtXD8koA@mail.gmail.com> (raw) In-Reply-To: <YBl9C+q84BqiFd4F@elver.google.com> On Tue, Feb 2, 2021 at 5:25 PM Marco Elver <elver@google.com> wrote: > > > +#ifdef CONFIG_KASAN_GENERIC > > + > > +/** > > + * kasan_poison_last_granule - mark the last granule of the memory range as > > + * unaccessible > > + * @addr - range start address, must be aligned to KASAN_GRANULE_SIZE > > + * @size - range size > > + * > > + * This function is only available for the generic mode, as it's the only mode > > + * that has partially poisoned memory granules. > > + */ > > +void kasan_poison_last_granule(const void *address, size_t size); > > + > > +#else /* CONFIG_KASAN_GENERIC */ > > + > > +static inline void kasan_poison_last_granule(const void *address, size_t size) { } ^ > > + > > +#endif /* CONFIG_KASAN_GENERIC */ > > + > > /* > > * Exported functions for interfaces called from assembly or from generated > > * code. Declarations here to avoid warning about missing declarations. > > @@ -96,6 +92,16 @@ void kasan_poison(const void *address, size_t size, u8 value) > > } > > EXPORT_SYMBOL(kasan_poison); > > > > +#ifdef CONFIG_KASAN_GENERIC > > +void kasan_poison_last_granule(const void *address, size_t size) > > +{ > > + if (size & KASAN_GRANULE_MASK) { > > + u8 *shadow = (u8 *)kasan_mem_to_shadow(address + size); > > + *shadow = size & KASAN_GRANULE_MASK; > > + } > > +} > > +#endif > > The function declaration still needs to exist in the dead branch if > !IS_ENABLED(CONFIG_KASAN_GENERIC). It appears in that case it's declared > (in kasan.h), but not defined. We shouldn't get linker errors because > the optimizer should remove the dead branch. Nevertheless, is this code > generally acceptable? The function is defined as empty when !CONFIG_KASAN_GENERIC, see above. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-02 17:19 UTC|newest] Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-01 19:43 [PATCH 00/12] kasan: optimizations and fixes for HW_TAGS Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-01 19:43 ` [PATCH 01/12] kasan, mm: don't save alloc stacks twice Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-02 16:06 ` Marco Elver 2021-02-02 16:06 ` Marco Elver 2021-02-02 18:01 ` Andrey Konovalov 2021-02-02 18:01 ` Andrey Konovalov 2021-02-02 18:01 ` Andrey Konovalov 2021-02-02 18:40 ` Marco Elver 2021-02-02 18:40 ` Marco Elver 2021-02-02 18:40 ` Marco Elver 2021-02-01 19:43 ` [PATCH 02/12] kasan, mm: optimize kmalloc poisoning Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-02 16:25 ` Marco Elver 2021-02-02 16:25 ` Marco Elver 2021-02-02 17:15 ` Andrey Konovalov [this message] 2021-02-02 17:15 ` Andrey Konovalov 2021-02-02 17:15 ` Andrey Konovalov 2021-02-02 17:39 ` Marco Elver 2021-02-02 17:39 ` Marco Elver 2021-02-02 17:39 ` Marco Elver 2021-02-01 19:43 ` [PATCH 03/12] kasan: optimize large " Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-02 16:57 ` Marco Elver 2021-02-02 16:57 ` Marco Elver 2021-02-01 19:43 ` [PATCH 04/12] kasan: clean up setting free info in kasan_slab_free Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-02 17:03 ` Marco Elver 2021-02-02 17:03 ` Marco Elver 2021-02-01 19:43 ` [PATCH 05/12] kasan: unify large kfree checks Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-03 12:13 ` Marco Elver 2021-02-03 12:13 ` Marco Elver 2021-02-01 19:43 ` [PATCH 06/12] kasan: rework krealloc tests Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-03 14:48 ` Marco Elver 2021-02-03 14:48 ` Marco Elver 2021-02-01 19:43 ` [PATCH 07/12] kasan, mm: remove krealloc side-effect Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-03 15:10 ` Marco Elver 2021-02-03 15:10 ` Marco Elver 2021-02-01 19:43 ` [PATCH 08/12] kasan, mm: optimize krealloc poisoning Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-03 14:34 ` Marco Elver 2021-02-03 14:34 ` Marco Elver 2021-02-01 19:43 ` [PATCH 09/12] kasan: ensure poisoning size alignment Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-03 15:31 ` Marco Elver 2021-02-03 15:31 ` Marco Elver 2021-02-01 19:43 ` [PATCH 10/12] arm64: kasan: simplify and inline MTE functions Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-01 22:44 ` Andrew Morton 2021-02-01 22:44 ` Andrew Morton 2021-02-04 12:39 ` Vincenzo Frascino 2021-02-04 12:39 ` Vincenzo Frascino 2021-02-02 15:42 ` Catalin Marinas 2021-02-02 15:42 ` Catalin Marinas 2021-02-02 18:04 ` Andrey Konovalov 2021-02-02 18:04 ` Andrey Konovalov 2021-02-02 18:04 ` Andrey Konovalov 2021-02-04 12:37 ` Vincenzo Frascino 2021-02-04 12:37 ` Vincenzo Frascino 2021-02-01 19:43 ` [PATCH 11/12] kasan: always inline HW_TAGS helper functions Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-03 15:51 ` Marco Elver 2021-02-03 15:51 ` Marco Elver 2021-02-01 19:43 ` [PATCH 12/12] arm64: kasan: export MTE symbols for KASAN tests Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-01 19:43 ` Andrey Konovalov 2021-02-02 10:46 ` Will Deacon 2021-02-02 10:46 ` Will Deacon 2021-02-02 13:42 ` Andrey Konovalov 2021-02-02 13:42 ` Andrey Konovalov 2021-02-02 13:42 ` Andrey Konovalov 2021-02-02 15:43 ` Catalin Marinas 2021-02-02 15:43 ` Catalin Marinas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAAeHK+xzBpdzO7BmdVZe3_g5Di+-AGyYAO5zBVvOpEUtXD8koA@mail.gmail.com \ --to=andreyknvl@google.com \ --cc=Branislav.Rankov@arm.com \ --cc=akpm@linux-foundation.org \ --cc=aryabinin@virtuozzo.com \ --cc=catalin.marinas@arm.com \ --cc=dvyukov@google.com \ --cc=elver@google.com \ --cc=eugenis@google.com \ --cc=glider@google.com \ --cc=kasan-dev@googlegroups.com \ --cc=kevin.brodsky@arm.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=pcc@google.com \ --cc=vincenzo.frascino@arm.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.