All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Stanley <joel@jms.id.au>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Billy Tsai <billy_tsai@aspeedtech.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Rob Herring <robh+dt@kernel.org>,
	Andrew Jeffery <andrew@aj.id.au>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	lgirdwood@gmail.com, Mark Brown <broonie@kernel.org>,
	linux-iio@vger.kernel.org,
	devicetree <devicetree@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	linux-aspeed <linux-aspeed@lists.ozlabs.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	BMC-SW <BMC-SW@aspeedtech.com>
Subject: Re: [v5 04/15] iio: adc: aspeed: Keep model data to driver data.
Date: Thu, 16 Sep 2021 03:52:24 +0000	[thread overview]
Message-ID: <CACPK8Xe4KifkDxm0H6LtpCJZ1n07GLvxR_nF4Cfy5+4WXn9Z6g@mail.gmail.com> (raw)
In-Reply-To: <20210905155029.3faa2c04@jic23-huawei>

On Sun, 5 Sept 2021 at 14:47, Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Sun, 5 Sep 2021 15:33:39 +0100
> Jonathan Cameron <jic23@kernel.org> wrote:
>
> > On Tue, 31 Aug 2021 15:14:47 +0800
> > Billy Tsai <billy_tsai@aspeedtech.com> wrote:
> >
> > > Keep the model data pointer to driver data for reducing the usage of
> > > of_device_get_match_data().
> > >
> > > Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
> > This one starts to be impacted by the fix (as its in the context).
> > Rather than making a mess of things for linux-next etc I'll hold
> > off on these until that fix is upstream in a few weeks.
> >
> > If I seem to have lost it (it's been known to happen :( ) then
> > feel free to poke me!
>
> Having taken another look at the rest of the series (and Philipp's review)
> please do a v6 starting from this patch.

I'd recommend against the practice of half applying a series. I have
just spent a good chunk of time looking at v6, and wondering why it
won't apply to any tags in Linus tree nor to next.

(It was made worse by the branch you applied them to not being part of
linux-next.)

Cheers,

Joel

WARNING: multiple messages have this Message-ID (diff)
From: Joel Stanley <joel@jms.id.au>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Billy Tsai <billy_tsai@aspeedtech.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	 Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Rob Herring <robh+dt@kernel.org>,
	Andrew Jeffery <andrew@aj.id.au>,
	 Philipp Zabel <p.zabel@pengutronix.de>,
	lgirdwood@gmail.com,  Mark Brown <broonie@kernel.org>,
	linux-iio@vger.kernel.org,
	 devicetree <devicetree@vger.kernel.org>,
	 Linux ARM <linux-arm-kernel@lists.infradead.org>,
	 linux-aspeed <linux-aspeed@lists.ozlabs.org>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	BMC-SW <BMC-SW@aspeedtech.com>
Subject: Re: [v5 04/15] iio: adc: aspeed: Keep model data to driver data.
Date: Thu, 16 Sep 2021 03:52:24 +0000	[thread overview]
Message-ID: <CACPK8Xe4KifkDxm0H6LtpCJZ1n07GLvxR_nF4Cfy5+4WXn9Z6g@mail.gmail.com> (raw)
In-Reply-To: <20210905155029.3faa2c04@jic23-huawei>

On Sun, 5 Sept 2021 at 14:47, Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Sun, 5 Sep 2021 15:33:39 +0100
> Jonathan Cameron <jic23@kernel.org> wrote:
>
> > On Tue, 31 Aug 2021 15:14:47 +0800
> > Billy Tsai <billy_tsai@aspeedtech.com> wrote:
> >
> > > Keep the model data pointer to driver data for reducing the usage of
> > > of_device_get_match_data().
> > >
> > > Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
> > This one starts to be impacted by the fix (as its in the context).
> > Rather than making a mess of things for linux-next etc I'll hold
> > off on these until that fix is upstream in a few weeks.
> >
> > If I seem to have lost it (it's been known to happen :( ) then
> > feel free to poke me!
>
> Having taken another look at the rest of the series (and Philipp's review)
> please do a v6 starting from this patch.

I'd recommend against the practice of half applying a series. I have
just spent a good chunk of time looking at v6, and wondering why it
won't apply to any tags in Linus tree nor to next.

(It was made worse by the branch you applied them to not being part of
linux-next.)

Cheers,

Joel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-16  3:52 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-31  7:14 [v5 00/15] Add support for ast2600 ADC Billy Tsai
2021-08-31  7:14 ` Billy Tsai
2021-08-31  7:14 ` [v5 01/15] iio: adc: aspeed: set driver data when adc probe Billy Tsai
2021-08-31  7:14   ` Billy Tsai
2021-09-05 14:25   ` Jonathan Cameron
2021-09-05 14:25     ` Jonathan Cameron
2021-08-31  7:14 ` [v5 02/15] dt-bindings: iio: adc: Add ast2600-adc bindings Billy Tsai
2021-08-31  7:14   ` Billy Tsai
2021-09-01  1:38   ` Rob Herring
2021-09-01  1:38     ` Rob Herring
2021-09-05 14:27     ` Jonathan Cameron
2021-09-05 14:27       ` Jonathan Cameron
2021-08-31  7:14 ` [v5 03/15] iio: adc: aspeed: completes the bitfield declare Billy Tsai
2021-08-31  7:14   ` Billy Tsai
2021-09-05 14:30   ` Jonathan Cameron
2021-09-05 14:30     ` Jonathan Cameron
2021-08-31  7:14 ` [v5 04/15] iio: adc: aspeed: Keep model data to driver data Billy Tsai
2021-08-31  7:14   ` Billy Tsai
2021-09-05 14:33   ` Jonathan Cameron
2021-09-05 14:33     ` Jonathan Cameron
2021-09-05 14:50     ` Jonathan Cameron
2021-09-05 14:50       ` Jonathan Cameron
2021-09-16  3:52       ` Joel Stanley [this message]
2021-09-16  3:52         ` Joel Stanley
2021-09-18 17:55         ` Jonathan Cameron
2021-09-18 17:55           ` Jonathan Cameron
2021-08-31  7:14 ` [v5 05/15] iio: adc: aspeed: Refactory model data structure Billy Tsai
2021-08-31  7:14   ` Billy Tsai
2021-09-05 14:37   ` Jonathan Cameron
2021-09-05 14:37     ` Jonathan Cameron
2021-08-31  7:14 ` [v5 06/15] iio: adc: aspeed: Add vref config function Billy Tsai
2021-08-31  7:14   ` Billy Tsai
2021-08-31  7:14 ` [v5 07/15] iio: adc: aspeed: Set num_channels with model data Billy Tsai
2021-08-31  7:14   ` Billy Tsai
2021-08-31  7:14 ` [v5 08/15] iio: adc: aspeed: Use model_data to set clk scaler Billy Tsai
2021-08-31  7:14   ` Billy Tsai
2021-08-31  7:14 ` [v5 09/15] iio: adc: aspeed: Use devm_add_action_or_reset Billy Tsai
2021-08-31  7:14   ` Billy Tsai
2021-08-31  7:51   ` Philipp Zabel
2021-08-31  7:51     ` Philipp Zabel
2021-08-31  7:14 ` [v5 10/15] iio: adc: aspeed: Support ast2600 adc Billy Tsai
2021-08-31  7:14   ` Billy Tsai
2021-08-31  7:14 ` [v5 11/15] iio: adc: aspeed: Fix the calculate error of clock Billy Tsai
2021-08-31  7:14   ` Billy Tsai
2021-09-05 14:47   ` Jonathan Cameron
2021-09-05 14:47     ` Jonathan Cameron
2021-08-31  7:14 ` [v5 12/15] iio: adc: aspeed: Add func to set sampling rate Billy Tsai
2021-08-31  7:14   ` Billy Tsai
2021-08-31  7:14 ` [v5 13/15] iio: adc: aspeed: Add compensation phase Billy Tsai
2021-08-31  7:14   ` Billy Tsai
2021-08-31  7:14 ` [v5 14/15] iio: adc: aspeed: Support battery sensing Billy Tsai
2021-08-31  7:14   ` Billy Tsai
2021-08-31  7:14 ` [v5 15/15] iio: adc: aspeed: Get and set trimming data Billy Tsai
2021-08-31  7:14   ` Billy Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACPK8Xe4KifkDxm0H6LtpCJZ1n07GLvxR_nF4Cfy5+4WXn9Z6g@mail.gmail.com \
    --to=joel@jms.id.au \
    --cc=BMC-SW@aspeedtech.com \
    --cc=andrew@aj.id.au \
    --cc=billy_tsai@aspeedtech.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.