From: Peter Maydell <peter.maydell@linaro.org> To: Markus Armbruster <armbru@redhat.com> Cc: bin.meng@windriver.com, mark.cave-ayland@ilande.co.uk, qemu-devel@nongnu.org, edgar.iglesias@gmail.com, sundeep.lkml@gmail.com, qemu-block@nongnu.org, andrew.smirnov@gmail.com, hskinnemoen@google.com, joel@jms.id.au, atar4qemu@gmail.com, alistair@alistair23.me, b.galvani@gmail.com, nieklinnenbank@gmail.com, qemu-arm@nongnu.org, clg@kaod.org, kwolf@redhat.com, qemu-riscv@nongnu.org, andrew@aj.id.au, f4bug@amsat.org, Andrew.Baumann@microsoft.com, jcd@tribudubois.net, kfting@nuvoton.com, hreitz@redhat.com, palmer@dabbelt.com Subject: Re: [PATCH RFC 1/2] hw/sd/ssi-sd: Do not create SD card within controller's realize Date: Mon, 15 Nov 2021 13:40:36 +0000 [thread overview] Message-ID: <CAFEAcA94NzZq6fnvvF6aRJtHV29Wnrtudz4QKSoADo6=-QF5JA@mail.gmail.com> (raw) In-Reply-To: <20211115125536.3341681-2-armbru@redhat.com> On Mon, 15 Nov 2021 at 12:56, Markus Armbruster <armbru@redhat.com> wrote: > > ssi_sd_realize() creates an "sd-card" device. This is inappropriate, > and marked FIXME. > > Move it to the boards that create these devices. Prior art: commit > eb4f566bbb for device "generic-sdhci", and commit 26c607b86b for > device "pl181". > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > @@ -670,7 +672,7 @@ static void sifive_u_machine_init(MachineState *machine) > > /* Connect an SPI flash to SPI0 */ > flash_dev = qdev_new("is25wp256"); > - dinfo = drive_get_next(IF_MTD); > + dinfo = drive_get(IF_MTD, 0, 0); > if (dinfo) { > qdev_prop_set_drive_err(flash_dev, "drive", > blk_by_legacy_dinfo(dinfo), This part looks like it should have been in the other patch. -- PMM
WARNING: multiple messages have this Message-ID (diff)
From: Peter Maydell <peter.maydell@linaro.org> To: Markus Armbruster <armbru@redhat.com> Cc: qemu-devel@nongnu.org, kwolf@redhat.com, hreitz@redhat.com, clg@kaod.org, andrew@aj.id.au, joel@jms.id.au, b.galvani@gmail.com, jcd@tribudubois.net, andrew.smirnov@gmail.com, sundeep.lkml@gmail.com, hskinnemoen@google.com, kfting@nuvoton.com, nieklinnenbank@gmail.com, Andrew.Baumann@microsoft.com, f4bug@amsat.org, edgar.iglesias@gmail.com, alistair@alistair23.me, bin.meng@windriver.com, palmer@dabbelt.com, atar4qemu@gmail.com, mark.cave-ayland@ilande.co.uk, qemu-block@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org Subject: Re: [PATCH RFC 1/2] hw/sd/ssi-sd: Do not create SD card within controller's realize Date: Mon, 15 Nov 2021 13:40:36 +0000 [thread overview] Message-ID: <CAFEAcA94NzZq6fnvvF6aRJtHV29Wnrtudz4QKSoADo6=-QF5JA@mail.gmail.com> (raw) In-Reply-To: <20211115125536.3341681-2-armbru@redhat.com> On Mon, 15 Nov 2021 at 12:56, Markus Armbruster <armbru@redhat.com> wrote: > > ssi_sd_realize() creates an "sd-card" device. This is inappropriate, > and marked FIXME. > > Move it to the boards that create these devices. Prior art: commit > eb4f566bbb for device "generic-sdhci", and commit 26c607b86b for > device "pl181". > > Signed-off-by: Markus Armbruster <armbru@redhat.com> > --- > @@ -670,7 +672,7 @@ static void sifive_u_machine_init(MachineState *machine) > > /* Connect an SPI flash to SPI0 */ > flash_dev = qdev_new("is25wp256"); > - dinfo = drive_get_next(IF_MTD); > + dinfo = drive_get(IF_MTD, 0, 0); > if (dinfo) { > qdev_prop_set_drive_err(flash_dev, "drive", > blk_by_legacy_dinfo(dinfo), This part looks like it should have been in the other patch. -- PMM
next prev parent reply other threads:[~2021-11-15 13:43 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-11-15 12:55 [PATCH RFC 0/2] Eliminate drive_get_next() Markus Armbruster 2021-11-15 12:55 ` Markus Armbruster 2021-11-15 12:55 ` [PATCH RFC 1/2] hw/sd/ssi-sd: Do not create SD card within controller's realize Markus Armbruster 2021-11-15 12:55 ` Markus Armbruster 2021-11-15 13:40 ` Peter Maydell [this message] 2021-11-15 13:40 ` Peter Maydell 2021-11-15 13:48 ` Markus Armbruster 2021-11-15 13:48 ` Markus Armbruster 2021-11-15 12:55 ` [PATCH RFC 2/2] hw: Replace drive_get_next() by drive_get() Markus Armbruster 2021-11-15 12:55 ` Markus Armbruster 2021-11-15 13:38 ` Peter Maydell 2021-11-15 13:38 ` Peter Maydell 2021-11-15 13:48 ` Markus Armbruster 2021-11-15 13:48 ` Markus Armbruster 2021-11-15 13:59 ` Philippe Mathieu-Daudé 2021-11-15 13:59 ` Philippe Mathieu-Daudé 2021-11-15 15:57 ` Markus Armbruster 2021-11-15 15:57 ` Markus Armbruster 2021-11-15 21:15 ` Philippe Mathieu-Daudé 2021-11-15 21:15 ` Philippe Mathieu-Daudé 2021-11-16 7:47 ` Markus Armbruster 2021-11-16 7:47 ` Markus Armbruster 2021-11-16 8:52 ` Cédric Le Goater 2021-11-16 8:52 ` Cédric Le Goater 2021-11-16 9:29 ` Markus Armbruster 2021-11-16 9:29 ` Markus Armbruster 2021-11-16 12:14 ` Cédric Le Goater 2021-11-16 12:14 ` Cédric Le Goater 2021-11-15 14:05 ` [PATCH RFC 0/2] Eliminate drive_get_next() Peter Maydell 2021-11-15 14:05 ` Peter Maydell 2021-11-15 16:01 ` Markus Armbruster 2021-11-15 16:01 ` Markus Armbruster
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAFEAcA94NzZq6fnvvF6aRJtHV29Wnrtudz4QKSoADo6=-QF5JA@mail.gmail.com' \ --to=peter.maydell@linaro.org \ --cc=Andrew.Baumann@microsoft.com \ --cc=alistair@alistair23.me \ --cc=andrew.smirnov@gmail.com \ --cc=andrew@aj.id.au \ --cc=armbru@redhat.com \ --cc=atar4qemu@gmail.com \ --cc=b.galvani@gmail.com \ --cc=bin.meng@windriver.com \ --cc=clg@kaod.org \ --cc=edgar.iglesias@gmail.com \ --cc=f4bug@amsat.org \ --cc=hreitz@redhat.com \ --cc=hskinnemoen@google.com \ --cc=jcd@tribudubois.net \ --cc=joel@jms.id.au \ --cc=kfting@nuvoton.com \ --cc=kwolf@redhat.com \ --cc=mark.cave-ayland@ilande.co.uk \ --cc=nieklinnenbank@gmail.com \ --cc=palmer@dabbelt.com \ --cc=qemu-arm@nongnu.org \ --cc=qemu-block@nongnu.org \ --cc=qemu-devel@nongnu.org \ --cc=qemu-riscv@nongnu.org \ --cc=sundeep.lkml@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.