From: Romain Izard <romain.izard.pro@gmail.com> To: "Stephan Müller" <smueller@chronox.de> Cc: linux-crypto@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>, Cyrille Pitchen <cyrille.pitchen@microchip.com>, Tudor Ambarus <tudor.ambarus@microchip.com>, Nicolas Ferre <nicolas.ferre@microchip.com>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH] crypto: AF_ALG - remove locking in async callback Date: Mon, 30 Oct 2017 18:15:32 +0100 [thread overview] Message-ID: <CAGkQfmO+c6m-1v9ztV-G68JXSupD+pMv0czpoieg0a5PyLQ_dg@mail.gmail.com> (raw) In-Reply-To: <5260911.ZuXsrgFD2R@positron.chronox.de> 2017-10-29 21:39 GMT+01:00 Stephan Müller <smueller@chronox.de>: > Am Mittwoch, 25. Oktober 2017, 17:26:31 CET schrieb Romain Izard: > > Hi Romain, > > the patch below should cover the issue you see. Would you mind testing it? > > Thanks > Stephan > > ---8<--- > > The code paths protected by the socket-lock do not use or modify the > socket in a non-atomic fashion. The actions pertaining the socket do not > even need to be handled as an atomic operation. Thus, the socket-lock > can be safely ignored. > > This fixes a bug regarding scheduling in atomic as the callback function > may be invoked in interrupt context. > > Fixes: 2d97591ef43d0 ("crypto: af_alg - consolidation of duplicate code") > Reported-by: Romain Izard <romain.izard.pro@gmail.com> > Signed-off-by: Stephan Mueller <smueller@chronox.de> Tested-by: Romain Izard <romain.izard.pro@gmail.com> The issue observed with atmel-aes is not reproduced anymore. > --- > crypto/af_alg.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/crypto/af_alg.c b/crypto/af_alg.c > index 337cf382718e..a41f08642eee 100644 > --- a/crypto/af_alg.c > +++ b/crypto/af_alg.c > @@ -1063,8 +1063,6 @@ void af_alg_async_cb(struct crypto_async_request *_req, int err) > struct kiocb *iocb = areq->iocb; > unsigned int resultlen; > > - lock_sock(sk); > - > /* Buffer size written by crypto operation. */ > resultlen = areq->outlen; > > @@ -1073,8 +1071,6 @@ void af_alg_async_cb(struct crypto_async_request *_req, int err) > __sock_put(sk); > > iocb->ki_complete(iocb, err ? err : resultlen, 0); > - > - release_sock(sk); > } > EXPORT_SYMBOL_GPL(af_alg_async_cb); > > -- > 2.13.6 > >
WARNING: multiple messages have this Message-ID (diff)
From: romain.izard.pro@gmail.com (Romain Izard) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] crypto: AF_ALG - remove locking in async callback Date: Mon, 30 Oct 2017 18:15:32 +0100 [thread overview] Message-ID: <CAGkQfmO+c6m-1v9ztV-G68JXSupD+pMv0czpoieg0a5PyLQ_dg@mail.gmail.com> (raw) In-Reply-To: <5260911.ZuXsrgFD2R@positron.chronox.de> 2017-10-29 21:39 GMT+01:00 Stephan M?ller <smueller@chronox.de>: > Am Mittwoch, 25. Oktober 2017, 17:26:31 CET schrieb Romain Izard: > > Hi Romain, > > the patch below should cover the issue you see. Would you mind testing it? > > Thanks > Stephan > > ---8<--- > > The code paths protected by the socket-lock do not use or modify the > socket in a non-atomic fashion. The actions pertaining the socket do not > even need to be handled as an atomic operation. Thus, the socket-lock > can be safely ignored. > > This fixes a bug regarding scheduling in atomic as the callback function > may be invoked in interrupt context. > > Fixes: 2d97591ef43d0 ("crypto: af_alg - consolidation of duplicate code") > Reported-by: Romain Izard <romain.izard.pro@gmail.com> > Signed-off-by: Stephan Mueller <smueller@chronox.de> Tested-by: Romain Izard <romain.izard.pro@gmail.com> The issue observed with atmel-aes is not reproduced anymore. > --- > crypto/af_alg.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/crypto/af_alg.c b/crypto/af_alg.c > index 337cf382718e..a41f08642eee 100644 > --- a/crypto/af_alg.c > +++ b/crypto/af_alg.c > @@ -1063,8 +1063,6 @@ void af_alg_async_cb(struct crypto_async_request *_req, int err) > struct kiocb *iocb = areq->iocb; > unsigned int resultlen; > > - lock_sock(sk); > - > /* Buffer size written by crypto operation. */ > resultlen = areq->outlen; > > @@ -1073,8 +1071,6 @@ void af_alg_async_cb(struct crypto_async_request *_req, int err) > __sock_put(sk); > > iocb->ki_complete(iocb, err ? err : resultlen, 0); > - > - release_sock(sk); > } > EXPORT_SYMBOL_GPL(af_alg_async_cb); > > -- > 2.13.6 > >
next prev parent reply other threads:[~2017-10-30 17:15 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-25 15:26 "BUG: scheduling while atomic" in atmel-aes on Linux v4.14-rc6 Romain Izard 2017-10-25 15:26 ` Romain Izard 2017-10-25 15:59 ` Stephan Mueller 2017-10-25 15:59 ` Stephan Mueller 2017-10-29 20:39 ` [PATCH] crypto: AF_ALG - remove locking in async callback Stephan Müller 2017-10-29 20:39 ` Stephan Müller 2017-10-30 17:15 ` Romain Izard [this message] 2017-10-30 17:15 ` Romain Izard 2017-11-03 13:20 ` Herbert Xu 2017-11-03 13:20 ` Herbert Xu 2017-11-03 13:34 ` Stephan Mueller 2017-11-03 13:34 ` Stephan Mueller 2017-11-06 16:06 ` Stephan Mueller 2017-11-06 16:06 ` Stephan Mueller 2017-11-07 5:22 ` Herbert Xu 2017-11-07 5:22 ` Herbert Xu 2017-11-07 6:19 ` Stephan Müller 2017-11-07 6:19 ` Stephan Müller 2017-11-07 6:32 ` Herbert Xu 2017-11-07 6:32 ` Herbert Xu 2017-11-07 9:05 ` [PATCH v2] " Stephan Müller 2017-11-07 9:05 ` Stephan Müller 2017-11-10 11:10 ` Herbert Xu 2017-11-10 11:10 ` Herbert Xu 2017-11-10 12:20 ` [PATCH v3] " Stephan Müller 2017-11-10 12:20 ` Stephan Müller 2017-11-10 16:50 ` Romain Izard 2017-11-10 16:50 ` Romain Izard 2017-11-24 7:37 ` Herbert Xu 2017-11-24 7:37 ` Herbert Xu 2017-11-24 16:04 ` Stephan Mueller 2017-11-24 16:04 ` Stephan Mueller 2017-11-24 17:37 ` Jonathan Cameron 2017-11-24 17:37 ` Jonathan Cameron 2017-11-25 0:17 ` Herbert Xu 2017-11-25 0:17 ` Herbert Xu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAGkQfmO+c6m-1v9ztV-G68JXSupD+pMv0czpoieg0a5PyLQ_dg@mail.gmail.com \ --to=romain.izard.pro@gmail.com \ --cc=cyrille.pitchen@microchip.com \ --cc=herbert@gondor.apana.org.au \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-crypto@vger.kernel.org \ --cc=nicolas.ferre@microchip.com \ --cc=smueller@chronox.de \ --cc=tudor.ambarus@microchip.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.