* [PATCH 1/2] drm/i915: Call i915_globals_exit() after i915_pmu_exit() @ 2021-07-16 22:47 ` Jason Ekstrand 0 siblings, 0 replies; 13+ messages in thread From: Jason Ekstrand @ 2021-07-16 22:47 UTC (permalink / raw) To: intel-gfx, dri-devel; +Cc: Jason Ekstrand We should tear down in the opposite order we set up. Signed-off-by: Jason Ekstrand <jason@jlekstrand.net> Fixes: 537f9c84a427 ("drm/i915/pmu: Fix CPU hotplug with multiple GPUs") Cc: Daniel Vetter <daniel@ffwll.ch> --- drivers/gpu/drm/i915/i915_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c index 67696d7522718..50ed93b03e582 100644 --- a/drivers/gpu/drm/i915/i915_pci.c +++ b/drivers/gpu/drm/i915/i915_pci.c @@ -1244,8 +1244,8 @@ static void __exit i915_exit(void) i915_perf_sysctl_unregister(); pci_unregister_driver(&i915_pci_driver); - i915_globals_exit(); i915_pmu_exit(); + i915_globals_exit(); } module_init(i915_init); -- 2.31.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Intel-gfx] [PATCH 1/2] drm/i915: Call i915_globals_exit() after i915_pmu_exit() @ 2021-07-16 22:47 ` Jason Ekstrand 0 siblings, 0 replies; 13+ messages in thread From: Jason Ekstrand @ 2021-07-16 22:47 UTC (permalink / raw) To: intel-gfx, dri-devel We should tear down in the opposite order we set up. Signed-off-by: Jason Ekstrand <jason@jlekstrand.net> Fixes: 537f9c84a427 ("drm/i915/pmu: Fix CPU hotplug with multiple GPUs") Cc: Daniel Vetter <daniel@ffwll.ch> --- drivers/gpu/drm/i915/i915_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c index 67696d7522718..50ed93b03e582 100644 --- a/drivers/gpu/drm/i915/i915_pci.c +++ b/drivers/gpu/drm/i915/i915_pci.c @@ -1244,8 +1244,8 @@ static void __exit i915_exit(void) i915_perf_sysctl_unregister(); pci_unregister_driver(&i915_pci_driver); - i915_globals_exit(); i915_pmu_exit(); + i915_globals_exit(); } module_init(i915_init); -- 2.31.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [PATCH 2/2] drm/i915: Tear down properly on early i915_init exit 2021-07-16 22:47 ` [Intel-gfx] " Jason Ekstrand @ 2021-07-16 22:47 ` Jason Ekstrand -1 siblings, 0 replies; 13+ messages in thread From: Jason Ekstrand @ 2021-07-16 22:47 UTC (permalink / raw) To: intel-gfx, dri-devel; +Cc: Jason Ekstrand In i915_exit(), we check i915_pci_driver.driver.owner to detect if i915_init exited early and don't tear anything down. However, we didn't have proper tear-down paths for early exits in i915_init(). Most of the time, you would never notice this as driver init failures are extremely rare and generally the sign of a bigger bug. However, when the mock self-tests are run, they run as part of i915_init() and exit early once they complete. They run after i915_globals_init() and before we set up anything else. The IGT test then unloads the module, invoking i915_exit() which, thanks to our i915_pci_driver.driver.owner check, doesn't actually tear anything down. Importantly, this means i915_globals_exit() never gets called even though i915_globals_init() was and we leak the globals. The most annoying part is that you don't actually notice the failure as part of the self-tests since leaking a bit of memory, while bad, doesn't result in anything observable from userspace. Instead, the next time we load the driver (usually for next IGT test), i915_globals_init() gets invoked again, we go to allocate a bunch of new memory slabs, those implicitly create debugfs entries, and debugfs warns that we're trying to create directories and files that already exist. Since this all happens as part of the next driver load, it shows up in the dmesg-warn of whatever IGT test ran after the mock selftests. Signed-off-by: Jason Ekstrand <jason@jlekstrand.net> Fixes: 32eb6bcfdda9 ("drm/i915: Make request allocation caches global") Cc: Daniel Vetter <daniel@ffwll.ch> --- drivers/gpu/drm/i915/i915_globals.c | 4 ++-- drivers/gpu/drm/i915/i915_pci.c | 23 +++++++++++++++++------ 2 files changed, 19 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_globals.c b/drivers/gpu/drm/i915/i915_globals.c index 77f1911c463b8..87267e1d2ad92 100644 --- a/drivers/gpu/drm/i915/i915_globals.c +++ b/drivers/gpu/drm/i915/i915_globals.c @@ -138,7 +138,7 @@ void i915_globals_unpark(void) atomic_inc(&active); } -static void __exit __i915_globals_flush(void) +static void __i915_globals_flush(void) { atomic_inc(&active); /* skip shrinking */ @@ -148,7 +148,7 @@ static void __exit __i915_globals_flush(void) atomic_dec(&active); } -void __exit i915_globals_exit(void) +void i915_globals_exit(void) { GEM_BUG_ON(atomic_read(&active)); diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c index 50ed93b03e582..783f547be0990 100644 --- a/drivers/gpu/drm/i915/i915_pci.c +++ b/drivers/gpu/drm/i915/i915_pci.c @@ -1199,13 +1199,20 @@ static int __init i915_init(void) bool use_kms = true; int err; + /* We use this to detect early returns from i915_init() so we don't + * tear anything down in i915_exit() + */ + i915_pci_driver.driver.owner = NULL; + err = i915_globals_init(); if (err) return err; err = i915_mock_selftests(); - if (err) - return err > 0 ? 0 : err; + if (err) { + err = err > 0 ? 0 : err; + goto globals_exit; + } /* * Enable KMS by default, unless explicitly overriden by @@ -1228,13 +1235,17 @@ static int __init i915_init(void) i915_pmu_init(); err = pci_register_driver(&i915_pci_driver); - if (err) { - i915_pmu_exit(); - return err; - } + if (err) + goto pmu_exit; i915_perf_sysctl_register(); return 0; + +pmu_exit: + i915_pmu_exit(); +globals_exit: + i915_globals_exit(); + return err; } static void __exit i915_exit(void) -- 2.31.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Intel-gfx] [PATCH 2/2] drm/i915: Tear down properly on early i915_init exit @ 2021-07-16 22:47 ` Jason Ekstrand 0 siblings, 0 replies; 13+ messages in thread From: Jason Ekstrand @ 2021-07-16 22:47 UTC (permalink / raw) To: intel-gfx, dri-devel In i915_exit(), we check i915_pci_driver.driver.owner to detect if i915_init exited early and don't tear anything down. However, we didn't have proper tear-down paths for early exits in i915_init(). Most of the time, you would never notice this as driver init failures are extremely rare and generally the sign of a bigger bug. However, when the mock self-tests are run, they run as part of i915_init() and exit early once they complete. They run after i915_globals_init() and before we set up anything else. The IGT test then unloads the module, invoking i915_exit() which, thanks to our i915_pci_driver.driver.owner check, doesn't actually tear anything down. Importantly, this means i915_globals_exit() never gets called even though i915_globals_init() was and we leak the globals. The most annoying part is that you don't actually notice the failure as part of the self-tests since leaking a bit of memory, while bad, doesn't result in anything observable from userspace. Instead, the next time we load the driver (usually for next IGT test), i915_globals_init() gets invoked again, we go to allocate a bunch of new memory slabs, those implicitly create debugfs entries, and debugfs warns that we're trying to create directories and files that already exist. Since this all happens as part of the next driver load, it shows up in the dmesg-warn of whatever IGT test ran after the mock selftests. Signed-off-by: Jason Ekstrand <jason@jlekstrand.net> Fixes: 32eb6bcfdda9 ("drm/i915: Make request allocation caches global") Cc: Daniel Vetter <daniel@ffwll.ch> --- drivers/gpu/drm/i915/i915_globals.c | 4 ++-- drivers/gpu/drm/i915/i915_pci.c | 23 +++++++++++++++++------ 2 files changed, 19 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_globals.c b/drivers/gpu/drm/i915/i915_globals.c index 77f1911c463b8..87267e1d2ad92 100644 --- a/drivers/gpu/drm/i915/i915_globals.c +++ b/drivers/gpu/drm/i915/i915_globals.c @@ -138,7 +138,7 @@ void i915_globals_unpark(void) atomic_inc(&active); } -static void __exit __i915_globals_flush(void) +static void __i915_globals_flush(void) { atomic_inc(&active); /* skip shrinking */ @@ -148,7 +148,7 @@ static void __exit __i915_globals_flush(void) atomic_dec(&active); } -void __exit i915_globals_exit(void) +void i915_globals_exit(void) { GEM_BUG_ON(atomic_read(&active)); diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c index 50ed93b03e582..783f547be0990 100644 --- a/drivers/gpu/drm/i915/i915_pci.c +++ b/drivers/gpu/drm/i915/i915_pci.c @@ -1199,13 +1199,20 @@ static int __init i915_init(void) bool use_kms = true; int err; + /* We use this to detect early returns from i915_init() so we don't + * tear anything down in i915_exit() + */ + i915_pci_driver.driver.owner = NULL; + err = i915_globals_init(); if (err) return err; err = i915_mock_selftests(); - if (err) - return err > 0 ? 0 : err; + if (err) { + err = err > 0 ? 0 : err; + goto globals_exit; + } /* * Enable KMS by default, unless explicitly overriden by @@ -1228,13 +1235,17 @@ static int __init i915_init(void) i915_pmu_init(); err = pci_register_driver(&i915_pci_driver); - if (err) { - i915_pmu_exit(); - return err; - } + if (err) + goto pmu_exit; i915_perf_sysctl_register(); return 0; + +pmu_exit: + i915_pmu_exit(); +globals_exit: + i915_globals_exit(); + return err; } static void __exit i915_exit(void) -- 2.31.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 2/2] drm/i915: Tear down properly on early i915_init exit 2021-07-16 22:47 ` [Intel-gfx] " Jason Ekstrand @ 2021-07-19 8:28 ` Daniel Vetter -1 siblings, 0 replies; 13+ messages in thread From: Daniel Vetter @ 2021-07-19 8:28 UTC (permalink / raw) To: Jason Ekstrand; +Cc: intel-gfx, dri-devel On Sat, Jul 17, 2021 at 12:48 AM Jason Ekstrand <jason@jlekstrand.net> wrote: > In i915_exit(), we check i915_pci_driver.driver.owner to detect if > i915_init exited early and don't tear anything down. However, we didn't > have proper tear-down paths for early exits in i915_init(). > > Most of the time, you would never notice this as driver init failures > are extremely rare and generally the sign of a bigger bug. However, > when the mock self-tests are run, they run as part of i915_init() and > exit early once they complete. They run after i915_globals_init() and > before we set up anything else. The IGT test then unloads the module, > invoking i915_exit() which, thanks to our i915_pci_driver.driver.owner > check, doesn't actually tear anything down. Importantly, this means > i915_globals_exit() never gets called even though i915_globals_init() > was and we leak the globals. > > The most annoying part is that you don't actually notice the failure as > part of the self-tests since leaking a bit of memory, while bad, doesn't > result in anything observable from userspace. Instead, the next time we > load the driver (usually for next IGT test), i915_globals_init() gets > invoked again, we go to allocate a bunch of new memory slabs, those > implicitly create debugfs entries, and debugfs warns that we're trying > to create directories and files that already exist. Since this all > happens as part of the next driver load, it shows up in the dmesg-warn > of whatever IGT test ran after the mock selftests. My idea was to onion-unwind in i915_exit, but that means we need to carry state over or have checks for every step, which is a bit annoying. Yours unwinds even if i915_init returns 0, i.e. success, if we had some selftests, which is most unusual and I think deserves an explainer here in the commit message and maybe somewhere in the code. > Signed-off-by: Jason Ekstrand <jason@jlekstrand.net> > Fixes: 32eb6bcfdda9 ("drm/i915: Make request allocation caches global") > Cc: Daniel Vetter <daniel@ffwll.ch> > --- > drivers/gpu/drm/i915/i915_globals.c | 4 ++-- > drivers/gpu/drm/i915/i915_pci.c | 23 +++++++++++++++++------ > 2 files changed, 19 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_globals.c b/drivers/gpu/drm/i915/i915_globals.c > index 77f1911c463b8..87267e1d2ad92 100644 > --- a/drivers/gpu/drm/i915/i915_globals.c > +++ b/drivers/gpu/drm/i915/i915_globals.c > @@ -138,7 +138,7 @@ void i915_globals_unpark(void) > atomic_inc(&active); > } > > -static void __exit __i915_globals_flush(void) > +static void __i915_globals_flush(void) > { > atomic_inc(&active); /* skip shrinking */ > > @@ -148,7 +148,7 @@ static void __exit __i915_globals_flush(void) > atomic_dec(&active); > } > > -void __exit i915_globals_exit(void) > +void i915_globals_exit(void) > { > GEM_BUG_ON(atomic_read(&active)); > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c > index 50ed93b03e582..783f547be0990 100644 > --- a/drivers/gpu/drm/i915/i915_pci.c > +++ b/drivers/gpu/drm/i915/i915_pci.c > @@ -1199,13 +1199,20 @@ static int __init i915_init(void) > bool use_kms = true; > int err; > > + /* We use this to detect early returns from i915_init() so we don't > + * tear anything down in i915_exit() > + */ > + i915_pci_driver.driver.owner = NULL; Setting this seems redundant? Or if you want to make it explicit, just have a dedicated bool with a big comment explaining that only when we load the full pci driver do we tear down stuff in i915_exit. You could then set after pci_register_driver was successful. Some screaming name like driver_fully_loaded or something like that ... > + > err = i915_globals_init(); > if (err) > return err; > > err = i915_mock_selftests(); > - if (err) > - return err > 0 ? 0 : err; > + if (err) { > + err = err > 0 ? 0 : err; > + goto globals_exit; > + } > > /* > * Enable KMS by default, unless explicitly overriden by Imo move this up, but if you want I can send out my diff so you score an r-b: tag :-) > @@ -1228,13 +1235,17 @@ static int __init i915_init(void) > i915_pmu_init(); > > err = pci_register_driver(&i915_pci_driver); > - if (err) { > - i915_pmu_exit(); > - return err; > - } > + if (err) > + goto pmu_exit; > > i915_perf_sysctl_register(); > return 0; > + We unwind even on success, which is most unusual. I think that deserves a comment. > +pmu_exit: > + i915_pmu_exit(); > +globals_exit: > + i915_globals_exit(); > + return err; > } > > static void __exit i915_exit(void) > -- > 2.31.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH 2/2] drm/i915: Tear down properly on early i915_init exit @ 2021-07-19 8:28 ` Daniel Vetter 0 siblings, 0 replies; 13+ messages in thread From: Daniel Vetter @ 2021-07-19 8:28 UTC (permalink / raw) To: Jason Ekstrand; +Cc: intel-gfx, dri-devel On Sat, Jul 17, 2021 at 12:48 AM Jason Ekstrand <jason@jlekstrand.net> wrote: > In i915_exit(), we check i915_pci_driver.driver.owner to detect if > i915_init exited early and don't tear anything down. However, we didn't > have proper tear-down paths for early exits in i915_init(). > > Most of the time, you would never notice this as driver init failures > are extremely rare and generally the sign of a bigger bug. However, > when the mock self-tests are run, they run as part of i915_init() and > exit early once they complete. They run after i915_globals_init() and > before we set up anything else. The IGT test then unloads the module, > invoking i915_exit() which, thanks to our i915_pci_driver.driver.owner > check, doesn't actually tear anything down. Importantly, this means > i915_globals_exit() never gets called even though i915_globals_init() > was and we leak the globals. > > The most annoying part is that you don't actually notice the failure as > part of the self-tests since leaking a bit of memory, while bad, doesn't > result in anything observable from userspace. Instead, the next time we > load the driver (usually for next IGT test), i915_globals_init() gets > invoked again, we go to allocate a bunch of new memory slabs, those > implicitly create debugfs entries, and debugfs warns that we're trying > to create directories and files that already exist. Since this all > happens as part of the next driver load, it shows up in the dmesg-warn > of whatever IGT test ran after the mock selftests. My idea was to onion-unwind in i915_exit, but that means we need to carry state over or have checks for every step, which is a bit annoying. Yours unwinds even if i915_init returns 0, i.e. success, if we had some selftests, which is most unusual and I think deserves an explainer here in the commit message and maybe somewhere in the code. > Signed-off-by: Jason Ekstrand <jason@jlekstrand.net> > Fixes: 32eb6bcfdda9 ("drm/i915: Make request allocation caches global") > Cc: Daniel Vetter <daniel@ffwll.ch> > --- > drivers/gpu/drm/i915/i915_globals.c | 4 ++-- > drivers/gpu/drm/i915/i915_pci.c | 23 +++++++++++++++++------ > 2 files changed, 19 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_globals.c b/drivers/gpu/drm/i915/i915_globals.c > index 77f1911c463b8..87267e1d2ad92 100644 > --- a/drivers/gpu/drm/i915/i915_globals.c > +++ b/drivers/gpu/drm/i915/i915_globals.c > @@ -138,7 +138,7 @@ void i915_globals_unpark(void) > atomic_inc(&active); > } > > -static void __exit __i915_globals_flush(void) > +static void __i915_globals_flush(void) > { > atomic_inc(&active); /* skip shrinking */ > > @@ -148,7 +148,7 @@ static void __exit __i915_globals_flush(void) > atomic_dec(&active); > } > > -void __exit i915_globals_exit(void) > +void i915_globals_exit(void) > { > GEM_BUG_ON(atomic_read(&active)); > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c > index 50ed93b03e582..783f547be0990 100644 > --- a/drivers/gpu/drm/i915/i915_pci.c > +++ b/drivers/gpu/drm/i915/i915_pci.c > @@ -1199,13 +1199,20 @@ static int __init i915_init(void) > bool use_kms = true; > int err; > > + /* We use this to detect early returns from i915_init() so we don't > + * tear anything down in i915_exit() > + */ > + i915_pci_driver.driver.owner = NULL; Setting this seems redundant? Or if you want to make it explicit, just have a dedicated bool with a big comment explaining that only when we load the full pci driver do we tear down stuff in i915_exit. You could then set after pci_register_driver was successful. Some screaming name like driver_fully_loaded or something like that ... > + > err = i915_globals_init(); > if (err) > return err; > > err = i915_mock_selftests(); > - if (err) > - return err > 0 ? 0 : err; > + if (err) { > + err = err > 0 ? 0 : err; > + goto globals_exit; > + } > > /* > * Enable KMS by default, unless explicitly overriden by Imo move this up, but if you want I can send out my diff so you score an r-b: tag :-) > @@ -1228,13 +1235,17 @@ static int __init i915_init(void) > i915_pmu_init(); > > err = pci_register_driver(&i915_pci_driver); > - if (err) { > - i915_pmu_exit(); > - return err; > - } > + if (err) > + goto pmu_exit; > > i915_perf_sysctl_register(); > return 0; > + We unwind even on success, which is most unusual. I think that deserves a comment. > +pmu_exit: > + i915_pmu_exit(); > +globals_exit: > + i915_globals_exit(); > + return err; > } > > static void __exit i915_exit(void) > -- > 2.31.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] drm/i915: Call i915_globals_exit() after i915_pmu_exit() 2021-07-16 22:47 ` [Intel-gfx] " Jason Ekstrand (?) (?) @ 2021-07-17 1:21 ` Patchwork -1 siblings, 0 replies; 13+ messages in thread From: Patchwork @ 2021-07-17 1:21 UTC (permalink / raw) To: Jason Ekstrand; +Cc: intel-gfx == Series Details == Series: series starting with [1/2] drm/i915: Call i915_globals_exit() after i915_pmu_exit() URL : https://patchwork.freedesktop.org/series/92663/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Excess function parameter 'jump_whitelist' description in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Excess function parameter 'shadow_map' description in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Excess function parameter 'batch_map' description in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Function parameter or member 'trampoline' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Excess function parameter 'jump_whitelist' description in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Excess function parameter 'shadow_map' description in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Excess function parameter 'batch_map' description in 'intel_engine_cmd_parser' _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Call i915_globals_exit() after i915_pmu_exit() 2021-07-16 22:47 ` [Intel-gfx] " Jason Ekstrand ` (2 preceding siblings ...) (?) @ 2021-07-17 1:47 ` Patchwork -1 siblings, 0 replies; 13+ messages in thread From: Patchwork @ 2021-07-17 1:47 UTC (permalink / raw) To: Jason Ekstrand; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 3086 bytes --] == Series Details == Series: series starting with [1/2] drm/i915: Call i915_globals_exit() after i915_pmu_exit() URL : https://patchwork.freedesktop.org/series/92663/ State : success == Summary == CI Bug Log - changes from CI_DRM_10346 -> Patchwork_20638 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/index.html Known issues ------------ Here are the changes found in Patchwork_20638 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_basic@semaphore: - fi-bdw-5557u: NOTRUN -> [SKIP][1] ([fdo#109271]) +27 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/fi-bdw-5557u/igt@amdgpu/amd_basic@semaphore.html * igt@core_hotunplug@unbind-rebind: - fi-bdw-5557u: NOTRUN -> [WARN][2] ([i915#3718]) [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/fi-bdw-5557u/igt@core_hotunplug@unbind-rebind.html * igt@i915_selftest@live@execlists: - fi-bsw-kefka: [PASS][3] -> [INCOMPLETE][4] ([i915#2782] / [i915#2940]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/fi-bsw-kefka/igt@i915_selftest@live@execlists.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/fi-bsw-kefka/igt@i915_selftest@live@execlists.html * igt@kms_chamelium@dp-crc-fast: - fi-bdw-5557u: NOTRUN -> [SKIP][5] ([fdo#109271] / [fdo#111827]) +8 similar issues [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/fi-bdw-5557u/igt@kms_chamelium@dp-crc-fast.html * igt@runner@aborted: - fi-bsw-kefka: NOTRUN -> [FAIL][6] ([fdo#109271] / [i915#1436]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/fi-bsw-kefka/igt@runner@aborted.html [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436 [i915#2782]: https://gitlab.freedesktop.org/drm/intel/issues/2782 [i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940 [i915#3718]: https://gitlab.freedesktop.org/drm/intel/issues/3718 Participating hosts (41 -> 35) ------------------------------ Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-bdw-samus fi-tgl-y bat-jsl-1 Build changes ------------- * Linux: CI_DRM_10346 -> Patchwork_20638 CI-20190529: 20190529 CI_DRM_10346: 6c4e3c031a995e641cc0d9563d21043415fb8d12 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6144: bc65ee9ee6593716306448c9fb82c77f284f2148 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_20638: 0e3e8320b40fddd76b132f65f77649436b7d2b85 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 0e3e8320b40f drm/i915: Tear down properly on early i915_init exit 80f1d7745ee1 drm/i915: Call i915_globals_exit() after i915_pmu_exit() == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/index.html [-- Attachment #1.2: Type: text/html, Size: 3928 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Call i915_globals_exit() after i915_pmu_exit() 2021-07-16 22:47 ` [Intel-gfx] " Jason Ekstrand ` (3 preceding siblings ...) (?) @ 2021-07-17 11:53 ` Patchwork -1 siblings, 0 replies; 13+ messages in thread From: Patchwork @ 2021-07-17 11:53 UTC (permalink / raw) To: Jason Ekstrand; +Cc: intel-gfx [-- Attachment #1.1: Type: text/plain, Size: 30306 bytes --] == Series Details == Series: series starting with [1/2] drm/i915: Call i915_globals_exit() after i915_pmu_exit() URL : https://patchwork.freedesktop.org/series/92663/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10346_full -> Patchwork_20638_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_20638_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_20638_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_20638_full: ### IGT changes ### #### Possible regressions #### * igt@gen9_exec_parse@bb-start-far: - shard-iclb: NOTRUN -> [SKIP][1] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-iclb7/igt@gen9_exec_parse@bb-start-far.html #### Warnings #### * igt@i915_selftest@mock@dmabuf: - shard-iclb: [DMESG-WARN][2] ([i915#3746]) -> [DMESG-FAIL][3] [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-iclb4/igt@i915_selftest@mock@dmabuf.html [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-iclb4/igt@i915_selftest@mock@dmabuf.html - shard-apl: [DMESG-WARN][4] ([i915#3746]) -> [DMESG-FAIL][5] [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-apl2/igt@i915_selftest@mock@dmabuf.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-apl6/igt@i915_selftest@mock@dmabuf.html - shard-kbl: [DMESG-WARN][6] ([i915#3746]) -> [DMESG-FAIL][7] [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-kbl4/igt@i915_selftest@mock@dmabuf.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-kbl4/igt@i915_selftest@mock@dmabuf.html - shard-snb: [DMESG-WARN][8] ([i915#3746]) -> [DMESG-FAIL][9] [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-snb2/igt@i915_selftest@mock@dmabuf.html [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-snb6/igt@i915_selftest@mock@dmabuf.html - shard-tglb: [DMESG-WARN][10] ([i915#3746]) -> [DMESG-FAIL][11] [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-tglb3/igt@i915_selftest@mock@dmabuf.html [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-tglb1/igt@i915_selftest@mock@dmabuf.html - shard-skl: [DMESG-WARN][12] ([i915#3746]) -> [DMESG-FAIL][13] [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-skl6/igt@i915_selftest@mock@dmabuf.html [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-skl4/igt@i915_selftest@mock@dmabuf.html - shard-glk: [DMESG-WARN][14] ([i915#3746]) -> [DMESG-FAIL][15] [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-glk4/igt@i915_selftest@mock@dmabuf.html [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-glk2/igt@i915_selftest@mock@dmabuf.html Known issues ------------ Here are the changes found in Patchwork_20638_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@drm_import_export@prime: - shard-tglb: [PASS][16] -> [INCOMPLETE][17] ([i915#750]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-tglb7/igt@drm_import_export@prime.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-tglb2/igt@drm_import_export@prime.html * igt@gem_ctx_persistence@engines-hostile-preempt: - shard-snb: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#1099]) +1 similar issue [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-snb6/igt@gem_ctx_persistence@engines-hostile-preempt.html * igt@gem_exec_fair@basic-none@vcs0: - shard-tglb: NOTRUN -> [FAIL][19] ([i915#2842]) +4 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-tglb6/igt@gem_exec_fair@basic-none@vcs0.html * igt@gem_exec_fair@basic-pace-solo@rcs0: - shard-tglb: [PASS][20] -> [FAIL][21] ([i915#2842]) +2 similar issues [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-tglb5/igt@gem_exec_fair@basic-pace-solo@rcs0.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-tglb1/igt@gem_exec_fair@basic-pace-solo@rcs0.html * igt@gem_exec_fair@basic-pace@vcs0: - shard-kbl: [PASS][22] -> [FAIL][23] ([i915#2842]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs0.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-kbl7/igt@gem_exec_fair@basic-pace@vcs0.html * igt@gem_pwrite@basic-exhaustion: - shard-snb: NOTRUN -> [WARN][24] ([i915#2658]) +1 similar issue [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-snb7/igt@gem_pwrite@basic-exhaustion.html - shard-kbl: NOTRUN -> [WARN][25] ([i915#2658]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-kbl3/igt@gem_pwrite@basic-exhaustion.html * igt@gem_render_copy@y-tiled-mc-ccs-to-yf-tiled-ccs: - shard-iclb: NOTRUN -> [SKIP][26] ([i915#768]) [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-iclb7/igt@gem_render_copy@y-tiled-mc-ccs-to-yf-tiled-ccs.html * igt@gen7_exec_parse@chained-batch: - shard-iclb: NOTRUN -> [SKIP][27] ([fdo#109289]) +1 similar issue [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-iclb7/igt@gen7_exec_parse@chained-batch.html * igt@gen9_exec_parse@batch-invalid-length: - shard-snb: NOTRUN -> [SKIP][28] ([fdo#109271]) +292 similar issues [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-snb2/igt@gen9_exec_parse@batch-invalid-length.html * igt@i915_pm_lpsp@kms-lpsp: - shard-skl: NOTRUN -> [SKIP][29] ([fdo#109271]) +110 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-skl3/igt@i915_pm_lpsp@kms-lpsp.html * igt@i915_pm_rpm@modeset-non-lpsp-stress: - shard-iclb: NOTRUN -> [SKIP][30] ([fdo#110892]) [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-iclb7/igt@i915_pm_rpm@modeset-non-lpsp-stress.html * igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip: - shard-skl: NOTRUN -> [FAIL][31] ([i915#3722]) [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-skl4/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html * igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip: - shard-apl: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#3777]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-apl3/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip.html * igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip: - shard-skl: NOTRUN -> [SKIP][33] ([fdo#109271] / [i915#3777]) [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-skl3/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip.html * igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip: - shard-kbl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#3777]) [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-kbl3/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip.html * igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0: - shard-iclb: NOTRUN -> [SKIP][35] ([fdo#110723]) +1 similar issue [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-iclb7/igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0.html * igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc: - shard-skl: NOTRUN -> [FAIL][36] ([i915#3678]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-skl3/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-b-crc-primary-basic-yf_tiled_ccs: - shard-tglb: NOTRUN -> [SKIP][37] ([i915#3689]) +5 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-tglb6/igt@kms_ccs@pipe-b-crc-primary-basic-yf_tiled_ccs.html * igt@kms_chamelium@dp-crc-multiple: - shard-apl: NOTRUN -> [SKIP][38] ([fdo#109271] / [fdo#111827]) +12 similar issues [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-apl1/igt@kms_chamelium@dp-crc-multiple.html * igt@kms_chamelium@dp-hpd-storm-disable: - shard-tglb: NOTRUN -> [SKIP][39] ([fdo#109284] / [fdo#111827]) +1 similar issue [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-tglb6/igt@kms_chamelium@dp-hpd-storm-disable.html * igt@kms_chamelium@hdmi-aspect-ratio: - shard-kbl: NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827]) +1 similar issue [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-kbl3/igt@kms_chamelium@hdmi-aspect-ratio.html * igt@kms_chamelium@vga-edid-read: - shard-iclb: NOTRUN -> [SKIP][41] ([fdo#109284] / [fdo#111827]) +1 similar issue [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-iclb7/igt@kms_chamelium@vga-edid-read.html * igt@kms_color@pipe-d-ctm-negative: - shard-iclb: NOTRUN -> [SKIP][42] ([fdo#109278] / [i915#1149]) +1 similar issue [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-iclb7/igt@kms_color@pipe-d-ctm-negative.html * igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes: - shard-skl: NOTRUN -> [SKIP][43] ([fdo#109271] / [fdo#111827]) +10 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-skl3/igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes.html - shard-snb: NOTRUN -> [SKIP][44] ([fdo#109271] / [fdo#111827]) +18 similar issues [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-snb2/igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes.html * igt@kms_cursor_crc@pipe-a-cursor-32x32-sliding: - shard-tglb: NOTRUN -> [SKIP][45] ([i915#3319]) +2 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-tglb6/igt@kms_cursor_crc@pipe-a-cursor-32x32-sliding.html * igt@kms_cursor_crc@pipe-c-cursor-32x32-rapid-movement: - shard-glk: NOTRUN -> [SKIP][46] ([fdo#109271]) +1 similar issue [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-glk4/igt@kms_cursor_crc@pipe-c-cursor-32x32-rapid-movement.html * igt@kms_cursor_crc@pipe-d-cursor-512x170-offscreen: - shard-tglb: NOTRUN -> [SKIP][47] ([fdo#109279] / [i915#3359]) +1 similar issue [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-tglb1/igt@kms_cursor_crc@pipe-d-cursor-512x170-offscreen.html * igt@kms_cursor_crc@pipe-d-cursor-dpms: - shard-iclb: NOTRUN -> [SKIP][48] ([fdo#109278]) +11 similar issues [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-iclb7/igt@kms_cursor_crc@pipe-d-cursor-dpms.html * igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions: - shard-iclb: NOTRUN -> [SKIP][49] ([fdo#109274] / [fdo#109278]) [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-iclb7/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions.html * igt@kms_dp_tiled_display@basic-test-pattern: - shard-tglb: NOTRUN -> [SKIP][50] ([i915#426]) [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-tglb6/igt@kms_dp_tiled_display@basic-test-pattern.html * igt@kms_fbcon_fbt@fbc-suspend: - shard-apl: [PASS][51] -> [INCOMPLETE][52] ([i915#180]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-apl6/igt@kms_fbcon_fbt@fbc-suspend.html * igt@kms_flip@2x-flip-vs-modeset-vs-hang: - shard-iclb: NOTRUN -> [SKIP][53] ([fdo#109274]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-iclb3/igt@kms_flip@2x-flip-vs-modeset-vs-hang.html * igt@kms_flip@flip-vs-absolute-wf_vblank@a-edp1: - shard-skl: [PASS][54] -> [FAIL][55] ([i915#2122]) [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-skl9/igt@kms_flip@flip-vs-absolute-wf_vblank@a-edp1.html [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-skl3/igt@kms_flip@flip-vs-absolute-wf_vblank@a-edp1.html * igt@kms_flip@flip-vs-suspend@a-dp1: - shard-apl: [PASS][56] -> [DMESG-WARN][57] ([i915#180]) [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-apl3/igt@kms_flip@flip-vs-suspend@a-dp1.html [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-apl6/igt@kms_flip@flip-vs-suspend@a-dp1.html * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-blt: - shard-kbl: NOTRUN -> [SKIP][58] ([fdo#109271]) +27 similar issues [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-blt.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-onoff: - shard-iclb: NOTRUN -> [SKIP][59] ([fdo#109280]) +3 similar issues [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-onoff.html * igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-blt: - shard-tglb: NOTRUN -> [SKIP][60] ([fdo#111825]) +4 similar issues [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-blt.html * igt@kms_frontbuffer_tracking@psr-suspend: - shard-skl: [PASS][61] -> [INCOMPLETE][62] ([i915#123]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-skl9/igt@kms_frontbuffer_tracking@psr-suspend.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-skl3/igt@kms_frontbuffer_tracking@psr-suspend.html * igt@kms_hdr@bpc-switch-suspend: - shard-skl: NOTRUN -> [FAIL][63] ([i915#1188]) [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-skl4/igt@kms_hdr@bpc-switch-suspend.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c: - shard-apl: NOTRUN -> [DMESG-WARN][64] ([i915#180]) +1 similar issue [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-apl8/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d: - shard-skl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#533]) +1 similar issue [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-skl7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html - shard-apl: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#533]) +1 similar issue [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-apl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html * igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb: - shard-apl: NOTRUN -> [FAIL][67] ([fdo#108145] / [i915#265]) +3 similar issues [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-apl8/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html * igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb: - shard-skl: NOTRUN -> [FAIL][68] ([fdo#108145] / [i915#265]) +2 similar issues [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb.html * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min: - shard-skl: [PASS][69] -> [FAIL][70] ([fdo#108145] / [i915#265]) [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html * igt@kms_plane_lowres@pipe-c-tiling-none: - shard-tglb: NOTRUN -> [SKIP][71] ([i915#3536]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-tglb6/igt@kms_plane_lowres@pipe-c-tiling-none.html * igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping: - shard-apl: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#2733]) [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-apl8/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html * igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1: - shard-apl: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#658]) +3 similar issues [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-apl8/igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1.html * igt@kms_psr2_sf@plane-move-sf-dmg-area-0: - shard-skl: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#658]) +1 similar issue [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-skl4/igt@kms_psr2_sf@plane-move-sf-dmg-area-0.html * igt@kms_psr2_sf@plane-move-sf-dmg-area-2: - shard-kbl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#658]) [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-kbl3/igt@kms_psr2_sf@plane-move-sf-dmg-area-2.html * igt@kms_psr2_su@page_flip: - shard-iclb: [PASS][76] -> [SKIP][77] ([fdo#109642] / [fdo#111068] / [i915#658]) [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-iclb2/igt@kms_psr2_su@page_flip.html [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-iclb3/igt@kms_psr2_su@page_flip.html * igt@kms_psr@psr2_cursor_mmap_gtt: - shard-iclb: NOTRUN -> [SKIP][78] ([fdo#109441]) [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-iclb7/igt@kms_psr@psr2_cursor_mmap_gtt.html * igt@kms_psr@psr2_primary_page_flip: - shard-iclb: [PASS][79] -> [SKIP][80] ([fdo#109441]) +2 similar issues [79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-iclb3/igt@kms_psr@psr2_primary_page_flip.html - shard-tglb: NOTRUN -> [FAIL][81] ([i915#132] / [i915#3467]) [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-tglb6/igt@kms_psr@psr2_primary_page_flip.html * igt@kms_vrr@flip-basic: - shard-iclb: NOTRUN -> [SKIP][82] ([fdo#109502]) [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-iclb7/igt@kms_vrr@flip-basic.html * igt@kms_writeback@writeback-invalid-parameters: - shard-tglb: NOTRUN -> [SKIP][83] ([i915#2437]) [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-tglb6/igt@kms_writeback@writeback-invalid-parameters.html * igt@kms_writeback@writeback-pixel-formats: - shard-apl: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#2437]) [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-apl8/igt@kms_writeback@writeback-pixel-formats.html * igt@nouveau_crc@pipe-b-source-rg: - shard-iclb: NOTRUN -> [SKIP][85] ([i915#2530]) [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-iclb7/igt@nouveau_crc@pipe-b-source-rg.html * igt@nouveau_crc@pipe-d-source-outp-inactive: - shard-tglb: NOTRUN -> [SKIP][86] ([i915#2530]) [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-tglb6/igt@nouveau_crc@pipe-d-source-outp-inactive.html * igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name: - shard-apl: NOTRUN -> [SKIP][87] ([fdo#109271]) +172 similar issues [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-apl1/igt@prime_nv_api@i915_nv_reimport_twice_check_flink_name.html * igt@prime_nv_test@i915_import_gtt_mmap: - shard-tglb: NOTRUN -> [SKIP][88] ([fdo#109291]) +1 similar issue [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-tglb1/igt@prime_nv_test@i915_import_gtt_mmap.html * igt@sysfs_clients@pidname: - shard-skl: NOTRUN -> [SKIP][89] ([fdo#109271] / [i915#2994]) [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-skl3/igt@sysfs_clients@pidname.html * igt@sysfs_clients@recycle-many: - shard-apl: NOTRUN -> [SKIP][90] ([fdo#109271] / [i915#2994]) +2 similar issues [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-apl1/igt@sysfs_clients@recycle-many.html #### Possible fixes #### * igt@gem_exec_fair@basic-deadline: - shard-glk: [FAIL][91] ([i915#2846]) -> [PASS][92] [91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-glk5/igt@gem_exec_fair@basic-deadline.html [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-glk8/igt@gem_exec_fair@basic-deadline.html * igt@gem_exec_fair@basic-none@rcs0: - shard-kbl: [FAIL][93] ([i915#2842]) -> [PASS][94] +3 similar issues [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-kbl1/igt@gem_exec_fair@basic-none@rcs0.html [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-kbl1/igt@gem_exec_fair@basic-none@rcs0.html * igt@gem_exec_fair@basic-throttle@rcs0: - shard-glk: [FAIL][95] ([i915#2842]) -> [PASS][96] [95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-glk9/igt@gem_exec_fair@basic-throttle@rcs0.html [96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-glk5/igt@gem_exec_fair@basic-throttle@rcs0.html - shard-iclb: [FAIL][97] ([i915#2849]) -> [PASS][98] [97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-iclb5/igt@gem_exec_fair@basic-throttle@rcs0.html [98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-iclb2/igt@gem_exec_fair@basic-throttle@rcs0.html * igt@gem_mmap_gtt@cpuset-big-copy: - shard-iclb: [FAIL][99] ([i915#307]) -> [PASS][100] [99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-iclb4/igt@gem_mmap_gtt@cpuset-big-copy.html [100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-iclb7/igt@gem_mmap_gtt@cpuset-big-copy.html * igt@i915_selftest@mock@engine: - shard-iclb: [DMESG-WARN][101] ([i915#3746]) -> [PASS][102] +10 similar issues [101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-iclb4/igt@i915_selftest@mock@engine.html [102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-iclb4/igt@i915_selftest@mock@engine.html * igt@i915_selftest@mock@fence: - shard-snb: [DMESG-WARN][103] ([i915#3746]) -> [PASS][104] +10 similar issues [103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-snb2/igt@i915_selftest@mock@fence.html [104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-snb6/igt@i915_selftest@mock@fence.html * igt@i915_selftest@mock@objects: - shard-skl: [DMESG-WARN][105] ([i915#3746]) -> [PASS][106] +10 similar issues [105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-skl6/igt@i915_selftest@mock@objects.html [106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-skl4/igt@i915_selftest@mock@objects.html - shard-tglb: [DMESG-WARN][107] ([i915#3746]) -> [PASS][108] +10 similar issues [107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-tglb3/igt@i915_selftest@mock@objects.html [108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-tglb1/igt@i915_selftest@mock@objects.html * igt@i915_selftest@mock@requests: - shard-kbl: [DMESG-WARN][109] ([i915#3746]) -> [PASS][110] +10 similar issues [109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-kbl4/igt@i915_selftest@mock@requests.html [110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-kbl4/igt@i915_selftest@mock@requests.html * igt@i915_selftest@mock@scatterlist: - shard-apl: [DMESG-WARN][111] ([i915#3746]) -> [PASS][112] +10 similar issues [111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-apl2/igt@i915_selftest@mock@scatterlist.html [112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-apl6/igt@i915_selftest@mock@scatterlist.html * igt@i915_selftest@mock@uncore: - shard-glk: [DMESG-WARN][113] ([i915#3746]) -> [PASS][114] +10 similar issues [113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-glk4/igt@i915_selftest@mock@uncore.html [114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-glk2/igt@i915_selftest@mock@uncore.html * igt@kms_cursor_crc@pipe-b-cursor-suspend: - shard-kbl: [DMESG-WARN][115] ([i915#180]) -> [PASS][116] [115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-suspend.html [116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-kbl3/igt@kms_cursor_crc@pipe-b-cursor-suspend.html * igt@kms_cursor_crc@pipe-c-cursor-suspend: - shard-skl: [INCOMPLETE][117] ([i915#300]) -> [PASS][118] [117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-skl2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html [118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-skl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions: - shard-skl: [FAIL][119] ([i915#2346]) -> [PASS][120] [119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-skl10/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html [120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-skl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html * igt@kms_flip@flip-vs-panning-interruptible@d-edp1: - shard-tglb: [INCOMPLETE][121] -> [PASS][122] [121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-tglb6/igt@kms_flip@flip-vs-panning-interruptible@d-edp1.html [122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-tglb6/igt@kms_flip@flip-vs-panning-interruptible@d-edp1.html * igt@kms_flip@flip-vs-suspend-interruptible@c-edp1: - shard-skl: [INCOMPLETE][123] ([i915#198] / [i915#2910]) -> [PASS][124] [123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-skl10/igt@kms_flip@flip-vs-suspend-interruptible@c-edp1.html [124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-skl3/igt@kms_flip@flip-vs-suspend-interruptible@c-edp1.html * igt@kms_flip@flip-vs-suspend@c-dp1: - shard-apl: [DMESG-WARN][125] ([i915#180]) -> [PASS][126] [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-apl3/igt@kms_flip@flip-vs-suspend@c-dp1.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-apl6/igt@kms_flip@flip-vs-suspend@c-dp1.html * igt@kms_hdr@bpc-switch-dpms: - shard-skl: [FAIL][127] ([i915#1188]) -> [PASS][128] [127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-skl5/igt@kms_hdr@bpc-switch-dpms.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-skl5/igt@kms_hdr@bpc-switch-dpms.html * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a: - shard-iclb: [INCOMPLETE][129] ([i915#1185]) -> [PASS][130] [129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-iclb3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html [130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-iclb7/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html * igt@kms_plane_alpha_blend@pipe-b-coverage-vs-premult-vs-constant: - shard-iclb: [SKIP][131] ([fdo#109278]) -> [PASS][132] [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-iclb2/igt@kms_plane_alpha_blend@pipe-b-coverage-vs-premult-vs-constant.html [132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-iclb3/igt@kms_plane_alpha_blend@pipe-b-coverage-vs-premult-vs-constant.html * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc: - shard-skl: [FAIL][133] ([fdo#108145] / [i915#265]) -> [PASS][134] [133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html [134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html * igt@kms_psr@psr2_sprite_mmap_gtt: - shard-iclb: [SKIP][135] ([fdo#109441]) -> [PASS][136] +2 similar issues [135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-iclb6/igt@kms_psr@psr2_sprite_mmap_gtt.html [136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html * igt@perf@polling-small-buf: - shard-skl: [FAIL][137] ([i915#1722]) -> [PASS][138] [137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-skl2/igt@perf@polling-small-buf.html [138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-skl9/igt@perf@polling-small-buf.html #### Warnings #### * igt@i915_pm_dc@dc3co-vpb-simulation: - shard-iclb: [SKIP][139] ([i915#658]) -> [SKIP][140] ([i915#588]) [139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-iclb5/igt@i915_pm_dc@dc3co-vpb-simulation.html [140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-iclb2/igt@i915_pm_dc@dc3co-vpb-simulation.html * igt@i915_pm_rc6_residency@rc6-fence: - shard-iclb: [WARN][141] ([i915#1804] / [i915#2684]) -> [WARN][142] ([i915#2684]) [141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-iclb7/igt@i915_pm_rc6_residency@rc6-fence.html [142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/shard-iclb1/ == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20638/index.html [-- Attachment #1.2: Type: text/html, Size: 33517 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] drm/i915: Call i915_globals_exit() after i915_pmu_exit() 2021-07-16 22:47 ` [Intel-gfx] " Jason Ekstrand @ 2021-07-19 8:29 ` Daniel Vetter -1 siblings, 0 replies; 13+ messages in thread From: Daniel Vetter @ 2021-07-19 8:29 UTC (permalink / raw) To: Jason Ekstrand; +Cc: intel-gfx, dri-devel On Sat, Jul 17, 2021 at 12:48 AM Jason Ekstrand <jason@jlekstrand.net> wrote: > > We should tear down in the opposite order we set up. > > Signed-off-by: Jason Ekstrand <jason@jlekstrand.net> > Fixes: 537f9c84a427 ("drm/i915/pmu: Fix CPU hotplug with multiple GPUs") > Cc: Daniel Vetter <daniel@ffwll.ch> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > drivers/gpu/drm/i915/i915_pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c > index 67696d7522718..50ed93b03e582 100644 > --- a/drivers/gpu/drm/i915/i915_pci.c > +++ b/drivers/gpu/drm/i915/i915_pci.c > @@ -1244,8 +1244,8 @@ static void __exit i915_exit(void) > > i915_perf_sysctl_unregister(); > pci_unregister_driver(&i915_pci_driver); > - i915_globals_exit(); > i915_pmu_exit(); > + i915_globals_exit(); > } > > module_init(i915_init); > -- > 2.31.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: Call i915_globals_exit() after i915_pmu_exit() @ 2021-07-19 8:29 ` Daniel Vetter 0 siblings, 0 replies; 13+ messages in thread From: Daniel Vetter @ 2021-07-19 8:29 UTC (permalink / raw) To: Jason Ekstrand; +Cc: intel-gfx, dri-devel On Sat, Jul 17, 2021 at 12:48 AM Jason Ekstrand <jason@jlekstrand.net> wrote: > > We should tear down in the opposite order we set up. > > Signed-off-by: Jason Ekstrand <jason@jlekstrand.net> > Fixes: 537f9c84a427 ("drm/i915/pmu: Fix CPU hotplug with multiple GPUs") > Cc: Daniel Vetter <daniel@ffwll.ch> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> > --- > drivers/gpu/drm/i915/i915_pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c > index 67696d7522718..50ed93b03e582 100644 > --- a/drivers/gpu/drm/i915/i915_pci.c > +++ b/drivers/gpu/drm/i915/i915_pci.c > @@ -1244,8 +1244,8 @@ static void __exit i915_exit(void) > > i915_perf_sysctl_unregister(); > pci_unregister_driver(&i915_pci_driver); > - i915_globals_exit(); > i915_pmu_exit(); > + i915_globals_exit(); > } > > module_init(i915_init); > -- > 2.31.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: Call i915_globals_exit() after i915_pmu_exit() 2021-07-16 22:47 ` [Intel-gfx] " Jason Ekstrand @ 2021-07-19 8:55 ` Tvrtko Ursulin -1 siblings, 0 replies; 13+ messages in thread From: Tvrtko Ursulin @ 2021-07-19 8:55 UTC (permalink / raw) To: Jason Ekstrand, intel-gfx, dri-devel Noticed PMU being mentioned.. On 16/07/2021 23:47, Jason Ekstrand wrote: > We should tear down in the opposite order we set up. > > Signed-off-by: Jason Ekstrand <jason@jlekstrand.net> > Fixes: 537f9c84a427 ("drm/i915/pmu: Fix CPU hotplug with multiple GPUs") 1) You can use 'dim fixes <sha>' to get you the correct cc list when using the fixes tag. But: 2) Fixes tag looks like should be removed to avoid potential needless backporting since I can't see that there is any inter-dependency between i915_pmu_exit and i915_globals_exit, hence nothing is getting fixes really, just tidying of the order. With fixes removed: Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko > Cc: Daniel Vetter <daniel@ffwll.ch> > --- > drivers/gpu/drm/i915/i915_pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c > index 67696d7522718..50ed93b03e582 100644 > --- a/drivers/gpu/drm/i915/i915_pci.c > +++ b/drivers/gpu/drm/i915/i915_pci.c > @@ -1244,8 +1244,8 @@ static void __exit i915_exit(void) > > i915_perf_sysctl_unregister(); > pci_unregister_driver(&i915_pci_driver); > - i915_globals_exit(); > i915_pmu_exit(); > + i915_globals_exit(); > } > > module_init(i915_init); > ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915: Call i915_globals_exit() after i915_pmu_exit() @ 2021-07-19 8:55 ` Tvrtko Ursulin 0 siblings, 0 replies; 13+ messages in thread From: Tvrtko Ursulin @ 2021-07-19 8:55 UTC (permalink / raw) To: Jason Ekstrand, intel-gfx, dri-devel Noticed PMU being mentioned.. On 16/07/2021 23:47, Jason Ekstrand wrote: > We should tear down in the opposite order we set up. > > Signed-off-by: Jason Ekstrand <jason@jlekstrand.net> > Fixes: 537f9c84a427 ("drm/i915/pmu: Fix CPU hotplug with multiple GPUs") 1) You can use 'dim fixes <sha>' to get you the correct cc list when using the fixes tag. But: 2) Fixes tag looks like should be removed to avoid potential needless backporting since I can't see that there is any inter-dependency between i915_pmu_exit and i915_globals_exit, hence nothing is getting fixes really, just tidying of the order. With fixes removed: Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Regards, Tvrtko > Cc: Daniel Vetter <daniel@ffwll.ch> > --- > drivers/gpu/drm/i915/i915_pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c > index 67696d7522718..50ed93b03e582 100644 > --- a/drivers/gpu/drm/i915/i915_pci.c > +++ b/drivers/gpu/drm/i915/i915_pci.c > @@ -1244,8 +1244,8 @@ static void __exit i915_exit(void) > > i915_perf_sysctl_unregister(); > pci_unregister_driver(&i915_pci_driver); > - i915_globals_exit(); > i915_pmu_exit(); > + i915_globals_exit(); > } > > module_init(i915_init); > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2021-07-19 8:56 UTC | newest] Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-07-16 22:47 [PATCH 1/2] drm/i915: Call i915_globals_exit() after i915_pmu_exit() Jason Ekstrand 2021-07-16 22:47 ` [Intel-gfx] " Jason Ekstrand 2021-07-16 22:47 ` [PATCH 2/2] drm/i915: Tear down properly on early i915_init exit Jason Ekstrand 2021-07-16 22:47 ` [Intel-gfx] " Jason Ekstrand 2021-07-19 8:28 ` Daniel Vetter 2021-07-19 8:28 ` [Intel-gfx] " Daniel Vetter 2021-07-17 1:21 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/2] drm/i915: Call i915_globals_exit() after i915_pmu_exit() Patchwork 2021-07-17 1:47 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2021-07-17 11:53 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2021-07-19 8:29 ` [PATCH 1/2] " Daniel Vetter 2021-07-19 8:29 ` [Intel-gfx] " Daniel Vetter 2021-07-19 8:55 ` Tvrtko Ursulin 2021-07-19 8:55 ` Tvrtko Ursulin
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.