From: Rob Herring <robh@kernel.org> To: Dong Aisheng <dongas86@gmail.com> Cc: Dong Aisheng <aisheng.dong@nxp.com>, Sascha Hauer <kernel@pengutronix.de>, devicetree <devicetree@vger.kernel.org>, Shawn Guo <shawnguo@kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 6/7] dt-bindings: soc: imx: add missing iomuxc gpr binding Date: Wed, 28 Jul 2021 11:30:19 -0600 [thread overview] Message-ID: <CAL_JsqLZLK75pj_HQDNY1CtHuKGRx-u36eDOyr8ObkR==GW6gQ@mail.gmail.com> (raw) In-Reply-To: <CAA+hA=TsEfz9Zo3wfsf6ZXnYHtfv5AbGNqVQEMn0q0bh1TOQDQ@mail.gmail.com> On Thu, Jul 15, 2021 at 9:30 PM Dong Aisheng <dongas86@gmail.com> wrote: > > Hi Rob, > > On Thu, Jul 15, 2021 at 9:54 PM Rob Herring <robh@kernel.org> wrote: > > > > On Thu, 15 Jul 2021 16:25:35 +0800, Dong Aisheng wrote: > > > The General Purpose Registers IOMUXC_GPR are used to select operating > > > modes for general features in the SoC, usually not related to the IOMUX > > > itself. > > > > > > This binding doc is generated based on the exist usage in dts > > > in order to fix dt schema check failures. > > > > > > Cc: Rob Herring <robh+dt@kernel.org> > > > Cc: Shawn Guo <shawnguo@kernel.org> > > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > > > --- > > > .../devicetree/bindings/soc/imx/fsl,gpr.yaml | 69 +++++++++++++++++++ > > > 1 file changed, 69 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,gpr.yaml > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/syscon.example.dt.yaml: iomuxc-gpr@20e0000: compatible: 'oneOf' conditional failed, one must be fixed: > > ['fsl,imx6q-iomuxc-gpr', 'syscon'] is too short > > 'fsl,imx53-iomuxc-gpr' was expected > > 'fsl,imx6q-iomuxc-gpr' is not one of ['fsl,imx6sl-iomuxc-gpr', 'fsl,imx6sll-iomuxc-gpr', 'fsl,imx6sx-iomuxc-gpr', 'fsl,imx6ul-iomuxc-gpr', 'fsl,imx7d-iomuxc-gpr'] > > 'fsl,imx7d-iomuxc-gpr' was expected > > 'fsl,imx8mq-iomuxc-gpr' was expected > > 'fsl,imx6q-iomuxc-gpr' is not one of ['fsl,imx8mm-iomuxc-gpr', 'fsl,imx8mn-iomuxc-gpr', 'fsl,imx8mp-iomuxc-gpr'] > > 'fsl,imx6q-iomuxc-gpr' was expected > > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/imx/fsl,gpr.yaml > > \ndoc reference errors (make refcheckdocs): > > Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt > > MAINTAINERS: Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt > > The example in syscon.yaml is invalid and needs change as follows. > However, should I do it in a separate patch cause they're changes for > two irrelevant binding > files or merge into this one ? Separate patch. > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml > b/Documentation/devicetree/bindings/mfd/syscon.yaml > index f14ae6da0068..11eae4c5848e 100644 > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml > @@ -90,7 +90,7 @@ examples: > > - | > gpr: iomuxc-gpr@20e0000 { > - compatible = "fsl,imx6q-iomuxc-gpr", "syscon"; > + compatible = "fsl,imx6q-iomuxc-gpr", "syscon", "mfd"; I assume you mean 'simple-mfd'? Adding that means this example doesn't really even match the syscon.yaml, so I'd just drop the example.
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Dong Aisheng <dongas86@gmail.com> Cc: Dong Aisheng <aisheng.dong@nxp.com>, Sascha Hauer <kernel@pengutronix.de>, devicetree <devicetree@vger.kernel.org>, Shawn Guo <shawnguo@kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 6/7] dt-bindings: soc: imx: add missing iomuxc gpr binding Date: Wed, 28 Jul 2021 11:30:19 -0600 [thread overview] Message-ID: <CAL_JsqLZLK75pj_HQDNY1CtHuKGRx-u36eDOyr8ObkR==GW6gQ@mail.gmail.com> (raw) In-Reply-To: <CAA+hA=TsEfz9Zo3wfsf6ZXnYHtfv5AbGNqVQEMn0q0bh1TOQDQ@mail.gmail.com> On Thu, Jul 15, 2021 at 9:30 PM Dong Aisheng <dongas86@gmail.com> wrote: > > Hi Rob, > > On Thu, Jul 15, 2021 at 9:54 PM Rob Herring <robh@kernel.org> wrote: > > > > On Thu, 15 Jul 2021 16:25:35 +0800, Dong Aisheng wrote: > > > The General Purpose Registers IOMUXC_GPR are used to select operating > > > modes for general features in the SoC, usually not related to the IOMUX > > > itself. > > > > > > This binding doc is generated based on the exist usage in dts > > > in order to fix dt schema check failures. > > > > > > Cc: Rob Herring <robh+dt@kernel.org> > > > Cc: Shawn Guo <shawnguo@kernel.org> > > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > > > --- > > > .../devicetree/bindings/soc/imx/fsl,gpr.yaml | 69 +++++++++++++++++++ > > > 1 file changed, 69 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,gpr.yaml > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/syscon.example.dt.yaml: iomuxc-gpr@20e0000: compatible: 'oneOf' conditional failed, one must be fixed: > > ['fsl,imx6q-iomuxc-gpr', 'syscon'] is too short > > 'fsl,imx53-iomuxc-gpr' was expected > > 'fsl,imx6q-iomuxc-gpr' is not one of ['fsl,imx6sl-iomuxc-gpr', 'fsl,imx6sll-iomuxc-gpr', 'fsl,imx6sx-iomuxc-gpr', 'fsl,imx6ul-iomuxc-gpr', 'fsl,imx7d-iomuxc-gpr'] > > 'fsl,imx7d-iomuxc-gpr' was expected > > 'fsl,imx8mq-iomuxc-gpr' was expected > > 'fsl,imx6q-iomuxc-gpr' is not one of ['fsl,imx8mm-iomuxc-gpr', 'fsl,imx8mn-iomuxc-gpr', 'fsl,imx8mp-iomuxc-gpr'] > > 'fsl,imx6q-iomuxc-gpr' was expected > > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/imx/fsl,gpr.yaml > > \ndoc reference errors (make refcheckdocs): > > Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt > > MAINTAINERS: Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt > > The example in syscon.yaml is invalid and needs change as follows. > However, should I do it in a separate patch cause they're changes for > two irrelevant binding > files or merge into this one ? Separate patch. > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml > b/Documentation/devicetree/bindings/mfd/syscon.yaml > index f14ae6da0068..11eae4c5848e 100644 > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml > @@ -90,7 +90,7 @@ examples: > > - | > gpr: iomuxc-gpr@20e0000 { > - compatible = "fsl,imx6q-iomuxc-gpr", "syscon"; > + compatible = "fsl,imx6q-iomuxc-gpr", "syscon", "mfd"; I assume you mean 'simple-mfd'? Adding that means this example doesn't really even match the syscon.yaml, so I'd just drop the example. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-28 17:30 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-15 8:25 [PATCH 0/7] dt-bindings: imx8mp: fix dt schema check errors Dong Aisheng 2021-07-15 8:25 ` Dong Aisheng 2021-07-15 8:25 ` [PATCH 1/7] dt-bindings: can: flexcan: fix imx8mp compatbile Dong Aisheng 2021-07-15 8:25 ` Dong Aisheng 2021-07-15 9:12 ` Marc Kleine-Budde 2021-07-15 9:12 ` Marc Kleine-Budde 2021-07-15 10:45 ` Dong Aisheng 2021-07-15 10:45 ` Dong Aisheng 2021-07-15 11:00 ` Joakim Zhang 2021-07-15 11:00 ` Joakim Zhang 2021-07-15 11:07 ` Marc Kleine-Budde 2021-07-15 11:07 ` Marc Kleine-Budde 2021-07-15 11:36 ` Dong Aisheng 2021-07-15 11:36 ` Dong Aisheng 2021-07-15 11:44 ` Joakim Zhang 2021-07-15 11:44 ` Joakim Zhang 2021-07-15 11:49 ` Dong Aisheng 2021-07-15 11:49 ` Dong Aisheng 2021-07-15 12:10 ` Marc Kleine-Budde 2021-07-15 12:10 ` Marc Kleine-Budde 2021-07-15 12:07 ` Marc Kleine-Budde 2021-07-15 12:07 ` Marc Kleine-Budde 2021-07-16 2:04 ` Joakim Zhang 2021-07-16 2:04 ` Joakim Zhang 2021-07-16 9:06 ` Marc Kleine-Budde 2021-07-16 9:06 ` Marc Kleine-Budde 2021-07-15 8:25 ` [PATCH 2/7] dt-bindings: spi: flexspi: convert to json schema Dong Aisheng 2021-07-15 8:25 ` Dong Aisheng 2021-07-15 9:25 ` [EXT] " Kuldeep Singh 2021-07-15 9:25 ` Kuldeep Singh 2021-07-15 10:43 ` Dong Aisheng 2021-07-15 10:43 ` Dong Aisheng 2021-07-15 8:25 ` [PATCH 3/7] dt-bindings: net: dsa: sja1105: fix wrong indentation Dong Aisheng 2021-07-15 8:25 ` Dong Aisheng 2021-07-15 10:04 ` Vladimir Oltean 2021-07-15 10:04 ` Vladimir Oltean 2021-07-15 10:43 ` Dong Aisheng 2021-07-15 10:43 ` Dong Aisheng 2021-07-15 8:25 ` [PATCH 4/7] dt-bindings: phy: imx8mq-usb-phy: convert to json schema Dong Aisheng 2021-07-15 8:25 ` Dong Aisheng 2021-07-15 8:25 ` Dong Aisheng 2021-07-22 2:47 ` Rob Herring 2021-07-22 2:47 ` Rob Herring 2021-07-22 2:47 ` Rob Herring 2021-08-06 11:30 ` Vinod Koul 2021-08-06 11:30 ` Vinod Koul 2021-08-06 11:30 ` Vinod Koul 2021-07-15 8:25 ` [PATCH 5/7] dt-bindings: soc: imx: add missing anatop binding Dong Aisheng 2021-07-15 8:25 ` Dong Aisheng 2021-07-22 2:49 ` Rob Herring 2021-07-22 2:49 ` Rob Herring 2021-08-02 11:36 ` Dong Aisheng 2021-08-02 11:36 ` Dong Aisheng 2021-08-02 15:01 ` Rob Herring 2021-08-02 15:01 ` Rob Herring 2021-08-03 4:04 ` Dong Aisheng 2021-08-03 4:04 ` Dong Aisheng 2021-07-15 8:25 ` [PATCH 6/7] dt-bindings: soc: imx: add missing iomuxc gpr binding Dong Aisheng 2021-07-15 8:25 ` Dong Aisheng 2021-07-15 13:54 ` Rob Herring 2021-07-15 13:54 ` Rob Herring 2021-07-16 3:28 ` Dong Aisheng 2021-07-16 3:28 ` Dong Aisheng 2021-07-28 17:30 ` Rob Herring [this message] 2021-07-28 17:30 ` Rob Herring 2021-08-02 11:36 ` Dong Aisheng 2021-08-02 11:36 ` Dong Aisheng 2021-07-15 8:25 ` [PATCH 7/7] arm64: dts: imx8mp: fix fspi dt schema check error Dong Aisheng 2021-07-15 8:25 ` Dong Aisheng
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAL_JsqLZLK75pj_HQDNY1CtHuKGRx-u36eDOyr8ObkR==GW6gQ@mail.gmail.com' \ --to=robh@kernel.org \ --cc=aisheng.dong@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=dongas86@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.