From: Joakim Zhang <qiangqing.zhang@nxp.com> To: Dong Aisheng <dongas86@gmail.com>, Marc Kleine-Budde <mkl@pengutronix.de> Cc: Aisheng Dong <aisheng.dong@nxp.com>, devicetree <devicetree@vger.kernel.org>, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>, dl-linux-imx <linux-imx@nxp.com>, Sascha Hauer <kernel@pengutronix.de>, Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org> Subject: RE: [PATCH 1/7] dt-bindings: can: flexcan: fix imx8mp compatbile Date: Thu, 15 Jul 2021 11:00:07 +0000 [thread overview] Message-ID: <DB8PR04MB6795ACFCCB64354C8E810EE8E6129@DB8PR04MB6795.eurprd04.prod.outlook.com> (raw) In-Reply-To: <CAA+hA=QDJhf_LnBZCiKE-FbUNciX4bmgmrvft8Y-vkB9Lguj=w@mail.gmail.com> Hi Aisheng, Marc, > -----Original Message----- > From: Dong Aisheng <dongas86@gmail.com> > Sent: 2021年7月15日 18:46 > To: Marc Kleine-Budde <mkl@pengutronix.de> > Cc: Aisheng Dong <aisheng.dong@nxp.com>; devicetree > <devicetree@vger.kernel.org>; moderated list:ARM/FREESCALE IMX / MXC > ARM ARCHITECTURE <linux-arm-kernel@lists.infradead.org>; dl-linux-imx > <linux-imx@nxp.com>; Sascha Hauer <kernel@pengutronix.de>; Rob Herring > <robh+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Joakim Zhang > <qiangqing.zhang@nxp.com>; linux-can@vger.kernel.org; > netdev@vger.kernel.org > Subject: Re: [PATCH 1/7] dt-bindings: can: flexcan: fix imx8mp compatbile > > Hi Marc, > > On Thu, Jul 15, 2021 at 5:12 PM Marc Kleine-Budde <mkl@pengutronix.de> > wrote: > > > > On 15.07.2021 16:25:30, Dong Aisheng wrote: > > > This patch fixes the following errors during make dtbs_check: > > > arch/arm64/boot/dts/freescale/imx8mp-evk.dt.yaml: can@308c0000: > compatible: 'oneOf' conditional failed, one must be fixed: > > > ['fsl,imx8mp-flexcan', 'fsl,imx6q-flexcan'] is too long > > > > IIRC the fsl,imx6q-flexcan binding doesn't work on the imx8mp. Maybe > > better change the dtsi? > > I checked with Joakim that the flexcan on MX8MP is derived from MX6Q with > extra ECC added. Maybe we should still keep it from HW point of view? Sorry, Aisheng, I double check the history, and get the below results: 8MP reuses 8QXP(8QM), except ECC_EN (ipv_flexcan3_syn_006/D_IP_FlexCAN3_SYN_057 which corresponds to version d_ip_flexcan3_syn.03.00.17.01) I prefer to change the dtsi as Mac suggested if possible, shall I send a fix patch? Best Regards, Joakim Zhang > Regards > Aisheng > > > > > regards, > > Marc > > > > -- > > Pengutronix e.K. | Marc Kleine-Budde | > > Embedded Linux | > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.p > engutronix.de%2F&data=04%7C01%7Cqiangqing.zhang%40nxp.com%7Ce > df7b681c04c48c0695e08d9477e03b0%7C686ea1d3bc2b4c6fa92cd99c5c30163 > 5%7C0%7C0%7C637619428815826860%7CUnknown%7CTWFpbGZsb3d8eyJWI > joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1 > 000&sdata=Sd01Qk9H%2F8pBD0FAFQdQnQU9qp%2Br2ItGKdljK%2BWTiG > Q%3D&reserved=0 | > > Vertretung West/Dortmund | Phone: +49-231-2826-924 | > > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Joakim Zhang <qiangqing.zhang@nxp.com> To: Dong Aisheng <dongas86@gmail.com>, Marc Kleine-Budde <mkl@pengutronix.de> Cc: Aisheng Dong <aisheng.dong@nxp.com>, devicetree <devicetree@vger.kernel.org>, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>, dl-linux-imx <linux-imx@nxp.com>, Sascha Hauer <kernel@pengutronix.de>, Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org> Subject: RE: [PATCH 1/7] dt-bindings: can: flexcan: fix imx8mp compatbile Date: Thu, 15 Jul 2021 11:00:07 +0000 [thread overview] Message-ID: <DB8PR04MB6795ACFCCB64354C8E810EE8E6129@DB8PR04MB6795.eurprd04.prod.outlook.com> (raw) In-Reply-To: <CAA+hA=QDJhf_LnBZCiKE-FbUNciX4bmgmrvft8Y-vkB9Lguj=w@mail.gmail.com> Hi Aisheng, Marc, > -----Original Message----- > From: Dong Aisheng <dongas86@gmail.com> > Sent: 2021年7月15日 18:46 > To: Marc Kleine-Budde <mkl@pengutronix.de> > Cc: Aisheng Dong <aisheng.dong@nxp.com>; devicetree > <devicetree@vger.kernel.org>; moderated list:ARM/FREESCALE IMX / MXC > ARM ARCHITECTURE <linux-arm-kernel@lists.infradead.org>; dl-linux-imx > <linux-imx@nxp.com>; Sascha Hauer <kernel@pengutronix.de>; Rob Herring > <robh+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Joakim Zhang > <qiangqing.zhang@nxp.com>; linux-can@vger.kernel.org; > netdev@vger.kernel.org > Subject: Re: [PATCH 1/7] dt-bindings: can: flexcan: fix imx8mp compatbile > > Hi Marc, > > On Thu, Jul 15, 2021 at 5:12 PM Marc Kleine-Budde <mkl@pengutronix.de> > wrote: > > > > On 15.07.2021 16:25:30, Dong Aisheng wrote: > > > This patch fixes the following errors during make dtbs_check: > > > arch/arm64/boot/dts/freescale/imx8mp-evk.dt.yaml: can@308c0000: > compatible: 'oneOf' conditional failed, one must be fixed: > > > ['fsl,imx8mp-flexcan', 'fsl,imx6q-flexcan'] is too long > > > > IIRC the fsl,imx6q-flexcan binding doesn't work on the imx8mp. Maybe > > better change the dtsi? > > I checked with Joakim that the flexcan on MX8MP is derived from MX6Q with > extra ECC added. Maybe we should still keep it from HW point of view? Sorry, Aisheng, I double check the history, and get the below results: 8MP reuses 8QXP(8QM), except ECC_EN (ipv_flexcan3_syn_006/D_IP_FlexCAN3_SYN_057 which corresponds to version d_ip_flexcan3_syn.03.00.17.01) I prefer to change the dtsi as Mac suggested if possible, shall I send a fix patch? Best Regards, Joakim Zhang > Regards > Aisheng > > > > > regards, > > Marc > > > > -- > > Pengutronix e.K. | Marc Kleine-Budde | > > Embedded Linux | > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.p > engutronix.de%2F&data=04%7C01%7Cqiangqing.zhang%40nxp.com%7Ce > df7b681c04c48c0695e08d9477e03b0%7C686ea1d3bc2b4c6fa92cd99c5c30163 > 5%7C0%7C0%7C637619428815826860%7CUnknown%7CTWFpbGZsb3d8eyJWI > joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1 > 000&sdata=Sd01Qk9H%2F8pBD0FAFQdQnQU9qp%2Br2ItGKdljK%2BWTiG > Q%3D&reserved=0 | > > Vertretung West/Dortmund | Phone: +49-231-2826-924 | > > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-15 11:00 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-15 8:25 [PATCH 0/7] dt-bindings: imx8mp: fix dt schema check errors Dong Aisheng 2021-07-15 8:25 ` Dong Aisheng 2021-07-15 8:25 ` [PATCH 1/7] dt-bindings: can: flexcan: fix imx8mp compatbile Dong Aisheng 2021-07-15 8:25 ` Dong Aisheng 2021-07-15 9:12 ` Marc Kleine-Budde 2021-07-15 9:12 ` Marc Kleine-Budde 2021-07-15 10:45 ` Dong Aisheng 2021-07-15 10:45 ` Dong Aisheng 2021-07-15 11:00 ` Joakim Zhang [this message] 2021-07-15 11:00 ` Joakim Zhang 2021-07-15 11:07 ` Marc Kleine-Budde 2021-07-15 11:07 ` Marc Kleine-Budde 2021-07-15 11:36 ` Dong Aisheng 2021-07-15 11:36 ` Dong Aisheng 2021-07-15 11:44 ` Joakim Zhang 2021-07-15 11:44 ` Joakim Zhang 2021-07-15 11:49 ` Dong Aisheng 2021-07-15 11:49 ` Dong Aisheng 2021-07-15 12:10 ` Marc Kleine-Budde 2021-07-15 12:10 ` Marc Kleine-Budde 2021-07-15 12:07 ` Marc Kleine-Budde 2021-07-15 12:07 ` Marc Kleine-Budde 2021-07-16 2:04 ` Joakim Zhang 2021-07-16 2:04 ` Joakim Zhang 2021-07-16 9:06 ` Marc Kleine-Budde 2021-07-16 9:06 ` Marc Kleine-Budde 2021-07-15 8:25 ` [PATCH 2/7] dt-bindings: spi: flexspi: convert to json schema Dong Aisheng 2021-07-15 8:25 ` Dong Aisheng 2021-07-15 9:25 ` [EXT] " Kuldeep Singh 2021-07-15 9:25 ` Kuldeep Singh 2021-07-15 10:43 ` Dong Aisheng 2021-07-15 10:43 ` Dong Aisheng 2021-07-15 8:25 ` [PATCH 3/7] dt-bindings: net: dsa: sja1105: fix wrong indentation Dong Aisheng 2021-07-15 8:25 ` Dong Aisheng 2021-07-15 10:04 ` Vladimir Oltean 2021-07-15 10:04 ` Vladimir Oltean 2021-07-15 10:43 ` Dong Aisheng 2021-07-15 10:43 ` Dong Aisheng 2021-07-15 8:25 ` [PATCH 4/7] dt-bindings: phy: imx8mq-usb-phy: convert to json schema Dong Aisheng 2021-07-15 8:25 ` Dong Aisheng 2021-07-15 8:25 ` Dong Aisheng 2021-07-22 2:47 ` Rob Herring 2021-07-22 2:47 ` Rob Herring 2021-07-22 2:47 ` Rob Herring 2021-08-06 11:30 ` Vinod Koul 2021-08-06 11:30 ` Vinod Koul 2021-08-06 11:30 ` Vinod Koul 2021-07-15 8:25 ` [PATCH 5/7] dt-bindings: soc: imx: add missing anatop binding Dong Aisheng 2021-07-15 8:25 ` Dong Aisheng 2021-07-22 2:49 ` Rob Herring 2021-07-22 2:49 ` Rob Herring 2021-08-02 11:36 ` Dong Aisheng 2021-08-02 11:36 ` Dong Aisheng 2021-08-02 15:01 ` Rob Herring 2021-08-02 15:01 ` Rob Herring 2021-08-03 4:04 ` Dong Aisheng 2021-08-03 4:04 ` Dong Aisheng 2021-07-15 8:25 ` [PATCH 6/7] dt-bindings: soc: imx: add missing iomuxc gpr binding Dong Aisheng 2021-07-15 8:25 ` Dong Aisheng 2021-07-15 13:54 ` Rob Herring 2021-07-15 13:54 ` Rob Herring 2021-07-16 3:28 ` Dong Aisheng 2021-07-16 3:28 ` Dong Aisheng 2021-07-28 17:30 ` Rob Herring 2021-07-28 17:30 ` Rob Herring 2021-08-02 11:36 ` Dong Aisheng 2021-08-02 11:36 ` Dong Aisheng 2021-07-15 8:25 ` [PATCH 7/7] arm64: dts: imx8mp: fix fspi dt schema check error Dong Aisheng 2021-07-15 8:25 ` Dong Aisheng
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=DB8PR04MB6795ACFCCB64354C8E810EE8E6129@DB8PR04MB6795.eurprd04.prod.outlook.com \ --to=qiangqing.zhang@nxp.com \ --cc=aisheng.dong@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=dongas86@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-can@vger.kernel.org \ --cc=linux-imx@nxp.com \ --cc=mkl@pengutronix.de \ --cc=netdev@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.