From: Tyler Baker <tyler.baker@linaro.org> To: Shuah Khan <shuahkh@osg.samsung.com> Cc: Andy Lutomirski <luto@amacapital.net>, Kevin Hilman <khilman@kernel.org>, John Stultz <john.stultz@linaro.org>, Darren Hart <dvhart@infradead.org>, Michael Ellerman <mpe@ellerman.id.au>, David Herrmann <dh.herrmann@gmail.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 1/2] selftests/lib.mk: fix INSTALL_RULE Date: Tue, 12 May 2015 15:04:42 -0700 [thread overview] Message-ID: <CANMBJr69_WM1dKw627J+zFv6UwsF5Sv9D+rjnK5YHD60DH5Nig@mail.gmail.com> (raw) In-Reply-To: <55527893.4070305@osg.samsung.com> On 12 May 2015 at 15:02, Shuah Khan <shuahkh@osg.samsung.com> wrote: > On 05/12/2015 03:59 PM, tyler.baker@linaro.org wrote: >> From: Tyler Baker <tyler.baker@linaro.org> > > This is odd. Did you use git send-email to send the patches? Yes I did. > > -- Shuah >> >> This patch fixes the INSTALL_RULE to gracefully handle the case where >> TEST_PROGS and TEST_PROGS_EXTENDED and TEST_FILES are not set. In this case, >> install is called without any SOURCE arguments causing make install to fail. >> The proposed fix is to loop over the items in these variables and only call >> install if there is a test artifact present. >> >> Signed-off-by: Tyler Baker <tyler.baker@linaro.org> >> --- >> tools/testing/selftests/lib.mk | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk >> index ee412ba..89dd785f 100644 >> --- a/tools/testing/selftests/lib.mk >> +++ b/tools/testing/selftests/lib.mk >> @@ -13,10 +13,12 @@ run_tests: all >> >> define INSTALL_RULE >> mkdir -p $(INSTALL_PATH) >> - @for TEST_DIR in $(TEST_DIRS); do\ >> + @for TEST_DIR in $(TEST_DIRS); do \ >> cp -r $$TEST_DIR $(INSTALL_PATH); \ >> done; >> - install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES) >> + @for ARTIFACT in $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES); do \ >> + install -t $(INSTALL_PATH) $$ARTIFACT; \ >> + done; >> endef >> >> install: all >> > > > -- > Shuah Khan > Sr. Linux Kernel Developer > Open Source Innovation Group > Samsung Research America (Silicon Valley) > shuahkh@osg.samsung.com | (970) 217-8978 -- Tyler Baker Tech Lead, LAVA Linaro.org | Open source software for ARM SoCs Follow Linaro: http://www.facebook.com/pages/Linaro http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog
WARNING: multiple messages have this Message-ID (diff)
From: tyler.baker@linaro.org (Tyler Baker) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] selftests/lib.mk: fix INSTALL_RULE Date: Tue, 12 May 2015 15:04:42 -0700 [thread overview] Message-ID: <CANMBJr69_WM1dKw627J+zFv6UwsF5Sv9D+rjnK5YHD60DH5Nig@mail.gmail.com> (raw) In-Reply-To: <55527893.4070305@osg.samsung.com> On 12 May 2015 at 15:02, Shuah Khan <shuahkh@osg.samsung.com> wrote: > On 05/12/2015 03:59 PM, tyler.baker at linaro.org wrote: >> From: Tyler Baker <tyler.baker@linaro.org> > > This is odd. Did you use git send-email to send the patches? Yes I did. > > -- Shuah >> >> This patch fixes the INSTALL_RULE to gracefully handle the case where >> TEST_PROGS and TEST_PROGS_EXTENDED and TEST_FILES are not set. In this case, >> install is called without any SOURCE arguments causing make install to fail. >> The proposed fix is to loop over the items in these variables and only call >> install if there is a test artifact present. >> >> Signed-off-by: Tyler Baker <tyler.baker@linaro.org> >> --- >> tools/testing/selftests/lib.mk | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk >> index ee412ba..89dd785f 100644 >> --- a/tools/testing/selftests/lib.mk >> +++ b/tools/testing/selftests/lib.mk >> @@ -13,10 +13,12 @@ run_tests: all >> >> define INSTALL_RULE >> mkdir -p $(INSTALL_PATH) >> - @for TEST_DIR in $(TEST_DIRS); do\ >> + @for TEST_DIR in $(TEST_DIRS); do \ >> cp -r $$TEST_DIR $(INSTALL_PATH); \ >> done; >> - install -t $(INSTALL_PATH) $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES) >> + @for ARTIFACT in $(TEST_PROGS) $(TEST_PROGS_EXTENDED) $(TEST_FILES); do \ >> + install -t $(INSTALL_PATH) $$ARTIFACT; \ >> + done; >> endef >> >> install: all >> > > > -- > Shuah Khan > Sr. Linux Kernel Developer > Open Source Innovation Group > Samsung Research America (Silicon Valley) > shuahkh at osg.samsung.com | (970) 217-8978 -- Tyler Baker Tech Lead, LAVA Linaro.org | Open source software for ARM SoCs Follow Linaro: http://www.facebook.com/pages/Linaro http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog
next prev parent reply other threads:[~2015-05-12 22:04 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-05-12 21:59 [PATCH 0/2] selftests: installation fixes tyler.baker 2015-05-12 21:59 ` tyler.baker at linaro.org 2015-05-12 21:59 ` [PATCH 1/2] selftests/lib.mk: fix INSTALL_RULE tyler.baker 2015-05-12 21:59 ` tyler.baker at linaro.org 2015-05-12 22:02 ` Shuah Khan 2015-05-12 22:02 ` Shuah Khan 2015-05-12 22:04 ` Tyler Baker [this message] 2015-05-12 22:04 ` Tyler Baker 2015-05-12 22:07 ` Shuah Khan 2015-05-12 22:07 ` Shuah Khan 2015-05-12 22:41 ` Tyler Baker 2015-05-12 22:41 ` Tyler Baker 2015-05-12 21:59 ` [PATCH 2/2] selftests/breakpoints: only set TEST_PROGS when built tyler.baker 2015-05-12 21:59 ` tyler.baker at linaro.org 2015-05-13 21:41 ` Shuah Khan 2015-05-13 21:41 ` Shuah Khan 2015-05-14 14:15 ` Tyler Baker 2015-05-14 14:15 ` Tyler Baker 2015-05-14 15:27 ` Shuah Khan 2015-05-14 15:27 ` Shuah Khan 2015-05-14 17:11 ` Tyler Baker 2015-05-14 17:11 ` Tyler Baker
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CANMBJr69_WM1dKw627J+zFv6UwsF5Sv9D+rjnK5YHD60DH5Nig@mail.gmail.com \ --to=tyler.baker@linaro.org \ --cc=dh.herrmann@gmail.com \ --cc=dvhart@infradead.org \ --cc=john.stultz@linaro.org \ --cc=khilman@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=luto@amacapital.net \ --cc=mpe@ellerman.id.au \ --cc=shuahkh@osg.samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.