From: Shuah Khan <shuahkh@osg.samsung.com>
To: tyler.baker@linaro.org
Cc: Andy Lutomirski <luto@amacapital.net>,
Kevin Hilman <khilman@kernel.org>,
John Stultz <john.stultz@linaro.org>,
Darren Hart <dvhart@infradead.org>,
Michael Ellerman <mpe@ellerman.id.au>,
David Herrmann <dh.herrmann@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH 2/2] selftests/breakpoints: only set TEST_PROGS when built
Date: Wed, 13 May 2015 15:41:47 -0600 [thread overview]
Message-ID: <5553C51B.6080504@osg.samsung.com> (raw)
In-Reply-To: <1431467947-29847-3-git-send-email-tyler.baker@linaro.org>
On 05/12/2015 03:59 PM, tyler.baker@linaro.org wrote:
> From: Tyler Baker <tyler.baker@linaro.org>
>
> Set TEST_PROGS only when a build has occurred.
>
> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
> ---
> tools/testing/selftests/breakpoints/Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile
> index 1822356..54cc3e7 100644
> --- a/tools/testing/selftests/breakpoints/Makefile
> +++ b/tools/testing/selftests/breakpoints/Makefile
> @@ -12,12 +12,11 @@ endif
> all:
> ifeq ($(ARCH),x86)
> gcc breakpoint_test.c -o breakpoint_test
> + TEST_PROGS := breakpoint_test
> else
> echo "Not an x86 target, can't build breakpoints selftests"
> endif
>
> -TEST_PROGS := breakpoint_test
> -
> include ../lib.mk
>
> clean:
>
Hmm. With this change install fails to copy breakpoint_test all
together. Remember setting TEST_PROGS in compile step makes it
not stick around when install target is called. A better approach
would be the following:
if [ -f breakpoint_test ]
TEST_PROGS := breakpoint_test
fi
include ../lib.mk
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
WARNING: multiple messages have this Message-ID (diff)
From: shuahkh@osg.samsung.com (Shuah Khan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] selftests/breakpoints: only set TEST_PROGS when built
Date: Wed, 13 May 2015 15:41:47 -0600 [thread overview]
Message-ID: <5553C51B.6080504@osg.samsung.com> (raw)
In-Reply-To: <1431467947-29847-3-git-send-email-tyler.baker@linaro.org>
On 05/12/2015 03:59 PM, tyler.baker at linaro.org wrote:
> From: Tyler Baker <tyler.baker@linaro.org>
>
> Set TEST_PROGS only when a build has occurred.
>
> Signed-off-by: Tyler Baker <tyler.baker@linaro.org>
> ---
> tools/testing/selftests/breakpoints/Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile
> index 1822356..54cc3e7 100644
> --- a/tools/testing/selftests/breakpoints/Makefile
> +++ b/tools/testing/selftests/breakpoints/Makefile
> @@ -12,12 +12,11 @@ endif
> all:
> ifeq ($(ARCH),x86)
> gcc breakpoint_test.c -o breakpoint_test
> + TEST_PROGS := breakpoint_test
> else
> echo "Not an x86 target, can't build breakpoints selftests"
> endif
>
> -TEST_PROGS := breakpoint_test
> -
> include ../lib.mk
>
> clean:
>
Hmm. With this change install fails to copy breakpoint_test all
together. Remember setting TEST_PROGS in compile step makes it
not stick around when install target is called. A better approach
would be the following:
if [ -f breakpoint_test ]
TEST_PROGS := breakpoint_test
fi
include ../lib.mk
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh at osg.samsung.com | (970) 217-8978
next prev parent reply other threads:[~2015-05-13 21:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 21:59 [PATCH 0/2] selftests: installation fixes tyler.baker
2015-05-12 21:59 ` tyler.baker at linaro.org
2015-05-12 21:59 ` [PATCH 1/2] selftests/lib.mk: fix INSTALL_RULE tyler.baker
2015-05-12 21:59 ` tyler.baker at linaro.org
2015-05-12 22:02 ` Shuah Khan
2015-05-12 22:02 ` Shuah Khan
2015-05-12 22:04 ` Tyler Baker
2015-05-12 22:04 ` Tyler Baker
2015-05-12 22:07 ` Shuah Khan
2015-05-12 22:07 ` Shuah Khan
2015-05-12 22:41 ` Tyler Baker
2015-05-12 22:41 ` Tyler Baker
2015-05-12 21:59 ` [PATCH 2/2] selftests/breakpoints: only set TEST_PROGS when built tyler.baker
2015-05-12 21:59 ` tyler.baker at linaro.org
2015-05-13 21:41 ` Shuah Khan [this message]
2015-05-13 21:41 ` Shuah Khan
2015-05-14 14:15 ` Tyler Baker
2015-05-14 14:15 ` Tyler Baker
2015-05-14 15:27 ` Shuah Khan
2015-05-14 15:27 ` Shuah Khan
2015-05-14 17:11 ` Tyler Baker
2015-05-14 17:11 ` Tyler Baker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5553C51B.6080504@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=dh.herrmann@gmail.com \
--cc=dvhart@infradead.org \
--cc=john.stultz@linaro.org \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mpe@ellerman.id.au \
--cc=tyler.baker@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.