From: Olof Johansson <olof@lixom.net>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: David Brown <davidb@codeaurora.org>,
Kumar Gala <galak@codeaurora.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Lina Iyer <lina.iyer@linaro.org>
Subject: Re: [PATCH 8/8] msm: scm: Move the scm driver to drivers/soc/qcom
Date: Wed, 21 Jan 2015 17:13:35 -0800 [thread overview]
Message-ID: <CAOesGMh1HE+hMP0VWr2vaHCp2itVjpQeiiFL6r9WeJUFes5tvw@mail.gmail.com> (raw)
In-Reply-To: <1407202310-3359-9-git-send-email-sboyd@codeaurora.org>
I just saw this in the pull request from Kumar, so this is a bit late
w.r.t. to the patch, but so was his merging of the code. :)
On Mon, Aug 4, 2014 at 6:31 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> Architectural changes in the ARM Linux kernel tree mandate
> the eventual removal of the mach-* directories. Move the
> scm driver to drivers/soc/qcom and the scm header to
> include/soc/qcom to support that removal.
The idea is not blindly move one dumping ground to a new place.
I see only two exported functions from scm.c:
scm_get_version: This is not used anywhere in the kernel and can just be removed
scm_call: This is used by scm-boot, and would be better to translate
over to firmware_ops in the first place.
So, can you please rework this with the above in mind instead of just
moving the files over? Thanks!
-Olof
WARNING: multiple messages have this Message-ID (diff)
From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/8] msm: scm: Move the scm driver to drivers/soc/qcom
Date: Wed, 21 Jan 2015 17:13:35 -0800 [thread overview]
Message-ID: <CAOesGMh1HE+hMP0VWr2vaHCp2itVjpQeiiFL6r9WeJUFes5tvw@mail.gmail.com> (raw)
In-Reply-To: <1407202310-3359-9-git-send-email-sboyd@codeaurora.org>
I just saw this in the pull request from Kumar, so this is a bit late
w.r.t. to the patch, but so was his merging of the code. :)
On Mon, Aug 4, 2014 at 6:31 PM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> Architectural changes in the ARM Linux kernel tree mandate
> the eventual removal of the mach-* directories. Move the
> scm driver to drivers/soc/qcom and the scm header to
> include/soc/qcom to support that removal.
The idea is not blindly move one dumping ground to a new place.
I see only two exported functions from scm.c:
scm_get_version: This is not used anywhere in the kernel and can just be removed
scm_call: This is used by scm-boot, and would be better to translate
over to firmware_ops in the first place.
So, can you please rework this with the above in mind instead of just
moving the files over? Thanks!
-Olof
next prev parent reply other threads:[~2015-01-22 1:13 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 1:31 [PATCH 0/8] qcom SCM updates Stephen Boyd
2014-08-05 1:31 ` Stephen Boyd
2014-08-05 1:31 ` [PATCH 1/8] msm: scm: Fix incorrect cache invalidation Stephen Boyd
2014-08-05 1:31 ` Stephen Boyd
2014-08-05 1:31 ` [PATCH 2/8] msm: scm: Get cacheline size from CTR Stephen Boyd
2014-08-05 1:31 ` Stephen Boyd
2014-08-05 1:31 ` Stephen Boyd
2014-08-05 1:31 ` [PATCH 3/8] msm: scm: Flush the command buffer only instead of the entire cache Stephen Boyd
2014-08-05 1:31 ` Stephen Boyd
2014-08-05 1:31 ` Stephen Boyd
2014-08-05 1:31 ` [PATCH 4/8] msm: scm: Add atomic SCM APIs Stephen Boyd
2014-08-05 1:31 ` Stephen Boyd
2014-08-05 1:31 ` [PATCH 5/8] msm: scm: Add API to query for service/command availability Stephen Boyd
2014-08-05 1:31 ` Stephen Boyd
2014-08-05 1:31 ` Stephen Boyd
2014-08-05 1:31 ` [PATCH 6/8] msm: scm: Add a feat version query API Stephen Boyd
2014-08-05 1:31 ` Stephen Boyd
2014-08-05 1:31 ` [PATCH 7/8] msm: scm: Add logging of actual return code from scm call Stephen Boyd
2014-08-05 1:31 ` Stephen Boyd
2014-08-05 1:31 ` [PATCH 8/8] msm: scm: Move the scm driver to drivers/soc/qcom Stephen Boyd
2014-08-05 1:31 ` Stephen Boyd
2014-08-05 4:07 ` Lina Iyer
2014-08-05 4:07 ` Lina Iyer
2014-08-05 20:12 ` Bjorn Andersson
2014-08-05 20:12 ` Bjorn Andersson
2014-08-05 20:12 ` Bjorn Andersson
2014-08-05 20:17 ` Lina Iyer
2014-08-05 20:17 ` Lina Iyer
2014-08-05 20:17 ` Lina Iyer
2015-01-22 1:13 ` Olof Johansson [this message]
2015-01-22 1:13 ` Olof Johansson
2015-01-22 1:13 ` Olof Johansson
2015-01-22 1:53 ` Bjorn Andersson
2015-01-22 1:53 ` Bjorn Andersson
2015-01-22 1:53 ` Bjorn Andersson
2015-01-22 16:49 ` Kumar Gala
2015-01-22 16:49 ` Kumar Gala
2015-01-22 16:49 ` Kumar Gala
2015-01-23 1:19 ` Rob Clark
2015-01-23 1:19 ` Rob Clark
2015-01-23 1:19 ` Rob Clark
2014-09-17 22:08 ` [PATCH 0/8] qcom SCM updates Kumar Gala
2014-09-17 22:08 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOesGMh1HE+hMP0VWr2vaHCp2itVjpQeiiFL6r9WeJUFes5tvw@mail.gmail.com \
--to=olof@lixom.net \
--cc=davidb@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=lina.iyer@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.