All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Russell King <rmk+kernel@armlinux.org.uk>,
	Arnd Bergmann <arnd@arndb.de>, Ard Biesheuvel <ardb@kernel.org>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH v4 3/4] ARM: only use -mtp=cp15 for the compiler
Date: Fri, 14 Oct 2022 14:20:02 -0700	[thread overview]
Message-ID: <Y0nSgpfZNPruGPhj@dev-arch.thelio-3990X> (raw)
In-Reply-To: <20221014201354.3190007-4-ndesaulniers@google.com>

On Fri, Oct 14, 2022 at 01:13:53PM -0700, Nick Desaulniers wrote:
> Avoids an error from the assembler for CONFIG_THUMB2 kernels:
> 
> clang-15: error: hardware TLS register is not supported for the thumbv4t
> sub-architecture
> 
> This flag only makes sense to pass to the compiler, not the assembler.
> 
> Perhaps CFLAGS_ABI can be renamed to CPPFLAGS_ABI to reflect that they
> will be passed to both the compiler and assembler for sources that
> require pre-processing.
> 
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> ---
>  arch/arm/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index 8dd943b50b7d..ee888070b2ff 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -111,7 +111,7 @@ CFLAGS_ABI	+= -meabi gnu
>  endif
>  
>  ifeq ($(CONFIG_CURRENT_POINTER_IN_TPIDRURO),y)
> -CFLAGS_ABI	+= -mtp=cp15
> +KBUILD_CFLAGS	+= -mtp=cp15
>  endif
>  
>  # Accept old syntax despite ".syntax unified"
> -- 
> 2.38.0.413.g74048e4d9e-goog
> 

WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <nathan@kernel.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Russell King <rmk+kernel@armlinux.org.uk>,
	Arnd Bergmann <arnd@arndb.de>, Ard Biesheuvel <ardb@kernel.org>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH v4 3/4] ARM: only use -mtp=cp15 for the compiler
Date: Fri, 14 Oct 2022 14:20:02 -0700	[thread overview]
Message-ID: <Y0nSgpfZNPruGPhj@dev-arch.thelio-3990X> (raw)
In-Reply-To: <20221014201354.3190007-4-ndesaulniers@google.com>

On Fri, Oct 14, 2022 at 01:13:53PM -0700, Nick Desaulniers wrote:
> Avoids an error from the assembler for CONFIG_THUMB2 kernels:
> 
> clang-15: error: hardware TLS register is not supported for the thumbv4t
> sub-architecture
> 
> This flag only makes sense to pass to the compiler, not the assembler.
> 
> Perhaps CFLAGS_ABI can be renamed to CPPFLAGS_ABI to reflect that they
> will be passed to both the compiler and assembler for sources that
> require pre-processing.
> 
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> ---
>  arch/arm/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> index 8dd943b50b7d..ee888070b2ff 100644
> --- a/arch/arm/Makefile
> +++ b/arch/arm/Makefile
> @@ -111,7 +111,7 @@ CFLAGS_ABI	+= -meabi gnu
>  endif
>  
>  ifeq ($(CONFIG_CURRENT_POINTER_IN_TPIDRURO),y)
> -CFLAGS_ABI	+= -mtp=cp15
> +KBUILD_CFLAGS	+= -mtp=cp15
>  endif
>  
>  # Accept old syntax despite ".syntax unified"
> -- 
> 2.38.0.413.g74048e4d9e-goog
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-10-14 21:20 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-14 20:13 [PATCH v4 0/4] pass -march= only to compiler Nick Desaulniers
2022-10-14 20:13 ` Nick Desaulniers
2022-10-14 20:13 ` [PATCH v4 1/4] ARM: remove lazy evaluation in Makefile Nick Desaulniers
2022-10-14 20:13   ` Nick Desaulniers
2022-10-14 21:18   ` Nathan Chancellor
2022-10-14 21:18     ` Nathan Chancellor
2022-10-14 20:13 ` [PATCH v4 2/4] ARM: use .arch directives instead of assembler command line flags Nick Desaulniers
2022-10-14 20:13   ` Nick Desaulniers
2022-10-14 21:19   ` Nathan Chancellor
2022-10-14 21:19     ` Nathan Chancellor
2022-11-08 18:30   ` Nathan Chancellor
2022-11-08 18:30     ` Nathan Chancellor
2022-11-08 18:37     ` Russell King (Oracle)
2022-11-08 18:37       ` Russell King (Oracle)
2022-11-08 18:40       ` Nathan Chancellor
2022-11-08 18:40         ` Nathan Chancellor
2022-10-14 20:13 ` [PATCH v4 3/4] ARM: only use -mtp=cp15 for the compiler Nick Desaulniers
2022-10-14 20:13   ` Nick Desaulniers
2022-10-14 21:20   ` Nathan Chancellor [this message]
2022-10-14 21:20     ` Nathan Chancellor
2022-10-14 20:13 ` [PATCH v4 4/4] ARM: pass -march= only to compiler Nick Desaulniers
2022-10-14 20:13   ` Nick Desaulniers
2022-10-14 21:21   ` Nathan Chancellor
2022-10-14 21:21     ` Nathan Chancellor
2022-10-14 20:16 ` [PATCH v4 0/4] " Nick Desaulniers
2022-10-14 20:16   ` Nick Desaulniers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y0nSgpfZNPruGPhj@dev-arch.thelio-3990X \
    --to=nathan@kernel.org \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=masahiroy@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=rmk+kernel@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.