From: Vinod Koul <vkoul@kernel.org> To: Rob Clark <robdclark@gmail.com> Cc: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>, DTML <devicetree@vger.kernel.org>, Jonathan Marek <jonathan@marek.ca>, David Airlie <airlied@linux.ie>, MSM <linux-arm-msm@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>, Abhinav Kumar <abhinavk@codeaurora.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Rob Herring <robh+dt@kernel.org>, "open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>, Daniel Vetter <daniel@ffwll.ch>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, freedreno <freedreno@lists.freedesktop.org> Subject: Re: [Freedreno] [RFC PATCH 00/13] drm/msm: Add Display Stream Compression Support Date: Wed, 2 Jun 2021 16:31:36 +0530 [thread overview] Message-ID: <YLdlEB3Ea6OWaLw4@vkoul-mobl> (raw) In-Reply-To: <CAF6AEGuoyPr8PgfwFX0JCYZ7S_pryn_OXacHBqoMAAPvSq6aRw@mail.gmail.com> On 27-05-21, 16:30, Rob Clark wrote: > On Wed, May 26, 2021 at 8:00 AM Jeffrey Hugo <jeffrey.l.hugo@gmail.com> wrote: > > On Tue, May 25, 2021 at 11:46 PM Vinod Koul <vkoul@kernel.org> wrote: > > Frankly, I don't like the MSM ACPI solution that I've seen on the laptops. > > The ACPI assumes the entire MDSS (including DSI parts) and GPU is one > > device, and ultimately handled by one driver. That driver needs to > > get a value from UEFI (set by the bootloader) that is the "panel id". > > Then the driver calls into ACPI (I think its _ROM, but I might be > > mistaken, doing this from memory) with that id. It gets back a binary > > blob which is mostly an xml file (format is publicly documented) that > > contains the panel timings and such. > > tbh, I kinda suspect that having a single "gpu" device (which also > includes venus, in addition to display, IIRC) in the ACPI tables is a > windowsism, trying to make things look to userspace like a single "GPU > card" in the x86 world.. but either way, I think the ACPI tables on > the windows arm laptops which use dsi->bridge->edp is too much of a > lost cause to even consider here. Possibly ACPI boot on these devices > would be more feasible on newer devices which have direct eDP out of > the SoC without requiring external bridge/panel glue. yeah that is always a very different world. although it might make sense to use information in tables and try to deduce information about the system can be helpful... > I'd worry more about what makes sense in a DT world, when it comes to > DT bindings. And do you have thoughts on that..? -- ~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vkoul@kernel.org> To: Rob Clark <robdclark@gmail.com> Cc: DTML <devicetree@vger.kernel.org>, Jonathan Marek <jonathan@marek.ca>, Jeffrey Hugo <jeffrey.l.hugo@gmail.com>, David Airlie <airlied@linux.ie>, MSM <linux-arm-msm@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>, Abhinav Kumar <abhinavk@codeaurora.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Rob Herring <robh+dt@kernel.org>, "open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, freedreno <freedreno@lists.freedesktop.org> Subject: Re: [Freedreno] [RFC PATCH 00/13] drm/msm: Add Display Stream Compression Support Date: Wed, 2 Jun 2021 16:31:36 +0530 [thread overview] Message-ID: <YLdlEB3Ea6OWaLw4@vkoul-mobl> (raw) In-Reply-To: <CAF6AEGuoyPr8PgfwFX0JCYZ7S_pryn_OXacHBqoMAAPvSq6aRw@mail.gmail.com> On 27-05-21, 16:30, Rob Clark wrote: > On Wed, May 26, 2021 at 8:00 AM Jeffrey Hugo <jeffrey.l.hugo@gmail.com> wrote: > > On Tue, May 25, 2021 at 11:46 PM Vinod Koul <vkoul@kernel.org> wrote: > > Frankly, I don't like the MSM ACPI solution that I've seen on the laptops. > > The ACPI assumes the entire MDSS (including DSI parts) and GPU is one > > device, and ultimately handled by one driver. That driver needs to > > get a value from UEFI (set by the bootloader) that is the "panel id". > > Then the driver calls into ACPI (I think its _ROM, but I might be > > mistaken, doing this from memory) with that id. It gets back a binary > > blob which is mostly an xml file (format is publicly documented) that > > contains the panel timings and such. > > tbh, I kinda suspect that having a single "gpu" device (which also > includes venus, in addition to display, IIRC) in the ACPI tables is a > windowsism, trying to make things look to userspace like a single "GPU > card" in the x86 world.. but either way, I think the ACPI tables on > the windows arm laptops which use dsi->bridge->edp is too much of a > lost cause to even consider here. Possibly ACPI boot on these devices > would be more feasible on newer devices which have direct eDP out of > the SoC without requiring external bridge/panel glue. yeah that is always a very different world. although it might make sense to use information in tables and try to deduce information about the system can be helpful... > I'd worry more about what makes sense in a DT world, when it comes to > DT bindings. And do you have thoughts on that..? -- ~Vinod
next prev parent reply other threads:[~2021-06-02 11:01 UTC|newest] Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-21 12:49 [RFC PATCH 00/13] drm/msm: Add Display Stream Compression Support Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 01/13] drm/dsc: Add dsc pps header init function Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 15:29 ` Daniel Vetter 2021-05-21 15:29 ` Daniel Vetter 2021-05-24 7:26 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 02/13] dt-bindings: msm/dsi: Document Display Stream Compression (DSC) parameters Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 13:18 ` Rob Herring 2021-05-21 13:18 ` Rob Herring 2021-05-21 13:23 ` Vinod Koul 2021-05-21 13:23 ` Vinod Koul 2021-05-21 14:42 ` Bjorn Andersson 2021-05-21 14:42 ` Bjorn Andersson 2021-05-24 7:30 ` Vinod Koul 2021-05-24 7:30 ` Vinod Koul 2021-05-24 15:08 ` Bjorn Andersson 2021-05-24 15:08 ` Bjorn Andersson 2021-05-26 5:32 ` Vinod Koul 2021-05-26 5:32 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 03/13] drm/msm/disp/dpu1: Add support for DSC Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-27 23:49 ` Dmitry Baryshkov 2021-05-27 23:49 ` Dmitry Baryshkov 2021-05-21 12:49 ` [RFC PATCH 03/13] drm/msm/dsi: add support for dsc data Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-27 23:45 ` Dmitry Baryshkov 2021-05-27 23:45 ` Dmitry Baryshkov 2021-06-02 11:06 ` Vinod Koul 2021-06-02 11:06 ` Vinod Koul 2021-05-28 10:29 ` Dmitry Baryshkov 2021-05-28 10:29 ` Dmitry Baryshkov 2021-06-02 11:17 ` Vinod Koul 2021-06-02 11:17 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 04/13] drm/msm/disp/dpu1: Add support for DSC in pingpong block Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 04/13] drm/msm/disp/dpu1: Add support for DSC Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-28 10:31 ` Dmitry Baryshkov 2021-05-28 10:31 ` Dmitry Baryshkov 2021-05-21 12:49 ` [RFC PATCH 05/13] drm/msm/disp/dpu1: Add support for DSC in pingpong block Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 05/13] drm/msm/dsi: add support for dsc data Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 06/13] drm/msm/disp/dpu1: Add DSC support in RM Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-28 10:33 ` Dmitry Baryshkov 2021-05-28 10:33 ` Dmitry Baryshkov 2021-05-21 12:49 ` [RFC PATCH 07/13] drm/msm/disp/dpu1: Add DSC for SDM845 to hw_catalog Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 08/13] drm/msm/disp/dpu1: Add DSC support in hw_ctl Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 09/13] drm/msm/disp/dpu1: Don't use DSC with mode_3d Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-28 10:36 ` Dmitry Baryshkov 2021-05-28 10:36 ` Dmitry Baryshkov 2021-05-21 12:49 ` [RFC PATCH 09/13] drm/msm/disp/dpu1: Dont " Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 10/13] drm/msm/disp/dpu1: Add support for DSC in encoder Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 11/13] drm/msm/disp/dpu1: Add support for DSC in topology Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-28 10:39 ` Dmitry Baryshkov 2021-05-28 10:39 ` Dmitry Baryshkov 2021-05-28 22:23 ` abhinavk 2021-05-28 22:23 ` abhinavk 2021-05-28 22:29 ` Dmitry Baryshkov 2021-05-28 22:29 ` Dmitry Baryshkov 2021-05-21 12:49 ` [RFC PATCH 12/13] drm/msm/dsi: Add support for DSC configuration Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 12:49 ` [RFC PATCH 13/13] drm/msm/dsi: Pass DSC params to drm_panel Vinod Koul 2021-05-21 12:49 ` Vinod Koul 2021-05-21 14:09 ` [Freedreno] [RFC PATCH 00/13] drm/msm: Add Display Stream Compression Support Jeffrey Hugo 2021-05-21 14:09 ` Jeffrey Hugo 2021-05-26 5:46 ` Vinod Koul 2021-05-26 5:46 ` Vinod Koul 2021-05-26 15:00 ` Jeffrey Hugo 2021-05-26 15:00 ` Jeffrey Hugo 2021-05-27 23:30 ` Rob Clark 2021-05-27 23:30 ` Rob Clark 2021-06-02 11:01 ` Vinod Koul [this message] 2021-06-02 11:01 ` Vinod Koul 2021-06-03 23:40 ` abhinavk 2021-06-03 23:40 ` abhinavk 2021-06-17 8:06 ` Vinod Koul 2021-06-17 8:06 ` Vinod Koul 2021-06-04 2:36 ` Rob Clark 2021-06-04 2:36 ` Rob Clark 2021-06-02 10:56 ` Vinod Koul 2021-06-02 10:56 ` Vinod Koul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YLdlEB3Ea6OWaLw4@vkoul-mobl \ --to=vkoul@kernel.org \ --cc=abhinavk@codeaurora.org \ --cc=airlied@linux.ie \ --cc=bjorn.andersson@linaro.org \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=jeffrey.l.hugo@gmail.com \ --cc=jonathan@marek.ca \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robdclark@gmail.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.