All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Douglas Anderson <dianders@chromium.org>
Cc: dri-devel@lists.freedesktop.org, Lyude Paul <lyude@redhat.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Maxime Ripard <maxime@cerno.tech>,
	linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
	Stephen Boyd <swboyd@chromium.org>,
	Robert Foss <robert.foss@linaro.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Hsin-Yi Wang <hsinyi@chromium.org>,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	Imre Deak <imre.deak@intel.com>,
	Jani Nikula <jani.nikula@intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: Document that power requirements for DP AUX transfers
Date: Wed, 4 May 2022 15:21:48 +0300	[thread overview]
Message-ID: <YnJv3B/85hTz54SC@intel.com> (raw)
In-Reply-To: <20220503162033.1.Ia8651894026707e4fa61267da944ff739610d180@changeid>

On Tue, May 03, 2022 at 04:21:08PM -0700, Douglas Anderson wrote:
> When doing DP AUX transfers there are two actors that need to be
> powered in order for the DP AUX transfer to work: the DP source and
> the DP sync. Commit bacbab58f09d ("drm: Mention the power state
> requirement on side-channel operations") added some documentation
> saying that the DP source is required to power itself up (if needed)
> to do AUX transfers. However, that commit doesn't talk anything about
> the DP sink.
> 
> For full fledged DP the sink isn't really a problem. It's expected
> that if an external DP monitor isn't plugged in that attempting to do
> AUX transfers won't work. It's also expected that if a DP monitor is
> plugged in (and thus asserting HPD) that it AUX transfers will work.
> 
> When we're looking at eDP, however, things are less obvious. Let's add
> some documentation about expectations. Here's what we'll say:
> 
> 1. We don't expect the DP AUX transfer function to power on an eDP
> panel. If an eDP panel is physically connected but powered off then it
> makes sense for the transfer to fail.

I don't agree with this. I think the panel should just get powred up
for AUX transfers. Otherwise you can't trust that eg. the /dev/aux
stuff is actually usable.

-- 
Ville Syrjälä
Intel

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Douglas Anderson <dianders@chromium.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Hsin-Yi Wang <hsinyi@chromium.org>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Stephen Boyd <swboyd@chromium.org>,
	Jani Nikula <jani.nikula@intel.com>,
	Maxime Ripard <maxime@cerno.tech>,
	linux-arm-msm@vger.kernel.org,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	freedreno@lists.freedesktop.org,
	Robert Foss <robert.foss@linaro.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] drm: Document that power requirements for DP AUX transfers
Date: Wed, 4 May 2022 15:21:48 +0300	[thread overview]
Message-ID: <YnJv3B/85hTz54SC@intel.com> (raw)
In-Reply-To: <20220503162033.1.Ia8651894026707e4fa61267da944ff739610d180@changeid>

On Tue, May 03, 2022 at 04:21:08PM -0700, Douglas Anderson wrote:
> When doing DP AUX transfers there are two actors that need to be
> powered in order for the DP AUX transfer to work: the DP source and
> the DP sync. Commit bacbab58f09d ("drm: Mention the power state
> requirement on side-channel operations") added some documentation
> saying that the DP source is required to power itself up (if needed)
> to do AUX transfers. However, that commit doesn't talk anything about
> the DP sink.
> 
> For full fledged DP the sink isn't really a problem. It's expected
> that if an external DP monitor isn't plugged in that attempting to do
> AUX transfers won't work. It's also expected that if a DP monitor is
> plugged in (and thus asserting HPD) that it AUX transfers will work.
> 
> When we're looking at eDP, however, things are less obvious. Let's add
> some documentation about expectations. Here's what we'll say:
> 
> 1. We don't expect the DP AUX transfer function to power on an eDP
> panel. If an eDP panel is physically connected but powered off then it
> makes sense for the transfer to fail.

I don't agree with this. I think the panel should just get powred up
for AUX transfers. Otherwise you can't trust that eg. the /dev/aux
stuff is actually usable.

-- 
Ville Syrjälä
Intel

  parent reply	other threads:[~2022-05-04 12:21 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-03 23:21 [PATCH] drm: Document that power requirements for DP AUX transfers Douglas Anderson
2022-05-03 23:21 ` Douglas Anderson
2022-05-04  6:12 ` Dmitry Baryshkov
2022-05-04  6:12   ` Dmitry Baryshkov
2022-05-04 12:21 ` Ville Syrjälä [this message]
2022-05-04 12:21   ` Ville Syrjälä
2022-05-04 16:04   ` Doug Anderson
2022-05-04 16:04     ` Doug Anderson
2022-05-04 18:10     ` Lyude Paul
2022-05-04 18:10       ` Lyude Paul
2022-05-05 14:46       ` Ville Syrjälä
2022-05-05 14:46         ` Ville Syrjälä
2022-05-05 15:00         ` Doug Anderson
2022-05-05 15:00           ` Doug Anderson
2022-05-05 15:08           ` Ville Syrjälä
2022-05-05 15:08             ` Ville Syrjälä
2022-05-05 15:53             ` Doug Anderson
2022-05-05 15:53               ` Doug Anderson
2022-05-05 19:19               ` Ville Syrjälä
2022-05-05 19:19                 ` Ville Syrjälä
2022-05-05 20:12                 ` Doug Anderson
2022-05-05 20:12                   ` Doug Anderson
2022-05-05 20:09               ` Dmitry Baryshkov
2022-05-05 20:09                 ` Dmitry Baryshkov
2022-05-05 20:21                 ` Doug Anderson
2022-05-05 20:21                   ` Doug Anderson
2022-05-05 20:56                   ` Dmitry Baryshkov
2022-05-05 20:56                     ` Dmitry Baryshkov
2022-05-05 21:24                     ` Doug Anderson
2022-05-05 21:24                       ` Doug Anderson
2022-05-05 22:15                       ` Dmitry Baryshkov
2022-05-05 22:15                         ` Dmitry Baryshkov
2022-05-05 22:28                         ` Doug Anderson
2022-05-05 22:28                           ` Doug Anderson
2022-05-05 14:47       ` Doug Anderson
2022-05-05 14:47         ` Doug Anderson
2022-05-05 19:47 ` Lyude Paul
2022-05-05 19:47   ` Lyude Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YnJv3B/85hTz54SC@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=airlied@linux.ie \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel@ffwll.ch \
    --cc=dianders@chromium.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=hsinyi@chromium.org \
    --cc=imre.deak@intel.com \
    --cc=jani.nikula@intel.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lyude@redhat.com \
    --cc=maxime@cerno.tech \
    --cc=robert.foss@linaro.org \
    --cc=swboyd@chromium.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.