All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kirtika Ruchandani <kirtika.ruchandani@gmail.com>
To: Amitkumar Karwar <akarwar@marvell.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Kalle Valo <kvalo@codeaurora.org>,
	linux-wireless@vger.kernel.org,
	Nishant Sarmukadam <nishants@marvell.com>,
	Zhaoyang Liu <liuzy@marvell.com>, Bing Zhao <bzhao@marvell.com>,
	Xinming Hu <huxm@marvell.com>, Avinash Patil <patila@marvell.com>
Subject: [PATCH 3/7] mwifiex: Remove unused 'sta_ptr' variable
Date: Fri, 18 Nov 2016 00:45:16 -0800	[thread overview]
Message-ID: <a061a166bddcf6cc060594512674934ad2979790.1479458373.git.kirtika@google.com> (raw)
In-Reply-To: <cover.1479458373.git.kirtika@google.com>

Commit 429d90d2212b introduced mwifiex_cmd_tdls_oper() which initializes
struct mwifiex_sta_node* sta_ptr, but does not use it. Compiling with W=1 gives
the following warning, fix it.
mwifiex/sta_cmd.c: In function ‘mwifiex_cmd_tdls_oper’:
mwifiex/sta_cmd.c:1732:27: warning: variable ‘sta_ptr’ set but not used [-Wunused-but-set-variable]

Fixes: 429d90d2212b ("mwifiex: add cfg80211 tdls_oper handler support")
Cc: Avinash Patil <patila@marvell.com>
Signed-off-by: Kirtika Ruchandani <kirtika@google.com>
---
 drivers/net/wireless/marvell/mwifiex/sta_cmd.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c b/drivers/net/wireless/marvell/mwifiex/sta_cmd.c
index 2a162c3..d5aa1b7 100644
--- a/drivers/net/wireless/marvell/mwifiex/sta_cmd.c
+++ b/drivers/net/wireless/marvell/mwifiex/sta_cmd.c
@@ -1729,7 +1729,6 @@ mwifiex_cmd_tdls_oper(struct mwifiex_private *priv,
 {
 	struct host_cmd_ds_tdls_oper *tdls_oper = &cmd->params.tdls_oper;
 	struct mwifiex_ds_tdls_oper *oper = data_buf;
-	struct mwifiex_sta_node *sta_ptr;
 	struct host_cmd_tlv_rates *tlv_rates;
 	struct mwifiex_ie_types_htcap *ht_capab;
 	struct mwifiex_ie_types_qos_info *wmm_qos_info;
@@ -1747,7 +1746,6 @@ mwifiex_cmd_tdls_oper(struct mwifiex_private *priv,

 	tdls_oper->reason = 0;
 	memcpy(tdls_oper->peer_mac, oper->peer_mac, ETH_ALEN);
-	sta_ptr = mwifiex_get_sta_entry(priv, oper->peer_mac);

 	pos = (u8 *)tdls_oper + sizeof(struct host_cmd_ds_tdls_oper);

--
2.8.0.rc3.226.g39d4020

  parent reply	other threads:[~2016-11-18  8:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-18  8:43 [PATCH 0/7] Fix -Wunused-but-set-variable in mwifiex/ Kirtika Ruchandani
2016-11-18  8:44 ` [PATCH 1/7] mwifiex: Removed unused mwifiex_private* 'priv' variable Kirtika Ruchandani
2016-11-23 15:36   ` [1/7] " Kalle Valo
2016-11-18  8:44 ` [PATCH 2/7] mwifiex: Remove unused 'chan_num' variable Kirtika Ruchandani
2016-11-18  8:45 ` Kirtika Ruchandani [this message]
2016-11-18  8:45 ` [PATCH 4/7] mwifiex: Remove unused 'adapter'variable Kirtika Ruchandani
2016-11-18  8:45 ` [PATCH 5/7] mwifiex: Remove unused 'pm_flag' variable Kirtika Ruchandani
2016-11-18  8:46 ` [PATCH 6/7] mwifiex: Removed unused 'pkt_type' variable Kirtika Ruchandani
2016-11-18  8:46 ` [PATCH 7/7] mwifiex: Remove unused 'bcd_usb' variable Kirtika Ruchandani
2016-11-18  8:49 ` [PATCH 0/7] Fix -Wunused-but-set-variable in mwifiex/ Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a061a166bddcf6cc060594512674934ad2979790.1479458373.git.kirtika@google.com \
    --to=kirtika.ruchandani@gmail.com \
    --cc=akarwar@marvell.com \
    --cc=arnd@arndb.de \
    --cc=bzhao@marvell.com \
    --cc=huxm@marvell.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=liuzy@marvell.com \
    --cc=nishants@marvell.com \
    --cc=patila@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.