All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kirtika Ruchandani <kirtika.ruchandani@gmail.com>
To: Amitkumar Karwar <akarwar@marvell.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Kalle Valo <kvalo@codeaurora.org>,
	linux-wireless@vger.kernel.org,
	Nishant Sarmukadam <nishants@marvell.com>,
	Zhaoyang Liu <liuzy@marvell.com>, Bing Zhao <bzhao@marvell.com>,
	Xinming Hu <huxm@marvell.com>, Avinash Patil <patila@marvell.com>
Subject: [PATCH 7/7] mwifiex: Remove unused 'bcd_usb' variable
Date: Fri, 18 Nov 2016 00:46:25 -0800	[thread overview]
Message-ID: <eb22a169bcb478a8221d9c78f6335a11520fd336.1479458374.git.kirtika@google.com> (raw)
In-Reply-To: <cover.1479458373.git.kirtika@google.com>

mwifiex_usb_probe() defines and sets bcd_usb but does not use it,
Compiling with W=1 gives the following warning, fix it.
mwifiex/usb.c: In function ‘mwifiex_usb_probe’:
mwifiex/usb.c:383:41: warning: variable ‘bcd_usb’ set but not used [-Wunused-but-set-variable]

The unused variable seems to be present since 4daffe354366 which introduced
mwifiex_usb_probe().

Fixes: 4daffe354366 ("mwifiex: add support for Marvell USB8797 chipset")
Cc: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Kirtika Ruchandani <kirtika@google.com>
---
 drivers/net/wireless/marvell/mwifiex/usb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/usb.c b/drivers/net/wireless/marvell/mwifiex/usb.c
index 73eb084..67a15c1 100644
--- a/drivers/net/wireless/marvell/mwifiex/usb.c
+++ b/drivers/net/wireless/marvell/mwifiex/usb.c
@@ -380,7 +380,7 @@ static int mwifiex_usb_probe(struct usb_interface *intf,
 	struct usb_endpoint_descriptor *epd;
 	int ret, i;
 	struct usb_card_rec *card;
-	u16 id_vendor, id_product, bcd_device, bcd_usb;
+	u16 id_vendor, id_product, bcd_device;

 	card = kzalloc(sizeof(struct usb_card_rec), GFP_KERNEL);
 	if (!card)
@@ -389,7 +389,6 @@ static int mwifiex_usb_probe(struct usb_interface *intf,
 	id_vendor = le16_to_cpu(udev->descriptor.idVendor);
 	id_product = le16_to_cpu(udev->descriptor.idProduct);
 	bcd_device = le16_to_cpu(udev->descriptor.bcdDevice);
-	bcd_usb = le16_to_cpu(udev->descriptor.bcdUSB);
 	pr_debug("info: VID/PID = %X/%X, Boot2 version = %X\n",
 		 id_vendor, id_product, bcd_device);

--
2.8.0.rc3.226.g39d4020

  parent reply	other threads:[~2016-11-18  8:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-18  8:43 [PATCH 0/7] Fix -Wunused-but-set-variable in mwifiex/ Kirtika Ruchandani
2016-11-18  8:44 ` [PATCH 1/7] mwifiex: Removed unused mwifiex_private* 'priv' variable Kirtika Ruchandani
2016-11-23 15:36   ` [1/7] " Kalle Valo
2016-11-18  8:44 ` [PATCH 2/7] mwifiex: Remove unused 'chan_num' variable Kirtika Ruchandani
2016-11-18  8:45 ` [PATCH 3/7] mwifiex: Remove unused 'sta_ptr' variable Kirtika Ruchandani
2016-11-18  8:45 ` [PATCH 4/7] mwifiex: Remove unused 'adapter'variable Kirtika Ruchandani
2016-11-18  8:45 ` [PATCH 5/7] mwifiex: Remove unused 'pm_flag' variable Kirtika Ruchandani
2016-11-18  8:46 ` [PATCH 6/7] mwifiex: Removed unused 'pkt_type' variable Kirtika Ruchandani
2016-11-18  8:46 ` Kirtika Ruchandani [this message]
2016-11-18  8:49 ` [PATCH 0/7] Fix -Wunused-but-set-variable in mwifiex/ Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb22a169bcb478a8221d9c78f6335a11520fd336.1479458374.git.kirtika@google.com \
    --to=kirtika.ruchandani@gmail.com \
    --cc=akarwar@marvell.com \
    --cc=arnd@arndb.de \
    --cc=bzhao@marvell.com \
    --cc=huxm@marvell.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=liuzy@marvell.com \
    --cc=nishants@marvell.com \
    --cc=patila@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.