All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kirtika Ruchandani <kirtika.ruchandani@gmail.com>
To: Amitkumar Karwar <akarwar@marvell.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Kalle Valo <kvalo@codeaurora.org>,
	linux-wireless@vger.kernel.org,
	Nishant Sarmukadam <nishants@marvell.com>,
	Zhaoyang Liu <liuzy@marvell.com>, Bing Zhao <bzhao@marvell.com>,
	Xinming Hu <huxm@marvell.com>, Avinash Patil <patila@marvell.com>
Subject: [PATCH 6/7] mwifiex: Removed unused 'pkt_type' variable
Date: Fri, 18 Nov 2016 00:46:10 -0800	[thread overview]
Message-ID: <fa5eed2d3171b9bca520d925c77830206a1528a2.1479458374.git.kirtika@google.com> (raw)
In-Reply-To: <cover.1479458373.git.kirtika@google.com>

Commit 92263a841b15 introduced mwifiex_deaggr_sdio_pkt which initializes
variable pkt_type but does not use it. Compiling with W=1 gives the following
warning, fix it.
mwifiex/sdio.c: In function ‘mwifiex_deaggr_sdio_pkt’:
mwifiex/sdio.c:1198:6: warning: variable ‘pkt_type’ set but not used [-Wunused-but-set-variable]

Fixes: 92263a841b15 ("mwifiex: add SDIO rx single port aggregation")
Cc: Zhaoyang Liu <liuzy@marvell.com>
Cc: Amitkumar Karwar <akarwar@marvell.com>
Signed-off-by: Kirtika Ruchandani <kirtika@google.com>
---
 drivers/net/wireless/marvell/mwifiex/sdio.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.c b/drivers/net/wireless/marvell/mwifiex/sdio.c
index 41ec59d7..4028a8c 100644
--- a/drivers/net/wireless/marvell/mwifiex/sdio.c
+++ b/drivers/net/wireless/marvell/mwifiex/sdio.c
@@ -1193,7 +1193,6 @@ static void mwifiex_deaggr_sdio_pkt(struct mwifiex_adapter *adapter,
 {
 	u32 total_pkt_len, pkt_len;
 	struct sk_buff *skb_deaggr;
-	u32 pkt_type;
 	u16 blk_size;
 	u8 blk_num;
 	u8 *data;
@@ -1214,8 +1213,6 @@ static void mwifiex_deaggr_sdio_pkt(struct mwifiex_adapter *adapter,
 			break;
 		}
 		pkt_len = le16_to_cpu(*(__le16 *)(data + SDIO_HEADER_OFFSET));
-		pkt_type = le16_to_cpu(*(__le16 *)(data + SDIO_HEADER_OFFSET +
-					 2));
 		if ((pkt_len + SDIO_HEADER_OFFSET) > blk_size) {
 			mwifiex_dbg(adapter, ERROR,
 				    "%s: error in pkt_len,\t"
--
2.8.0.rc3.226.g39d4020

  parent reply	other threads:[~2016-11-18  8:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-18  8:43 [PATCH 0/7] Fix -Wunused-but-set-variable in mwifiex/ Kirtika Ruchandani
2016-11-18  8:44 ` [PATCH 1/7] mwifiex: Removed unused mwifiex_private* 'priv' variable Kirtika Ruchandani
2016-11-23 15:36   ` [1/7] " Kalle Valo
2016-11-18  8:44 ` [PATCH 2/7] mwifiex: Remove unused 'chan_num' variable Kirtika Ruchandani
2016-11-18  8:45 ` [PATCH 3/7] mwifiex: Remove unused 'sta_ptr' variable Kirtika Ruchandani
2016-11-18  8:45 ` [PATCH 4/7] mwifiex: Remove unused 'adapter'variable Kirtika Ruchandani
2016-11-18  8:45 ` [PATCH 5/7] mwifiex: Remove unused 'pm_flag' variable Kirtika Ruchandani
2016-11-18  8:46 ` Kirtika Ruchandani [this message]
2016-11-18  8:46 ` [PATCH 7/7] mwifiex: Remove unused 'bcd_usb' variable Kirtika Ruchandani
2016-11-18  8:49 ` [PATCH 0/7] Fix -Wunused-but-set-variable in mwifiex/ Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa5eed2d3171b9bca520d925c77830206a1528a2.1479458374.git.kirtika@google.com \
    --to=kirtika.ruchandani@gmail.com \
    --cc=akarwar@marvell.com \
    --cc=arnd@arndb.de \
    --cc=bzhao@marvell.com \
    --cc=huxm@marvell.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=liuzy@marvell.com \
    --cc=nishants@marvell.com \
    --cc=patila@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.