From: Christophe Leroy <christophe.leroy@c-s.fr> To: afzal mohammed <afzal.mohd.ma@gmail.com>, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: Scott Wood <oss@buserror.net>, Paul Mackerras <paulus@samba.org>, Thomas Gleixner <tglx@linutronix.de> Subject: Re: [PATCH 10/18] powerpc: Replace setup_irq() by request_irq() Date: Thu, 13 Feb 2020 11:59:35 +0100 [thread overview] Message-ID: <a4f2ad65-0634-f825-b0b7-7e4cd2dc697f@c-s.fr> (raw) In-Reply-To: <303393f75ede6d36241d41f501d9ad2a23897c3f.1581478324.git.afzal.mohd.ma@gmail.com> Le 12/02/2020 à 09:04, afzal mohammed a écrit : > request_irq() is preferred over setup_irq(). Existing callers of > setup_irq() reached mostly via 'init_IRQ()' & 'time_init()', while > memory allocators are ready by 'mm_init()'. > > Per tglx[1], setup_irq() existed in olden days when allocators were not > ready by the time early interrupts were initialized. > > Hence replace setup_irq() by request_irq(). > > Seldom remove_irq() usage has been observed coupled with setup_irq(), > wherever that has been found, it too has been replaced by free_irq(). > > [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos > > Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com> Tested-by: Christophe Leroy <christophe.leroy@c-s.fr> # for the 8xx parts > --- > > Since cc'ing cover letter to all maintainers/reviewers would be too > many, refer for cover letter, > https://lkml.kernel.org/r/cover.1581478323.git.afzal.mohd.ma@gmail.com > > arch/powerpc/platforms/85xx/mpc85xx_cds.c | 10 +++----- > arch/powerpc/platforms/8xx/cpm1.c | 9 ++----- > arch/powerpc/platforms/8xx/m8xx_setup.c | 9 ++----- > arch/powerpc/platforms/chrp/setup.c | 14 ++++------ > arch/powerpc/platforms/powermac/pic.c | 31 ++++++++++------------- > arch/powerpc/platforms/powermac/smp.c | 9 ++----- > 6 files changed, 27 insertions(+), 55 deletions(-) >
WARNING: multiple messages have this Message-ID (diff)
From: Christophe Leroy <christophe.leroy@c-s.fr> To: afzal mohammed <afzal.mohd.ma@gmail.com>, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Cc: Scott Wood <oss@buserror.net>, Thomas Gleixner <tglx@linutronix.de>, Paul Mackerras <paulus@samba.org> Subject: Re: [PATCH 10/18] powerpc: Replace setup_irq() by request_irq() Date: Thu, 13 Feb 2020 11:59:35 +0100 [thread overview] Message-ID: <a4f2ad65-0634-f825-b0b7-7e4cd2dc697f@c-s.fr> (raw) In-Reply-To: <303393f75ede6d36241d41f501d9ad2a23897c3f.1581478324.git.afzal.mohd.ma@gmail.com> Le 12/02/2020 à 09:04, afzal mohammed a écrit : > request_irq() is preferred over setup_irq(). Existing callers of > setup_irq() reached mostly via 'init_IRQ()' & 'time_init()', while > memory allocators are ready by 'mm_init()'. > > Per tglx[1], setup_irq() existed in olden days when allocators were not > ready by the time early interrupts were initialized. > > Hence replace setup_irq() by request_irq(). > > Seldom remove_irq() usage has been observed coupled with setup_irq(), > wherever that has been found, it too has been replaced by free_irq(). > > [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos > > Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com> Tested-by: Christophe Leroy <christophe.leroy@c-s.fr> # for the 8xx parts > --- > > Since cc'ing cover letter to all maintainers/reviewers would be too > many, refer for cover letter, > https://lkml.kernel.org/r/cover.1581478323.git.afzal.mohd.ma@gmail.com > > arch/powerpc/platforms/85xx/mpc85xx_cds.c | 10 +++----- > arch/powerpc/platforms/8xx/cpm1.c | 9 ++----- > arch/powerpc/platforms/8xx/m8xx_setup.c | 9 ++----- > arch/powerpc/platforms/chrp/setup.c | 14 ++++------ > arch/powerpc/platforms/powermac/pic.c | 31 ++++++++++------------- > arch/powerpc/platforms/powermac/smp.c | 9 ++----- > 6 files changed, 27 insertions(+), 55 deletions(-) >
next prev parent reply other threads:[~2020-02-13 10:59 UTC|newest] Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-12 8:01 [PATCH 00/18] genirq: Remove setup_irq() afzal mohammed 2020-02-12 8:13 ` afzal mohammed 2020-02-12 8:01 ` afzal mohammed 2020-02-12 8:01 ` afzal mohammed 2020-02-12 8:02 ` [PATCH 01/18] alpha: replace setup_irq() by request_irq() afzal mohammed 2020-02-12 8:02 ` [PATCH 02/18] ARM: " afzal mohammed 2020-02-12 8:02 ` afzal mohammed 2020-02-12 8:10 ` Viresh Kumar 2020-02-12 8:10 ` Viresh Kumar 2020-02-12 8:10 ` Viresh Kumar 2020-02-12 23:27 ` Alexander Sverdlin 2020-02-12 23:27 ` Alexander Sverdlin 2020-02-12 23:27 ` Alexander Sverdlin 2020-02-12 8:02 ` [PATCH 03/18] c6x: " afzal mohammed 2020-02-13 17:37 ` Mark Salter 2020-02-12 8:03 ` [PATCH 04/18] hexagon: " afzal mohammed 2020-02-12 8:03 ` [PATCH 05/18] ia64: " afzal mohammed 2020-02-12 8:15 ` afzal mohammed 2020-02-12 8:03 ` [PATCH 06/18] m68k: Replace " afzal mohammed 2020-02-12 22:25 ` Finn Thain 2020-02-13 2:03 ` afzal mohammed 2020-02-13 7:11 ` Greg Ungerer 2020-02-14 13:07 ` afzal mohammed 2020-02-12 8:03 ` [PATCH 07/18] microblaze: " afzal mohammed 2020-02-12 8:04 ` [PATCH 08/18] MIPS: " afzal mohammed 2020-02-12 8:04 ` afzal mohammed 2020-02-12 8:04 ` [PATCH 09/18] parisc: " afzal mohammed 2020-02-12 8:04 ` [PATCH 10/18] powerpc: " afzal mohammed 2020-02-12 8:04 ` afzal mohammed 2020-02-13 10:59 ` Christophe Leroy [this message] 2020-02-13 10:59 ` Christophe Leroy 2020-02-12 8:04 ` [PATCH 11/18] s390: replace " afzal mohammed 2020-02-12 8:04 ` [PATCH 12/18] sh: " afzal mohammed 2020-02-12 8:16 ` afzal mohammed 2020-02-12 8:05 ` [PATCH 13/18] unicore32: " afzal mohammed 2020-02-12 8:05 ` [PATCH 14/18] x86: Replace " afzal mohammed 2020-02-27 10:49 ` Thomas Gleixner 2020-02-27 11:36 ` afzal mohammed 2020-02-27 13:29 ` Thomas Gleixner 2020-02-27 14:26 ` afzal mohammed 2020-02-12 8:05 ` [PATCH 15/18] xtensa: replace " afzal mohammed 2020-02-12 9:10 ` Max Filippov 2020-02-12 8:05 ` [PATCH 16/18] clocksource: Replace " afzal mohammed 2020-02-12 8:05 ` afzal mohammed 2020-02-12 8:05 ` afzal mohammed 2020-02-20 11:13 ` Daniel Lezcano 2020-02-20 11:13 ` Daniel Lezcano 2020-02-20 11:13 ` Daniel Lezcano 2020-02-20 14:48 ` Linus Walleij 2020-02-20 14:48 ` Linus Walleij 2020-02-20 14:48 ` Linus Walleij 2020-02-12 8:05 ` [PATCH 17/18] irqchip: " afzal mohammed [not found] ` <8e00874d072f32496c2d0da05423bda1cadd6975.1581478324.git.afzal.mohd.ma@gmail. com> 2020-02-13 16:02 ` Paul Cercueil 2020-02-12 8:06 ` [PATCH 18/18] genirq: Remove setup_irq() and remove_irq() afzal mohammed 2020-02-20 14:49 ` Linus Walleij 2020-02-27 10:31 ` [PATCH 00/18] genirq: Remove setup_irq() Thomas Gleixner 2020-02-27 10:31 ` Thomas Gleixner 2020-02-27 10:31 ` Thomas Gleixner 2020-02-27 10:31 ` Thomas Gleixner 2020-02-27 11:07 ` afzal mohammed 2020-02-27 11:19 ` afzal mohammed 2020-02-27 11:07 ` afzal mohammed 2020-02-27 11:07 ` afzal mohammed 2020-03-21 17:43 ` afzal mohammed 2020-03-21 17:55 ` afzal mohammed 2020-03-21 17:43 ` afzal mohammed 2020-03-21 17:43 ` afzal mohammed 2020-03-27 16:08 ` [PATCH 0/6] Kill setup_irq() afzal mohammed 2020-03-27 16:20 ` afzal mohammed 2020-03-27 16:08 ` afzal mohammed 2020-03-27 16:08 ` afzal mohammed 2020-03-27 16:09 ` [PATCH v5 1/6] alpha: Replace setup_irq() by request_irq() afzal mohammed 2020-03-27 16:09 ` [PATCH v5 2/6] c6x: replace " afzal mohammed 2020-03-27 16:09 ` [PATCH v5 3/6] hexagon: " afzal mohammed 2020-03-27 16:10 ` [PATCH v5 4/6] sh: " afzal mohammed 2020-03-27 16:22 ` afzal mohammed 2020-03-27 16:10 ` [PATCH v5 5/6] unicore32: " afzal mohammed 2020-03-27 16:11 ` [PATCH v5 6/6] genirq: Remove setup_irq() and remove_irq() afzal mohammed 2020-04-11 14:10 ` afzal mohammed 2020-03-28 2:48 ` [PATCH 0/6] Kill setup_irq() Brian Cain 2020-03-28 2:48 ` Brian Cain 2020-03-28 2:48 ` Brian Cain 2020-03-28 2:48 ` Brian Cain 2020-03-28 2:48 ` Brian Cain 2020-03-28 7:32 ` afzal mohammed 2020-03-28 7:44 ` afzal mohammed 2020-03-28 7:32 ` afzal mohammed 2020-03-28 7:32 ` afzal mohammed 2020-04-02 15:03 ` Brian Cain 2020-04-02 15:03 ` Brian Cain 2020-04-02 15:03 ` Brian Cain 2020-04-02 15:03 ` Brian Cain 2020-04-02 15:03 ` Brian Cain
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a4f2ad65-0634-f825-b0b7-7e4cd2dc697f@c-s.fr \ --to=christophe.leroy@c-s.fr \ --cc=afzal.mohd.ma@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=oss@buserror.net \ --cc=paulus@samba.org \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.