From: Piotr Bugalski <bugalski.piotr@gmail.com> To: Boris Brezillon <boris.brezillon@bootlin.com> Cc: Piotr Bugalski <bugalski.piotr@gmail.com>, Mark Brown <broonie@kernel.org>, linux-spi@vger.kernel.org, David Woodhouse <dwmw2@infradead.org>, Brian Norris <computersforpeace@gmail.com>, Marek Vasut <marek.vasut@gmail.com>, Richard Weinberger <richard@nod.at>, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Nicolas Ferre <nicolas.ferre@microchip.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Cyrille Pitchen <cyrille.pitchen@microchip.com>, Tudor Ambarus <tudor.ambarus@microchip.com>, Piotr Bugalski <pbu@cryptera.com> Subject: Re: [RFC PATCH 2/2] dt-bindings: spi: QuadSPI driver for Atmel SAMA5D2 documentation Date: Thu, 21 Jun 2018 12:56:50 +0200 (CEST) [thread overview] Message-ID: <alpine.DEB.2.20.1806211252390.28763@carbonite> (raw) In-Reply-To: <20180620164741.2a8da424@bbrezillon> Hi Boris, On Wed, 20 Jun 2018, Boris Brezillon wrote: > Hi Piotr, > > On Mon, 18 Jun 2018 18:21:24 +0200 > Piotr Bugalski <bugalski.piotr@gmail.com> wrote: > >> Documentation for DT-binding change. >> >> Suggested-by: Boris Brezillon <boris.brezillon@bootlin.com> > > I'm pretty sure I didn't make a single suggestion about the DT > bindings you use here ;-). > Ok, I misunderstood a bit your idea, but I think from next release this field will be in good place. So it was just prepared for the future ;-) >> Signed-off-by: Piotr Bugalski <pbu@cryptera.com> >> >> --- >> .../devicetree/bindings/spi/spi_atmel-qspi.txt | 41 ++++++++++++++++++++++ >> 1 file changed, 41 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/spi/spi_atmel-qspi.txt > > I'll comment on this aspect in more details when replying to the cover > letter, but I think you should re-use the bindings defined in > Documentation/devicetree/bindings/mtd/atmel-quadspi.txt (IOW, move the > existing file to the Documentation/devicetree/bindings/spi directory). > > It's the same HW block, and just because you develop a new driver to > replace the old one doesn't mean you should have 2 different bindings in > parallel. I'll change it in next version. > >> >> diff --git a/Documentation/devicetree/bindings/spi/spi_atmel-qspi.txt b/Documentation/devicetree/bindings/spi/spi_atmel-qspi.txt >> new file mode 100644 >> index 000000000000..d52b534c9c2b >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/spi/spi_atmel-qspi.txt >> @@ -0,0 +1,41 @@ >> +* Atmel Quad Serial Peripheral Interface (QSPI) >> + >> +Required properties: >> +- compatible: Should be "atmel,sama5d2-spi-qspi". >> +- reg: Should contain the locations and lengths of the base registers >> + and the mapped memory. >> +- reg-names: Should contain the resource reg names: >> + - qspi_base: configuration register address space >> + - qspi_mmap: memory mapped address space >> +- interrupts: Should contain the interrupt for the device. >> +- clocks: The phandle of the clock needed by the QSPI controller. >> +- #address-cells: Should be <1>. >> +- #size-cells: Should be <0>. >> + >> +Example: >> + >> +qspi1: spi@f0024000 { >> + compatible = "atmel,sama5d2-spi-qspi"; >> + reg = <0xf0024000 0x100>, <0xd8000000 0x08000000>; >> + reg-names = "qspi_base", "qspi_mmap"; >> + interrupts = <53 IRQ_TYPE_LEVEL_HIGH 7>; >> + clocks = <&qspi1_clk>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_qspi1_default>; >> + status = "okay"; >> + >> + flash@0 { >> + #address-cells = <1>; >> + #size-cells = <1>; >> + compatible = "winbond,w25m02gv", "spi-nand"; > > "winbond,w25m02gv" is undocumented and unnecessary since SPI NANDs are > automatically detected. Also, maybe you should declare a SPI NOR in the > example since SPI NAND support has not yet been merged. > I was mainly focusing on NAND-flash with QSPI inteface so I took example from tested configuration. Next time I'll use NOR-flash. >> + reg = <0>; >> + spi-max-frequency = <83000000>; >> + spi-rx-bus-width = <4>; >> + spi-tx-bus-width = <4>; >> + >> + ... >> + }; >> +}; >> + > > Regards, > > Boris > Thanks, Piotr
WARNING: multiple messages have this Message-ID (diff)
From: bugalski.piotr@gmail.com (Piotr Bugalski) To: linux-arm-kernel@lists.infradead.org Subject: [RFC PATCH 2/2] dt-bindings: spi: QuadSPI driver for Atmel SAMA5D2 documentation Date: Thu, 21 Jun 2018 12:56:50 +0200 (CEST) [thread overview] Message-ID: <alpine.DEB.2.20.1806211252390.28763@carbonite> (raw) In-Reply-To: <20180620164741.2a8da424@bbrezillon> Hi Boris, On Wed, 20 Jun 2018, Boris Brezillon wrote: > Hi Piotr, > > On Mon, 18 Jun 2018 18:21:24 +0200 > Piotr Bugalski <bugalski.piotr@gmail.com> wrote: > >> Documentation for DT-binding change. >> >> Suggested-by: Boris Brezillon <boris.brezillon@bootlin.com> > > I'm pretty sure I didn't make a single suggestion about the DT > bindings you use here ;-). > Ok, I misunderstood a bit your idea, but I think from next release this field will be in good place. So it was just prepared for the future ;-) >> Signed-off-by: Piotr Bugalski <pbu@cryptera.com> >> >> --- >> .../devicetree/bindings/spi/spi_atmel-qspi.txt | 41 ++++++++++++++++++++++ >> 1 file changed, 41 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/spi/spi_atmel-qspi.txt > > I'll comment on this aspect in more details when replying to the cover > letter, but I think you should re-use the bindings defined in > Documentation/devicetree/bindings/mtd/atmel-quadspi.txt (IOW, move the > existing file to the Documentation/devicetree/bindings/spi directory). > > It's the same HW block, and just because you develop a new driver to > replace the old one doesn't mean you should have 2 different bindings in > parallel. I'll change it in next version. > >> >> diff --git a/Documentation/devicetree/bindings/spi/spi_atmel-qspi.txt b/Documentation/devicetree/bindings/spi/spi_atmel-qspi.txt >> new file mode 100644 >> index 000000000000..d52b534c9c2b >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/spi/spi_atmel-qspi.txt >> @@ -0,0 +1,41 @@ >> +* Atmel Quad Serial Peripheral Interface (QSPI) >> + >> +Required properties: >> +- compatible: Should be "atmel,sama5d2-spi-qspi". >> +- reg: Should contain the locations and lengths of the base registers >> + and the mapped memory. >> +- reg-names: Should contain the resource reg names: >> + - qspi_base: configuration register address space >> + - qspi_mmap: memory mapped address space >> +- interrupts: Should contain the interrupt for the device. >> +- clocks: The phandle of the clock needed by the QSPI controller. >> +- #address-cells: Should be <1>. >> +- #size-cells: Should be <0>. >> + >> +Example: >> + >> +qspi1: spi at f0024000 { >> + compatible = "atmel,sama5d2-spi-qspi"; >> + reg = <0xf0024000 0x100>, <0xd8000000 0x08000000>; >> + reg-names = "qspi_base", "qspi_mmap"; >> + interrupts = <53 IRQ_TYPE_LEVEL_HIGH 7>; >> + clocks = <&qspi1_clk>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_qspi1_default>; >> + status = "okay"; >> + >> + flash at 0 { >> + #address-cells = <1>; >> + #size-cells = <1>; >> + compatible = "winbond,w25m02gv", "spi-nand"; > > "winbond,w25m02gv" is undocumented and unnecessary since SPI NANDs are > automatically detected. Also, maybe you should declare a SPI NOR in the > example since SPI NAND support has not yet been merged. > I was mainly focusing on NAND-flash with QSPI inteface so I took example from tested configuration. Next time I'll use NOR-flash. >> + reg = <0>; >> + spi-max-frequency = <83000000>; >> + spi-rx-bus-width = <4>; >> + spi-tx-bus-width = <4>; >> + >> + ... >> + }; >> +}; >> + > > Regards, > > Boris > Thanks, Piotr
next prev parent reply other threads:[~2018-06-21 10:56 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-06-18 16:21 [RFC PATCH 0/2] New QuadSPI driver for Atmel SAMA5D2 Piotr Bugalski 2018-06-18 16:21 ` Piotr Bugalski 2018-06-18 16:21 ` [RFC PATCH 1/2] spi: Add " Piotr Bugalski 2018-06-18 16:21 ` Piotr Bugalski 2018-06-19 15:15 ` Mark Brown 2018-06-19 15:15 ` Mark Brown 2018-06-20 14:31 ` Piotr Bugalski 2018-06-20 14:31 ` Piotr Bugalski 2018-06-21 21:33 ` Boris Brezillon 2018-06-21 21:33 ` Boris Brezillon 2018-06-22 5:57 ` Piotr Bugalski 2018-06-22 5:57 ` Piotr Bugalski 2018-06-22 7:39 ` Boris Brezillon 2018-06-22 7:39 ` Boris Brezillon 2018-06-26 14:44 ` Tudor Ambarus 2018-06-26 14:44 ` Tudor Ambarus 2018-06-26 14:44 ` Tudor Ambarus 2018-06-27 7:52 ` Piotr Bugalski 2018-06-27 7:52 ` Piotr Bugalski 2018-06-28 8:37 ` Tudor Ambarus 2018-06-28 8:37 ` Tudor Ambarus 2018-06-28 8:37 ` Tudor Ambarus 2018-06-28 12:02 ` Piotr Bugalski 2018-06-28 12:02 ` Piotr Bugalski 2018-06-18 16:21 ` [RFC PATCH 2/2] dt-bindings: spi: QuadSPI driver for Atmel SAMA5D2 documentation Piotr Bugalski 2018-06-18 16:21 ` Piotr Bugalski 2018-06-20 14:47 ` Boris Brezillon 2018-06-20 14:47 ` Boris Brezillon 2018-06-21 10:56 ` Piotr Bugalski [this message] 2018-06-21 10:56 ` Piotr Bugalski 2018-06-20 14:54 ` [RFC PATCH 0/2] New QuadSPI driver for Atmel SAMA5D2 Boris Brezillon 2018-06-20 14:54 ` Boris Brezillon 2018-06-21 10:52 ` Piotr Bugalski 2018-06-21 10:52 ` Piotr Bugalski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.DEB.2.20.1806211252390.28763@carbonite \ --to=bugalski.piotr@gmail.com \ --cc=alexandre.belloni@bootlin.com \ --cc=boris.brezillon@bootlin.com \ --cc=broonie@kernel.org \ --cc=computersforpeace@gmail.com \ --cc=cyrille.pitchen@microchip.com \ --cc=devicetree@vger.kernel.org \ --cc=dwmw2@infradead.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=marek.vasut@gmail.com \ --cc=mark.rutland@arm.com \ --cc=nicolas.ferre@microchip.com \ --cc=pbu@cryptera.com \ --cc=richard@nod.at \ --cc=robh+dt@kernel.org \ --cc=tudor.ambarus@microchip.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.