From: Finn Thain <fthain@telegraphics.com.au> To: Markus Elfring <Markus.Elfring@web.de> Cc: Christophe Jaillet <christophe.jaillet@wanadoo.fr>, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org> Subject: Re: net/sonic: Fix some resource leaks in error handling paths Date: Mon, 11 May 2020 10:28:34 +1000 (AEST) [thread overview] Message-ID: <alpine.LNX.2.22.394.2005110845060.8@nippy.intranet> (raw) In-Reply-To: <bc70e24c-dd31-75b7-6ece-2ad31982641e@web.de> [-- Attachment #1: Type: text/plain, Size: 2151 bytes --] On Sun, 10 May 2020, Markus Elfring wrote: > > > > Do you know when these bugs were introduced? > > I suggest to take another look at a provided tag “Fixes”. If you can't determine when the bug was introduced, how can you criticise a patch for the lack of a Fixes tag? > To which commit would you like to refer to for the proposed adjustment > of the function “mac_sonic_platform_probe”? > That was my question to you. We seem to be talking past each other. Unforunately I only speak English, so if this misunderstanding is to be resolved, you're going to have to try harder to make yourself understood. > > Naming goto labels is just painting another bikeshed. Yes, some > > alternatives are preferable but it takes too long to identify them and > > finding consensus is unlikely anyway, as it's a matter of taste. > > Would you find numbered labels unwanted according to a possible > interpretation related to 'GW-BASIC' identifier selection? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=e99332e7b4cda6e60f5b5916cf9943a79dbef902#n460 > My preference is unimportant here. Therefore, your question must be rhetorical. I presume that you mean to assert that Christophe's patch breaches the style guide. However, 'sonic_probe1' is the name of a function. The name of the goto label 'undo_probe1' reflects the name of the function. This is not some sequence of GW-BASIC labels referred to in the style guide. And neither does the patch add new functions with numbered names. > Can programming preferences evolve into the direction of “say what the > goto does”? > I could agree that macsonic.c has no function resembling "probe1", and that portion of the patch could be improved. Was that the opinion you were trying to express by way of rhetorical questions? I can't tell. Is it possible for a reviewer to effectively criticise C by use of English, when his C ability surpasses his English ability? You needn't answer that question, but please do consider it. > Regards, > Markus >
WARNING: multiple messages have this Message-ID (diff)
From: Finn Thain <fthain@telegraphics.com.au> To: Markus Elfring <Markus.Elfring@web.de> Cc: Christophe Jaillet <christophe.jaillet@wanadoo.fr>, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org> Subject: Re: net/sonic: Fix some resource leaks in error handling paths Date: Mon, 11 May 2020 00:28:34 +0000 [thread overview] Message-ID: <alpine.LNX.2.22.394.2005110845060.8@nippy.intranet> (raw) In-Reply-To: <bc70e24c-dd31-75b7-6ece-2ad31982641e@web.de> [-- Attachment #1: Type: text/plain, Size: 2151 bytes --] On Sun, 10 May 2020, Markus Elfring wrote: > > > > Do you know when these bugs were introduced? > > I suggest to take another look at a provided tag “Fixes”. If you can't determine when the bug was introduced, how can you criticise a patch for the lack of a Fixes tag? > To which commit would you like to refer to for the proposed adjustment > of the function “mac_sonic_platform_probe”? > That was my question to you. We seem to be talking past each other. Unforunately I only speak English, so if this misunderstanding is to be resolved, you're going to have to try harder to make yourself understood. > > Naming goto labels is just painting another bikeshed. Yes, some > > alternatives are preferable but it takes too long to identify them and > > finding consensus is unlikely anyway, as it's a matter of taste. > > Would you find numbered labels unwanted according to a possible > interpretation related to 'GW-BASIC' identifier selection? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=e99332e7b4cda6e60f5b5916cf9943a79dbef902#n460 > My preference is unimportant here. Therefore, your question must be rhetorical. I presume that you mean to assert that Christophe's patch breaches the style guide. However, 'sonic_probe1' is the name of a function. The name of the goto label 'undo_probe1' reflects the name of the function. This is not some sequence of GW-BASIC labels referred to in the style guide. And neither does the patch add new functions with numbered names. > Can programming preferences evolve into the direction of “say what the > goto does”? > I could agree that macsonic.c has no function resembling "probe1", and that portion of the patch could be improved. Was that the opinion you were trying to express by way of rhetorical questions? I can't tell. Is it possible for a reviewer to effectively criticise C by use of English, when his C ability surpasses his English ability? You needn't answer that question, but please do consider it. > Regards, > Markus >
next prev parent reply other threads:[~2020-05-11 0:29 UTC|newest] Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-09 6:15 [PATCH] net/sonic: Fix some resource leaks in error handling paths Markus Elfring 2020-05-09 6:15 ` Markus Elfring 2020-05-09 23:45 ` Finn Thain 2020-05-09 23:45 ` Finn Thain 2020-05-10 5:30 ` Markus Elfring 2020-05-10 5:30 ` Markus Elfring 2020-05-10 8:25 ` Finn Thain 2020-05-10 8:25 ` Finn Thain 2020-05-10 9:07 ` Markus Elfring 2020-05-10 9:07 ` Markus Elfring 2020-05-11 0:28 ` Finn Thain [this message] 2020-05-11 0:28 ` Finn Thain 2020-05-11 6:48 ` Markus Elfring 2020-05-11 6:48 ` Markus Elfring 2020-05-12 0:08 ` Finn Thain 2020-05-12 0:08 ` Finn Thain 2020-05-12 6:38 ` Markus Elfring 2020-05-12 6:38 ` Markus Elfring 2020-05-13 1:14 ` Finn Thain 2020-05-13 1:14 ` Finn Thain 2020-05-13 5:07 ` net/sonic: Software evolution around the application of coding standards Markus Elfring 2020-05-13 5:07 ` Markus Elfring 2020-05-13 23:16 ` Finn Thain 2020-05-13 23:16 ` Finn Thain 2020-05-11 8:20 ` net/sonic: Fix some resource leaks in error handling paths Markus Elfring 2020-05-11 8:20 ` Markus Elfring -- strict thread matches above, loose matches on Subject: below -- 2020-05-08 17:25 [PATCH] " Christophe JAILLET 2020-05-08 17:25 ` Christophe JAILLET 2020-05-08 23:28 ` Finn Thain 2020-05-08 23:28 ` Finn Thain 2020-05-09 0:57 ` Jakub Kicinski 2020-05-09 0:57 ` Jakub Kicinski 2020-05-09 1:57 ` Finn Thain 2020-05-09 1:57 ` Finn Thain 2020-05-09 2:04 ` Jakub Kicinski 2020-05-09 2:04 ` Jakub Kicinski 2020-05-09 1:54 ` Jakub Kicinski 2020-05-09 1:54 ` Jakub Kicinski 2020-05-09 16:47 ` Christophe JAILLET 2020-05-09 16:47 ` Christophe JAILLET 2020-05-09 18:13 ` Jakub Kicinski 2020-05-09 18:13 ` Jakub Kicinski 2020-05-09 20:31 ` Christophe JAILLET 2020-05-09 20:31 ` Christophe JAILLET 2020-05-09 22:42 ` Joe Perches 2020-05-09 22:42 ` Joe Perches 2020-05-09 23:32 ` David Miller 2020-05-09 23:32 ` David Miller 2020-05-09 23:41 ` Joe Perches 2020-05-09 23:41 ` Joe Perches 2020-05-09 23:52 ` Finn Thain 2020-05-09 23:52 ` Finn Thain
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.LNX.2.22.394.2005110845060.8@nippy.intranet \ --to=fthain@telegraphics.com.au \ --cc=Markus.Elfring@web.de \ --cc=christophe.jaillet@wanadoo.fr \ --cc=davem@davemloft.net \ --cc=kernel-janitors@vger.kernel.org \ --cc=kuba@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.