From: Hayes Wang <hayeswang@realtek.com>
To: Jason-ch Chen <jason-ch.chen@mediatek.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Project_Global_Chrome_Upstream_Group@mediatek.com"
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"hsinyi@google.com" <hsinyi@google.com>,
nic_swsd <nic_swsd@realtek.com>
Subject: RE: [PATCH] r8152: stop submitting rx for -EPROTO
Date: Wed, 29 Sep 2021 08:14:12 +0000 [thread overview]
Message-ID: <cbd1591fc03f480c9f08cc55585e2e35@realtek.com> (raw)
In-Reply-To: <20210929051812.3107-1-jason-ch.chen@mediatek.com>
Jason-ch Chen <jason-ch.chen@mediatek.com>
> Sent: Wednesday, September 29, 2021 1:18 PM
[...]
> When unplugging RTL8152 Fast Ethernet Adapter which is plugged
> into an USB HUB, the driver would get -EPROTO for bulk transfer.
> There is a high probability to get the soft/hard lockup
> information if the driver continues to submit Rx before the HUB
> completes the detection of all hub ports and issue the
> disconnect event.
I don't think it is a good idea.
For the other situations which return the same error code, you would stop the rx, too.
However, the rx may re-work after being resubmitted for the other cases.
Best Regards,
Hayes
WARNING: multiple messages have this Message-ID (diff)
From: Hayes Wang <hayeswang@realtek.com>
To: Jason-ch Chen <jason-ch.chen@mediatek.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Project_Global_Chrome_Upstream_Group@mediatek.com"
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"hsinyi@google.com" <hsinyi@google.com>,
nic_swsd <nic_swsd@realtek.com>
Subject: RE: [PATCH] r8152: stop submitting rx for -EPROTO
Date: Wed, 29 Sep 2021 08:14:12 +0000 [thread overview]
Message-ID: <cbd1591fc03f480c9f08cc55585e2e35@realtek.com> (raw)
In-Reply-To: <20210929051812.3107-1-jason-ch.chen@mediatek.com>
Jason-ch Chen <jason-ch.chen@mediatek.com>
> Sent: Wednesday, September 29, 2021 1:18 PM
[...]
> When unplugging RTL8152 Fast Ethernet Adapter which is plugged
> into an USB HUB, the driver would get -EPROTO for bulk transfer.
> There is a high probability to get the soft/hard lockup
> information if the driver continues to submit Rx before the HUB
> completes the detection of all hub ports and issue the
> disconnect event.
I don't think it is a good idea.
For the other situations which return the same error code, you would stop the rx, too.
However, the rx may re-work after being resubmitted for the other cases.
Best Regards,
Hayes
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Hayes Wang <hayeswang@realtek.com>
To: Jason-ch Chen <jason-ch.chen@mediatek.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Project_Global_Chrome_Upstream_Group@mediatek.com"
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"hsinyi@google.com" <hsinyi@google.com>,
nic_swsd <nic_swsd@realtek.com>
Subject: RE: [PATCH] r8152: stop submitting rx for -EPROTO
Date: Wed, 29 Sep 2021 08:14:12 +0000 [thread overview]
Message-ID: <cbd1591fc03f480c9f08cc55585e2e35@realtek.com> (raw)
In-Reply-To: <20210929051812.3107-1-jason-ch.chen@mediatek.com>
Jason-ch Chen <jason-ch.chen@mediatek.com>
> Sent: Wednesday, September 29, 2021 1:18 PM
[...]
> When unplugging RTL8152 Fast Ethernet Adapter which is plugged
> into an USB HUB, the driver would get -EPROTO for bulk transfer.
> There is a high probability to get the soft/hard lockup
> information if the driver continues to submit Rx before the HUB
> completes the detection of all hub ports and issue the
> disconnect event.
I don't think it is a good idea.
For the other situations which return the same error code, you would stop the rx, too.
However, the rx may re-work after being resubmitted for the other cases.
Best Regards,
Hayes
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-29 8:14 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 5:18 [PATCH] r8152: stop submitting rx for -EPROTO Jason-ch Chen
2021-09-29 5:18 ` Jason-ch Chen
2021-09-29 5:18 ` Jason-ch Chen
2021-09-29 8:14 ` Hayes Wang [this message]
2021-09-29 8:14 ` Hayes Wang
2021-09-29 8:14 ` Hayes Wang
2021-09-29 9:52 ` Jason-ch Chen
2021-09-29 9:52 ` Jason-ch Chen
2021-09-29 9:52 ` Jason-ch Chen
2021-09-30 2:41 ` Hayes Wang
2021-09-30 2:41 ` Hayes Wang
2021-09-30 2:41 ` Hayes Wang
2021-10-01 1:36 ` Jason-ch Chen
2021-10-01 1:36 ` Jason-ch Chen
2021-10-01 1:36 ` Jason-ch Chen
2021-09-30 9:30 ` Oliver Neukum
2021-09-30 9:30 ` Oliver Neukum
2021-09-30 9:30 ` Oliver Neukum
2021-09-30 15:18 ` Alan Stern
2021-09-30 15:18 ` Alan Stern
2021-09-30 15:18 ` Alan Stern
2021-10-01 2:40 ` Hayes Wang
2021-10-01 2:40 ` Hayes Wang
2021-10-01 2:40 ` Hayes Wang
2021-10-01 3:26 ` Hayes Wang
2021-10-01 3:26 ` Hayes Wang
2021-10-01 3:26 ` Hayes Wang
2021-10-01 15:22 ` Alan Stern
2021-10-01 15:22 ` Alan Stern
2021-10-01 15:22 ` Alan Stern
2021-10-04 2:15 ` Hayes Wang
2021-10-04 2:15 ` Hayes Wang
2021-10-04 2:15 ` Hayes Wang
2021-10-04 11:44 ` Oliver Neukum
2021-10-04 11:44 ` Oliver Neukum
2021-10-04 11:44 ` Oliver Neukum
2021-10-04 14:33 ` Alan Stern
2021-10-04 14:33 ` Alan Stern
2021-10-04 14:33 ` Alan Stern
2021-09-30 16:13 ` Hayes Wang
2021-09-30 16:13 ` Hayes Wang
2021-09-30 16:13 ` Hayes Wang
2021-10-04 6:28 ` [PATCH net] r8152: avoid to resubmit rx immediately Hayes Wang
2021-10-05 11:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cbd1591fc03f480c9f08cc55585e2e35@realtek.com \
--to=hayeswang@realtek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=hsinyi@google.com \
--cc=jason-ch.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.