From: Javier Martinez Canillas <javier@osg.samsung.com> To: Krzysztof Kozlowski <krzk@kernel.org>, Kevin Hilman <khilman@kernel.org> Cc: Kukjin Kim <kgene@kernel.org>, Sylwester Nawrocki <s.nawrocki@samsung.com>, Tomasz Figa <tomasz.figa@gmail.com>, Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@codeaurora.org>, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, linux-samsung-soc@vger.kernel.org, devicetree <devicetree@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>, linux-clk@vger.kernel.org, Rob Herring <robh+dt@kernel.org> Subject: Re: [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410 Date: Wed, 1 Jun 2016 16:52:47 -0400 [thread overview] Message-ID: <e9a103cc-a5cf-95d8-ee49-d44542dbcb1e@osg.samsung.com> (raw) In-Reply-To: <CAJKOXPcDZFaqL7+wT9d9iD7Y4QbZWPFQw2hTR3AzyU4K099WYA@mail.gmail.com> Hello Krzysztof, On 06/01/2016 04:06 PM, Krzysztof Kozlowski wrote: > On Wed, Jun 1, 2016 at 9:57 PM, Kevin Hilman <khilman@kernel.org> wrote: >> Hi Krzysztof, >> >> On Sat, May 28, 2016 at 2:54 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote: >>> Just like other Exynos5 family SoCs, this one has four UARTs. Configure >>> clocks for UART3 and enable it. >>> >>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> >>> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> >> >> This patch landed in linux-next[1] and kernelci.org found a boot >> regression on the exynos5410-odroidxu[2], where it looks like it's >> faulting in clk_prepare(). Bisecting pointed to this patch. I added >> "status = disabled" back into the DTS on top of next-20160601[3] and >> verified my odroid-XU to be booting fine again. > > Hi, > > Thanks for report. Indeed the patch brings up to the light an issue in > serial driver. Fixed here: > https://lkml.org/lkml/2016/5/31/570 > > I left the commit in my tree as it is correct (strictly speaking). > Sorry for any trouble it makes. > Kevin pointed me to this issue over IRC and I was able to reproduce it in my Peach Pi by removing the UART3 clocks from the Exynos5420 clock driver. Your patch indeed fixes the issue, I'll add a Reviewed-by on that thread. > Best regards, > Krzysztof > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
WARNING: multiple messages have this Message-ID (diff)
From: javier@osg.samsung.com (Javier Martinez Canillas) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410 Date: Wed, 1 Jun 2016 16:52:47 -0400 [thread overview] Message-ID: <e9a103cc-a5cf-95d8-ee49-d44542dbcb1e@osg.samsung.com> (raw) In-Reply-To: <CAJKOXPcDZFaqL7+wT9d9iD7Y4QbZWPFQw2hTR3AzyU4K099WYA@mail.gmail.com> Hello Krzysztof, On 06/01/2016 04:06 PM, Krzysztof Kozlowski wrote: > On Wed, Jun 1, 2016 at 9:57 PM, Kevin Hilman <khilman@kernel.org> wrote: >> Hi Krzysztof, >> >> On Sat, May 28, 2016 at 2:54 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote: >>> Just like other Exynos5 family SoCs, this one has four UARTs. Configure >>> clocks for UART3 and enable it. >>> >>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> >>> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> >> >> This patch landed in linux-next[1] and kernelci.org found a boot >> regression on the exynos5410-odroidxu[2], where it looks like it's >> faulting in clk_prepare(). Bisecting pointed to this patch. I added >> "status = disabled" back into the DTS on top of next-20160601[3] and >> verified my odroid-XU to be booting fine again. > > Hi, > > Thanks for report. Indeed the patch brings up to the light an issue in > serial driver. Fixed here: > https://lkml.org/lkml/2016/5/31/570 > > I left the commit in my tree as it is correct (strictly speaking). > Sorry for any trouble it makes. > Kevin pointed me to this issue over IRC and I was able to reproduce it in my Peach Pi by removing the UART3 clocks from the Exynos5420 clock driver. Your patch indeed fixes the issue, I'll add a Reviewed-by on that thread. > Best regards, > Krzysztof > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
next prev parent reply other threads:[~2016-06-01 20:53 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-05-28 9:54 [PATCH v5 00/22] ARM: dts: exynos: Add initial support for Odroid XU Krzysztof Kozlowski 2016-05-28 9:54 ` Krzysztof Kozlowski 2016-05-28 9:54 ` [PATCH v5 01/22] dt-bindings: clock: Add license and reformat Exynos5410 clock IDs Krzysztof Kozlowski 2016-05-28 9:54 ` Krzysztof Kozlowski 2016-05-28 9:54 ` [PATCH v5 02/22] dt-bindings: clock: Add PWM and USB clock IDs to Exynos5410 Krzysztof Kozlowski 2016-05-28 9:54 ` Krzysztof Kozlowski 2016-05-28 9:54 ` [PATCH v5 03/22] clk: samsung: exynos5410: Add serial3, USB and PWM clocks Krzysztof Kozlowski 2016-05-28 9:54 ` Krzysztof Kozlowski 2016-05-28 9:54 ` [PATCH v5 04/22] ARM: dts: exynos: Re-order alphabetically Exynos5420 SD0/SD1 pinctrl nodes Krzysztof Kozlowski 2016-05-28 9:54 ` Krzysztof Kozlowski 2016-05-28 9:54 ` Krzysztof Kozlowski 2016-05-28 9:54 ` [PATCH v5 05/22] ARM: dts: exynos: Use lowercase for Exynos5410 CPU node labels Krzysztof Kozlowski 2016-05-28 9:54 ` Krzysztof Kozlowski 2016-05-28 9:54 ` [PATCH v5 06/22] ARM: dts: exynos: Configure Exynos5410 pinctrl for eMMC and SD card Krzysztof Kozlowski 2016-05-28 9:54 ` Krzysztof Kozlowski 2016-05-28 9:54 ` [PATCH v5 07/22] ARM: dts: exynos: Split Odroid XU3 LEDs to separate DTSI Krzysztof Kozlowski 2016-05-28 9:54 ` Krzysztof Kozlowski 2016-05-28 9:54 ` [PATCH v5 08/22] ARM: dts: exynos: Move common nodes to exynos5.dtsi Krzysztof Kozlowski 2016-05-28 9:54 ` Krzysztof Kozlowski 2016-05-28 9:54 ` [PATCH v5 09/22] ARM: dts: exynos: Prepare for inclusion of exynos5.dtsi in exynos5410.dtsi Krzysztof Kozlowski 2016-05-28 9:54 ` Krzysztof Kozlowski 2016-05-28 9:54 ` [PATCH v5 10/22] ARM: dts: exynos: Use phandle to get parent node in exynos5250-snow Krzysztof Kozlowski 2016-05-28 9:54 ` Krzysztof Kozlowski 2016-05-28 9:54 ` [PATCH v5 11/22] ARM: dts: exynos: Move Exynos5250 and Exynos5420 nodes under soc Krzysztof Kozlowski 2016-05-28 9:54 ` [PATCH v5 12/22] ARM: dts: exynos: Include common exynos5 in exynos5410.dtsi Krzysztof Kozlowski 2016-05-28 9:54 ` Krzysztof Kozlowski 2016-05-28 9:54 ` [PATCH v5 13/22] ARM: dts: exynos: Enable UART3 on Exynos5410 Krzysztof Kozlowski 2016-05-28 9:54 ` Krzysztof Kozlowski 2016-06-01 19:57 ` Kevin Hilman 2016-06-01 19:57 ` Kevin Hilman 2016-06-01 20:06 ` Krzysztof Kozlowski 2016-06-01 20:06 ` Krzysztof Kozlowski 2016-06-01 20:52 ` Javier Martinez Canillas [this message] 2016-06-01 20:52 ` Javier Martinez Canillas 2016-06-01 20:54 ` Javier Martinez Canillas 2016-06-01 20:54 ` Javier Martinez Canillas 2016-06-02 4:17 ` Krzysztof Kozlowski 2016-06-02 4:17 ` Krzysztof Kozlowski 2016-05-28 9:54 ` [PATCH v5 14/22] ARM: dts: exynos: MCT is not an interrupt controller and extend length of iomap Krzysztof Kozlowski 2016-05-28 9:54 ` Krzysztof Kozlowski 2016-05-28 9:54 ` [PATCH v5 15/22] ARM: dts: exynos: Move common Exynos5410/542x/5800 nodes to new DTSI Krzysztof Kozlowski 2016-05-28 9:54 ` Krzysztof Kozlowski 2016-05-28 9:54 ` [PATCH v5 16/22] ARM: dts: exynos: Add USB to Exynos5410 Krzysztof Kozlowski 2016-05-28 9:54 ` Krzysztof Kozlowski 2016-05-28 9:54 ` [PATCH v5 17/22] ARM: dts: exynos: Add initial support for Odroid XU board Krzysztof Kozlowski 2016-05-28 9:54 ` Krzysztof Kozlowski 2016-05-28 9:54 ` [PATCH v5 18/22] dt-bindings: clock: Add I2C, HSI2C and RTC clock IDs to Exynos5410 Krzysztof Kozlowski 2016-05-28 9:54 ` Krzysztof Kozlowski 2016-05-28 9:54 ` [PATCH v5 19/22] clk: samsung: exynos5410: Add I2C, HSI2C and RTC clocks Krzysztof Kozlowski 2016-05-28 9:54 ` Krzysztof Kozlowski 2016-06-01 22:15 ` Stephen Boyd 2016-06-01 22:15 ` Stephen Boyd 2016-05-28 9:54 ` [PATCH v5 20/22] ARM: dts: exynos: Move HSI2C nodes to exynos54xx.dtsi Krzysztof Kozlowski 2016-05-28 9:54 ` Krzysztof Kozlowski 2016-05-28 9:54 ` [PATCH v5 21/22] ARM: dts: exynos: Add I2C, PWM and UART pinctrl to Exynos5410 Krzysztof Kozlowski 2016-05-28 9:54 ` Krzysztof Kozlowski 2016-05-28 9:54 ` [PATCH v5 22/22] ARM: dts: exynos: Add RTC and I2C " Krzysztof Kozlowski 2016-05-28 9:54 ` Krzysztof Kozlowski 2016-05-30 15:27 ` [PATCH v5 00/22] ARM: dts: exynos: Add initial support for Odroid XU Sylwester Nawrocki 2016-05-30 15:27 ` Sylwester Nawrocki 2016-05-31 9:12 ` Krzysztof Kozlowski 2016-05-31 9:12 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e9a103cc-a5cf-95d8-ee49-d44542dbcb1e@osg.samsung.com \ --to=javier@osg.samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=kgene@kernel.org \ --cc=khilman@kernel.org \ --cc=krzk@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=robh+dt@kernel.org \ --cc=s.nawrocki@samsung.com \ --cc=sboyd@codeaurora.org \ --cc=tomasz.figa@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.