Re: [LTP] [PATCH 3/3] syscalls/move_pages: removed tst_exit in check_config()

Re: [LTP] [PATCH 3/3] syscalls/move_pages: removed tst_exit in check_config()

[Zhouping Liu]

----- Original Message -----
> From: "Garrett Cooper" <yanegomi@gmail.com>
> To: "Zhouping Liu" <zliu@redhat.com>
> Sent: Saturday, April 28, 2012 3:53:54 PM
> Subject: Re: [LTP] [PATCH 3/3] syscalls/move_pages: removed tst_exit in check_config()
> 
> On Apr 28, 2012, at 12:48 AM, Zhouping Liu wrote:
> 
> > removed tst_exit in check_config(), as it's always involked
> > at any time, instead, using tst_brkm to displace tst_resm,
> > since TCONF should be called by tst_brkm.
> > 
> > Signed-off-by: Zhouping Liu <zliu@redhat.com>
> 
> Reviewed-by: Garrett Cooper <yanegomi@gmail.com
> 

Hi, Garrett,
you missed to CC ltp-list.

-- 
Thanks,
Zhouping

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH 3/3] syscalls/move_pages: removed tst_exit in check_config()

[Caspar Zhang]

On 04/28/2012 03:48 PM, Zhouping Liu wrote:
> removed tst_exit in check_config(), as it's always involked
> at any time, instead, using tst_brkm to displace tst_resm,
> since TCONF should be called by tst_brkm.
> 
> Signed-off-by: Zhouping Liu <zliu@redhat.com>

Acked-by: Caspar Zhang <caspar@casparzhang.com>

> ---
>  testcases/kernel/syscalls/move_pages/move_pages_support.c |    9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/testcases/kernel/syscalls/move_pages/move_pages_support.c b/testcases/kernel/syscalls/move_pages/move_pages_support.c
> index 6bd95d3..320486f 100644
> --- a/testcases/kernel/syscalls/move_pages/move_pages_support.c
> +++ b/testcases/kernel/syscalls/move_pages/move_pages_support.c
> @@ -382,14 +382,13 @@ void check_config(unsigned int min_nodes)
>  {
>  #if HAVE_NUMA_H && HAVE_NUMAIF_H
>  	if (numa_available() < 0) {
> -		tst_resm(TCONF, "NUMA support is not available");
> +		tst_brkm(TCONF, NULL, "NUMA support is not available");
>  	} else if (numa_max_node() < (min_nodes - 1)) {
> -		tst_resm(TCONF, "atleast 2 NUMA nodes are required");
> +		tst_brkm(TCONF, NULL, "atleast 2 NUMA nodes are required");
>  	} else if (tst_kvercmp(2, 6, 18) < 0) {
> -		tst_resm(TCONF, "2.6.18 or greater kernel required");
> +		tst_brkm(TCONF, NULL, "2.6.18 or greater kernel required");
>  	}
>  #else
> -	tst_resm(TCONF, "NUMA support not provided");
> +	tst_brkm(TCONF, NULL, "NUMA support not provided");
>  #endif
> -	tst_exit();
>  }


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH 3/3] syscalls/move_pages: removed tst_exit in check_config()

[Zhouping Liu]

removed tst_exit in check_config(), as it's always involked
at any time, instead, using tst_brkm to displace tst_resm,
since TCONF should be called by tst_brkm.

Signed-off-by: Zhouping Liu <zliu@redhat.com>
---
 testcases/kernel/syscalls/move_pages/move_pages_support.c |    9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/testcases/kernel/syscalls/move_pages/move_pages_support.c b/testcases/kernel/syscalls/move_pages/move_pages_support.c
index 6bd95d3..320486f 100644
--- a/testcases/kernel/syscalls/move_pages/move_pages_support.c
+++ b/testcases/kernel/syscalls/move_pages/move_pages_support.c
@@ -382,14 +382,13 @@ void check_config(unsigned int min_nodes)
 {
 #if HAVE_NUMA_H && HAVE_NUMAIF_H
 	if (numa_available() < 0) {
-		tst_resm(TCONF, "NUMA support is not available");
+		tst_brkm(TCONF, NULL, "NUMA support is not available");
 	} else if (numa_max_node() < (min_nodes - 1)) {
-		tst_resm(TCONF, "atleast 2 NUMA nodes are required");
+		tst_brkm(TCONF, NULL, "atleast 2 NUMA nodes are required");
 	} else if (tst_kvercmp(2, 6, 18) < 0) {
-		tst_resm(TCONF, "2.6.18 or greater kernel required");
+		tst_brkm(TCONF, NULL, "2.6.18 or greater kernel required");
 	}
 #else
-	tst_resm(TCONF, "NUMA support not provided");
+	tst_brkm(TCONF, NULL, "NUMA support not provided");
 #endif
-	tst_exit();
 }
-- 
1.7.10


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list