* [PATCH bpf] bpf: netdev: init the offload table earlier
@ 2023-05-05 21:58 Jakub Kicinski
2023-05-05 22:02 ` Stanislav Fomichev
0 siblings, 1 reply; 2+ messages in thread
From: Jakub Kicinski @ 2023-05-05 21:58 UTC (permalink / raw)
To: daniel
Cc: Jakub Kicinski, ast, andrii, martin.lau, song, yhs,
john.fastabend, kpsingh, sdf, haoluo, jolsa, bpf
Some netdevices may get unregistered before late_initcall(),
we have to move the hashtable init earlier.
Fixes: f1fc43d03946 ("bpf: Move offload initialization into late_initcall")
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217399
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: ast@kernel.org
CC: daniel@iogearbox.net
CC: andrii@kernel.org
CC: martin.lau@linux.dev
CC: song@kernel.org
CC: yhs@fb.com
CC: john.fastabend@gmail.com
CC: kpsingh@kernel.org
CC: sdf@google.com
CC: haoluo@google.com
CC: jolsa@kernel.org
CC: bpf@vger.kernel.org
---
kernel/bpf/offload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/bpf/offload.c b/kernel/bpf/offload.c
index d9c9f45e3529..8a26cd8814c1 100644
--- a/kernel/bpf/offload.c
+++ b/kernel/bpf/offload.c
@@ -859,4 +859,4 @@ static int __init bpf_offload_init(void)
return rhashtable_init(&offdevs, &offdevs_params);
}
-late_initcall(bpf_offload_init);
+core_initcall(bpf_offload_init);
--
2.40.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bpf] bpf: netdev: init the offload table earlier
2023-05-05 21:58 [PATCH bpf] bpf: netdev: init the offload table earlier Jakub Kicinski
@ 2023-05-05 22:02 ` Stanislav Fomichev
0 siblings, 0 replies; 2+ messages in thread
From: Stanislav Fomichev @ 2023-05-05 22:02 UTC (permalink / raw)
To: Jakub Kicinski
Cc: daniel, ast, andrii, martin.lau, song, yhs, john.fastabend,
kpsingh, haoluo, jolsa, bpf
On Fri, May 5, 2023 at 2:59 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> Some netdevices may get unregistered before late_initcall(),
> we have to move the hashtable init earlier.
>
> Fixes: f1fc43d03946 ("bpf: Move offload initialization into late_initcall")
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217399
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Stanislav Fomichev <sdf@google.com>
Make sense, thank you!
> ---
> CC: ast@kernel.org
> CC: daniel@iogearbox.net
> CC: andrii@kernel.org
> CC: martin.lau@linux.dev
> CC: song@kernel.org
> CC: yhs@fb.com
> CC: john.fastabend@gmail.com
> CC: kpsingh@kernel.org
> CC: sdf@google.com
> CC: haoluo@google.com
> CC: jolsa@kernel.org
> CC: bpf@vger.kernel.org
> ---
> kernel/bpf/offload.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/bpf/offload.c b/kernel/bpf/offload.c
> index d9c9f45e3529..8a26cd8814c1 100644
> --- a/kernel/bpf/offload.c
> +++ b/kernel/bpf/offload.c
> @@ -859,4 +859,4 @@ static int __init bpf_offload_init(void)
> return rhashtable_init(&offdevs, &offdevs_params);
> }
>
> -late_initcall(bpf_offload_init);
> +core_initcall(bpf_offload_init);
> --
> 2.40.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-05 22:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-05 21:58 [PATCH bpf] bpf: netdev: init the offload table earlier Jakub Kicinski
2023-05-05 22:02 ` Stanislav Fomichev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).