From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>, Coccinelle <cocci@systeme.lip6.fr>
Cc: Kate Stewart <kstewart@linuxfoundation.org>,
Yi Wang <wang.yi59@zte.com.cn>,
Petr Strnad <strnape1@fel.cvut.cz>,
Michal Marek <michal.lkml@markovi.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nicolas Palix <nicolas.palix@imag.fr>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Wen Yang <wen.yang99@zte.com.cn>,
Allison Randal <allison@lohutok.net>
Subject: Re: [Cocci] Coccinelle: pci_free_consistent: Checking when constraints
Date: Sun, 8 Sep 2019 14:48:47 +0200 [thread overview]
Message-ID: <63e433b4-06cf-cecc-46e0-9f31226f71d0@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1909081019020.3340@hadrien>
> The when exists below these lines has an impact.
This parameter should result in a desirable effect.
> I believe that the rule is ok as is.
I wonder about the relevance of the shown double if statement exclusion.
> A single path may have no call to pci_free_consistent,
We come along different views around the provided software functionality
once more.
> but if it has that call under one of the mentioned ifs,
> then the path is still ok,
I find that this information can need further clarification.
> and not something that an error should be reported about.
I do not expect an error message from the SmPL script execution here.
I just try again to clarify if the specification of a single function call
exclusion can (and should) be sufficient also at this place.
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2019-09-08 12:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-08 8:10 [Cocci] Coccinelle: pci_free_consistent: Checking when constraints Markus Elfring
2019-09-08 8:23 ` Julia Lawall
2019-09-08 12:48 ` Markus Elfring [this message]
[not found] ` <alpine.DEB.2.21.1909082149100.2644@hadrien>
2019-09-09 10:40 ` Markus Elfring
2019-09-16 6:24 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63e433b4-06cf-cecc-46e0-9f31226f71d0@web.de \
--to=markus.elfring@web.de \
--cc=allison@lohutok.net \
--cc=cocci@systeme.lip6.fr \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=strnape1@fel.cvut.cz \
--cc=tglx@linutronix.de \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).