From: Julia Lawall <julia.lawall@lip6.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Kate Stewart <kstewart@linuxfoundation.org>,
Yi Wang <wang.yi59@zte.com.cn>,
Petr Strnad <strnape1@fel.cvut.cz>,
Michal Marek <michal.lkml@markovi.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nicolas Palix <nicolas.palix@imag.fr>,
LKML <linux-kernel@vger.kernel.org>,
Wen Yang <wen.yang99@zte.com.cn>,
Thomas Gleixner <tglx@linutronix.de>,
Coccinelle <cocci@systeme.lip6.fr>,
Allison Randal <allison@lohutok.net>
Subject: Re: [Cocci] Coccinelle: pci_free_consistent: Checking when constraints
Date: Sun, 8 Sep 2019 10:23:58 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1909081019020.3340@hadrien> (raw)
In-Reply-To: <9666134d-0ff6-81eb-b088-f0086a0e61b1@web.de>
[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]
On Sun, 8 Sep 2019, Markus Elfring wrote:
> Hello,
>
> I have taken another look at a known script for the semantic patch language.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/scripts/coccinelle/free/pci_free_consistent.cocci?id=950b07c14e8c59444e2359f15fd70ed5112e11a0#n2
>
> The following SmPL code is used there so far.
>
> …
> ... when != pci_free_consistent(x,y,id,z)
> when != if (id) { ... pci_free_consistent(x,y,id,z) ... }
> when != if (y) { ... pci_free_consistent(x,y,id,z) ... }
> …
>
>
> It is specified that a specific function call should be excluded
> in a source code search.
> I do not see a need to repeat the specification twice that such a call
> could eventually happen also within a branch of another if statement.
> How do you think about to omit possibly redundant SmPL code at this place?
Have you actually run the rule and checked the impact of your proposed
change?
The when exists below these lines has an impact. I believe that the rule
is ok as is. A single path may have no call to pci_free_consistent, but
if it has that call under one of the mentioned ifs, then the path is still
ok, and not something that an error should be reported about.
julia
[-- Attachment #2: Type: text/plain, Size: 136 bytes --]
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2019-09-08 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-08 8:10 [Cocci] Coccinelle: pci_free_consistent: Checking when constraints Markus Elfring
2019-09-08 8:23 ` Julia Lawall [this message]
2019-09-08 12:48 ` Markus Elfring
[not found] ` <alpine.DEB.2.21.1909082149100.2644@hadrien>
2019-09-09 10:40 ` Markus Elfring
2019-09-16 6:24 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1909081019020.3340@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Markus.Elfring@web.de \
--cc=allison@lohutok.net \
--cc=cocci@systeme.lip6.fr \
--cc=gregkh@linuxfoundation.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=strnape1@fel.cvut.cz \
--cc=tglx@linutronix.de \
--cc=wang.yi59@zte.com.cn \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).