cocci.inria.fr archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@lip6.fr>, Coccinelle <cocci@systeme.lip6.fr>
Cc: Kate Stewart <kstewart@linuxfoundation.org>,
	Yi Wang <wang.yi59@zte.com.cn>,
	Michal Marek <michal.lkml@markovi.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Nicolas Palix <nicolas.palix@imag.fr>,
	LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Wen Yang <wen.yang99@zte.com.cn>,
	Allison Randal <allison@lohutok.net>
Subject: Re: [Cocci] Coccinelle: pci_free_consistent: Checking when constraints
Date: Mon, 9 Sep 2019 12:40:46 +0200	[thread overview]
Message-ID: <2cafacfa-0401-87c6-2d1d-d249bbc497af@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.1909082149100.2644@hadrien>

>> I just try again to clarify if the specification of a single function call
>> exclusion can (and should) be sufficient also at this place.
>
> It's not sufficient.
>
> I explained why it's not sufficient.

Thanks for another bit of information.


> If you had made your change and tested it, it's at least highly probable
> that you would understand why it is not sufficient as well.
>
> You first reflex when you have a question should be to try what you are
> wondering about, not to head for the mailing list.

I got the impression that a few of our previous clarification attempts
pointed design possibilities out into other directions.

Examples:
* Coccinelle: semantic patch for missing of_node_put
  Response by Wen Yang
  17 May 2019 14:32:57 +0800 (CST)
  https://lore.kernel.org/r/201905171432571474636@zte.com.cn/

  https://lore.kernel.org/r/141163ed-a78b-6d89-e6cd-3442adda7073@web.de/
  https://systeme.lip6.fr/pipermail/cocci/2019-May/005809.html
  https://lkml.org/lkml/2019/5/9/99

* [v5] Coccinelle: semantic code search for missing put_device()
  Discussion contribution by Markus Elfring
  https://lore.kernel.org/r/b2f195e8-c3a3-f876-a075-317bb33496c6@web.de/
  https://systeme.lip6.fr/pipermail/cocci/2019-February/005578.html
  https://lkml.org/lkml/2019/2/15/412


> Please stop spreading misinformation.

I find the provided software documentation still incomplete.
Thus I hope also that the situation can be improved by additional communication.

See also:
  [v5] Coccinelle: semantic code search for missing put_device()
  Response by Julia Lawall
  16 Feb 2019 10:36:45 +0100 (CET)
  alpine.DEB.2.21.1902161036120.3212@hadrien

  https://lore.kernel.org/r/6c114d10-0d17-6f43-4c33-0f57c230306f@web.de/
  https://systeme.lip6.fr/pipermail/cocci/2019-February/005594.html
  https://lkml.org/lkml/2019/2/16/38


How will the software development attention evolve further around the safe handling
of code exclusion specifications together with the semantic patch language?

Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  parent reply	other threads:[~2019-09-09 10:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-08  8:10 [Cocci] Coccinelle: pci_free_consistent: Checking when constraints Markus Elfring
2019-09-08  8:23 ` Julia Lawall
2019-09-08 12:48   ` Markus Elfring
     [not found]     ` <alpine.DEB.2.21.1909082149100.2644@hadrien>
2019-09-09 10:40       ` Markus Elfring [this message]
2019-09-16  6:24       ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2cafacfa-0401-87c6-2d1d-d249bbc497af@web.de \
    --to=markus.elfring@web.de \
    --cc=allison@lohutok.net \
    --cc=cocci@systeme.lip6.fr \
    --cc=gregkh@linuxfoundation.org \
    --cc=julia.lawall@lip6.fr \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=nicolas.palix@imag.fr \
    --cc=tglx@linutronix.de \
    --cc=wang.yi59@zte.com.cn \
    --cc=wen.yang99@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).