Re: [PATCH] ci: update 'static-analysis' to Ubuntu 22.04

From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Derrick Stolee <derrickstolee@github.com>,
	Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH] ci: update 'static-analysis' to Ubuntu 22.04
Date: Thu, 25 Aug 2022 09:08:57 -0700	[thread overview]
Message-ID: <xmqq1qt4486e.fsf@gitster.g> (raw)
In-Reply-To: <220825.86ilmg4mil.gmgdl@evledraar.gmail.com> (=?utf-8?B?IsOG?= =?utf-8?B?dmFyIEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Thu, 25 Aug 2022 12:47:53 +0200")

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> What's happening here is that coccinelle can no longer properly parse
> the file after the UNUSED() macros were applied to refs.c.

Sigh.

> 	diff --git a/refs.c b/refs.c
> 	index 607694c2662..37e7d88920c 100644
> 	--- a/refs.c
> 	+++ b/refs.c
> 	@@ -442,7 +442,7 @@ struct warn_if_dangling_data {
> 	 };
> 	 
> 	 static int warn_if_dangling_symref(const char *refname,
> 	-				   const struct object_id *UNUSED(oid),
> 	+				   const struct object_id *oid UNUSED2,
> 	 				   int flags, void *cb_data)
> 	 {
> 	 	struct warn_if_dangling_data *d = cb_data;

This is almost "the most simple and stupid and nobody would get
confused" version, which I may actually be able to live with.

Unfortunately it will not get the "somebody by mistake uses 'oid'
and we can break the build no matter what compiler is used by them
before sending the patch out to the list".

Doing s/oid UNUSED2/oid_UNUSED/ without any __attribute__((unused))
would give that benefit to us, but that won't squelch compilation
with -Wunused which makes it a non-starter.