From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Derrick Stolee" <derrickstolee@github.com>,
"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] ci: update 'static-analysis' to Ubuntu 22.04
Date: Fri, 26 Aug 2022 09:46:54 -0700 [thread overview]
Message-ID: <xmqqczcnymtd.fsf@gitster.g> (raw)
In-Reply-To: <Ywh6v8oo3nRl/O5h@coredump.intra.peff.net> (Jeff King's message of "Fri, 26 Aug 2022 03:48:15 -0400")
Jeff King <peff@peff.net> writes:
>> But the fix here isn't to delete unused.cocci, but to hold off on the
>> UNUSEwork D() patches until we figure out how to make coccinelle jive with
>> them.
>
> Yeah, my general skepticism and disappointment above notwithstanding,
> this seems like the best path forward from here. I tried a few other
> tricks (like --macro-file and --iso-file), but if its parser chokes, I
> don't think there's much we can do about it. Even if we wrote a patch to
> coccinelle itself (and I have no interest in doing that myself), it
> would take a while to become available.
If it is just a single unused.cocci, I would actually think removing
it would be a much better path forward. UNUSED() that renames to
help folks without checking compilers would help noticing bad code
much earlier than unused.cocci many contributors are not running
themselves anyway.
next prev parent reply other threads:[~2022-08-26 16:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 17:28 [PATCH] ci: update 'static-analysis' to Ubuntu 22.04 Derrick Stolee via GitGitGadget
2022-08-24 14:40 ` Johannes Schindelin
2022-08-24 19:59 ` Junio C Hamano
2022-08-24 23:43 ` Junio C Hamano
2022-08-25 0:30 ` Derrick Stolee
2022-08-25 4:43 ` Junio C Hamano
2022-08-25 10:47 ` Ævar Arnfjörð Bjarmason
2022-08-25 16:08 ` Junio C Hamano
2022-08-25 17:09 ` [PATCH 0/2] git-compat-util.h: change UNUSED(var) to UNUSED Ævar Arnfjörð Bjarmason
2022-08-25 17:09 ` [PATCH 1/2] git-compat-util.h: use "UNUSED", not "UNUSED(var)" Ævar Arnfjörð Bjarmason
2022-08-25 17:09 ` [PATCH 2/2] git-compat-util.h: use "deprecated" for UNUSED variables Ævar Arnfjörð Bjarmason
2022-08-26 7:52 ` [PATCH 0/2] git-compat-util.h: change UNUSED(var) to UNUSED Jeff King
2022-08-26 7:48 ` [PATCH] ci: update 'static-analysis' to Ubuntu 22.04 Jeff King
2022-08-26 16:46 ` Junio C Hamano [this message]
2022-08-27 12:58 ` Jeff King
2022-08-29 5:56 ` Junio C Hamano
2022-08-29 10:29 ` Ævar Arnfjörð Bjarmason
2022-08-31 15:12 ` Jeff King
2022-08-31 8:44 ` SZEDER Gábor
2022-08-31 12:13 ` Ævar Arnfjörð Bjarmason
2022-08-31 15:24 ` Jeff King
2022-08-31 19:19 ` Junio C Hamano
2022-08-31 18:05 ` SZEDER Gábor
2022-08-31 19:29 ` Ævar Arnfjörð Bjarmason
2022-08-25 14:57 ` Ævar Arnfjörð Bjarmason
2022-08-25 16:17 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqczcnymtd.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).