* [Intel-gfx] [PATCH v2 0/5] Misc GuC CT improvements - part II @ 2020-01-17 8:20 Michal Wajdeczko 2020-01-17 8:20 ` [Intel-gfx] [PATCH v2 1/5] drm/i915/guc: Don't GEM_BUG_ON on corrupted G2H CTB Michal Wajdeczko ` (8 more replies) 0 siblings, 9 replies; 11+ messages in thread From: Michal Wajdeczko @ 2020-01-17 8:20 UTC (permalink / raw) To: intel-gfx v2: drop redundant message + rebase Michal Wajdeczko (5): drm/i915/guc: Don't GEM_BUG_ON on corrupted G2H CTB drm/i915/guc: Don't pass CTB while writing drm/i915/guc: Don't pass CTB while reading drm/i915/guc: Switch to CT_ERROR in ct_read drm/i915/guc: Introduce CT_DEBUG drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 113 ++++++++++++---------- 1 file changed, 60 insertions(+), 53 deletions(-) -- 2.19.2 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] [PATCH v2 1/5] drm/i915/guc: Don't GEM_BUG_ON on corrupted G2H CTB 2020-01-17 8:20 [Intel-gfx] [PATCH v2 0/5] Misc GuC CT improvements - part II Michal Wajdeczko @ 2020-01-17 8:20 ` Michal Wajdeczko 2020-01-17 8:20 ` [Intel-gfx] [PATCH v2 2/5] drm/i915/guc: Don't pass CTB while writing Michal Wajdeczko ` (7 subsequent siblings) 8 siblings, 0 replies; 11+ messages in thread From: Michal Wajdeczko @ 2020-01-17 8:20 UTC (permalink / raw) To: intel-gfx We should never BUG_ON on any corruption in CTB descriptor as data there can be also modified by the GuC. Instead we can use flag "is_in_error" to indicate that we will not process any further messages over this CTB (until reset). While here move descriptor error reporting to the function that actually touches that descriptor. Note that unexpected content of the specific CT messages, that still complies with generic CT message format, shall not trigger disabling whole CTB, as that might just indicate new unsupported message types. v2: drop redundant message (Daniele) Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 41 ++++++++++++++--------- 1 file changed, 25 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c index a55c336cc5ef..338e29d66383 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c @@ -578,19 +578,28 @@ static inline bool ct_header_is_response(u32 header) static int ctb_read(struct intel_guc_ct_buffer *ctb, u32 *data) { struct guc_ct_buffer_desc *desc = ctb->desc; - u32 head = desc->head / 4; /* in dwords */ - u32 tail = desc->tail / 4; /* in dwords */ - u32 size = desc->size / 4; /* in dwords */ + u32 head = desc->head; + u32 tail = desc->tail; + u32 size = desc->size; u32 *cmds = ctb->cmds; - s32 available; /* in dwords */ + s32 available; unsigned int len; unsigned int i; - GEM_BUG_ON(desc->size % 4); - GEM_BUG_ON(desc->head % 4); - GEM_BUG_ON(desc->tail % 4); - GEM_BUG_ON(tail >= size); - GEM_BUG_ON(head >= size); + if (unlikely(desc->is_in_error)) + return -EPIPE; + + if (unlikely(!IS_ALIGNED(head, 4) || + !IS_ALIGNED(tail, 4) || + !IS_ALIGNED(size, 4) || + (tail >= size) || (head >= size))) { + goto corrupted; + } + + /* later calculations will be done in dwords */ + head /= 4; + tail /= 4; + size /= 4; /* tail == head condition indicates empty */ available = tail - head; @@ -615,7 +624,7 @@ static int ctb_read(struct intel_guc_ct_buffer *ctb, u32 *data) size - head : available - 1), &cmds[head], 4 * (head + available - 1 > size ? available - 1 - size + head : 0), &cmds[0]); - return -EPROTO; + goto corrupted; } for (i = 1; i < len; i++) { @@ -626,6 +635,12 @@ static int ctb_read(struct intel_guc_ct_buffer *ctb, u32 *data) desc->head = head * 4; return 0; + +corrupted: + DRM_ERROR("CT: Corrupted descriptor addr=%#x head=%u tail=%u size=%u\n", + desc->addr, desc->head, desc->tail, desc->size); + desc->is_in_error = 1; + return -EPIPE; } /** @@ -836,10 +851,4 @@ void intel_guc_ct_event_handler(struct intel_guc_ct *ct) else err = ct_handle_request(ct, msg); } while (!err); - - if (GEM_WARN_ON(err == -EPROTO)) { - CT_ERROR(ct, "Corrupted message: %#x\n", msg[0]); - ctb->desc->is_in_error = 1; - } } - -- 2.19.2 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Intel-gfx] [PATCH v2 2/5] drm/i915/guc: Don't pass CTB while writing 2020-01-17 8:20 [Intel-gfx] [PATCH v2 0/5] Misc GuC CT improvements - part II Michal Wajdeczko 2020-01-17 8:20 ` [Intel-gfx] [PATCH v2 1/5] drm/i915/guc: Don't GEM_BUG_ON on corrupted G2H CTB Michal Wajdeczko @ 2020-01-17 8:20 ` Michal Wajdeczko 2020-01-17 8:20 ` [Intel-gfx] [PATCH v2 3/5] drm/i915/guc: Don't pass CTB while reading Michal Wajdeczko ` (6 subsequent siblings) 8 siblings, 0 replies; 11+ messages in thread From: Michal Wajdeczko @ 2020-01-17 8:20 UTC (permalink / raw) To: intel-gfx Since we only have one SEND buffer we don't need to explicitly pass it to the write function. Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c index 338e29d66383..25d912d57fa2 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c @@ -311,12 +311,13 @@ static u32 ct_get_next_fence(struct intel_guc_ct *ct) * ^-----------------len-------------------^ */ -static int ctb_write(struct intel_guc_ct_buffer *ctb, - const u32 *action, - u32 len /* in dwords */, - u32 fence, - bool want_response) +static int ct_write(struct intel_guc_ct *ct, + const u32 *action, + u32 len /* in dwords */, + u32 fence, + bool want_response) { + struct intel_guc_ct_buffer *ctb = &ct->ctbs[CTB_SEND]; struct guc_ct_buffer_desc *desc = ctb->desc; u32 head = desc->head / 4; /* in dwords */ u32 tail = desc->tail / 4; /* in dwords */ @@ -492,7 +493,7 @@ static int ct_send(struct intel_guc_ct *ct, list_add_tail(&request.link, &ct->requests.pending); spin_unlock_irqrestore(&ct->requests.lock, flags); - err = ctb_write(ctb, action, len, fence, !!response_buf); + err = ct_write(ct, action, len, fence, !!response_buf); if (unlikely(err)) goto unlink; -- 2.19.2 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Intel-gfx] [PATCH v2 3/5] drm/i915/guc: Don't pass CTB while reading 2020-01-17 8:20 [Intel-gfx] [PATCH v2 0/5] Misc GuC CT improvements - part II Michal Wajdeczko 2020-01-17 8:20 ` [Intel-gfx] [PATCH v2 1/5] drm/i915/guc: Don't GEM_BUG_ON on corrupted G2H CTB Michal Wajdeczko 2020-01-17 8:20 ` [Intel-gfx] [PATCH v2 2/5] drm/i915/guc: Don't pass CTB while writing Michal Wajdeczko @ 2020-01-17 8:20 ` Michal Wajdeczko 2020-01-17 8:20 ` [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Switch to CT_ERROR in ct_read Michal Wajdeczko ` (5 subsequent siblings) 8 siblings, 0 replies; 11+ messages in thread From: Michal Wajdeczko @ 2020-01-17 8:20 UTC (permalink / raw) To: intel-gfx Since we only have one RECV buffer we don't need to explicitly pass it to the read function. Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c index 25d912d57fa2..b84b6ec37b8d 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c @@ -576,8 +576,9 @@ static inline bool ct_header_is_response(u32 header) return !!(header & GUC_CT_MSG_IS_RESPONSE); } -static int ctb_read(struct intel_guc_ct_buffer *ctb, u32 *data) +static int ct_read(struct intel_guc_ct *ct, u32 *data) { + struct intel_guc_ct_buffer *ctb = &ct->ctbs[CTB_RECV]; struct guc_ct_buffer_desc *desc = ctb->desc; u32 head = desc->head; u32 tail = desc->tail; @@ -833,7 +834,6 @@ static int ct_handle_request(struct intel_guc_ct *ct, const u32 *msg) */ void intel_guc_ct_event_handler(struct intel_guc_ct *ct) { - struct intel_guc_ct_buffer *ctb = &ct->ctbs[CTB_RECV]; u32 msg[GUC_CT_MSG_LEN_MASK + 1]; /* one extra dw for the header */ int err = 0; @@ -843,7 +843,7 @@ void intel_guc_ct_event_handler(struct intel_guc_ct *ct) } do { - err = ctb_read(ctb, msg); + err = ct_read(ct, msg); if (err) break; -- 2.19.2 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Switch to CT_ERROR in ct_read 2020-01-17 8:20 [Intel-gfx] [PATCH v2 0/5] Misc GuC CT improvements - part II Michal Wajdeczko ` (2 preceding siblings ...) 2020-01-17 8:20 ` [Intel-gfx] [PATCH v2 3/5] drm/i915/guc: Don't pass CTB while reading Michal Wajdeczko @ 2020-01-17 8:20 ` Michal Wajdeczko 2020-01-17 9:51 ` Piotr Piórkowski 2020-01-17 8:20 ` [Intel-gfx] [PATCH v2 5/5] drm/i915/guc: Introduce CT_DEBUG Michal Wajdeczko ` (4 subsequent siblings) 8 siblings, 1 reply; 11+ messages in thread From: Michal Wajdeczko @ 2020-01-17 8:20 UTC (permalink / raw) To: intel-gfx As we now have "ct" available in ct_read function we can switch from generic DRM_ERROR to our custom CT_ERROR. Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c index b84b6ec37b8d..09467728bc9b 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c @@ -620,12 +620,12 @@ static int ct_read(struct intel_guc_ct *ct, u32 *data) /* message len with header */ len = ct_header_get_len(data[0]) + 1; if (unlikely(len > (u32)available)) { - DRM_ERROR("CT: incomplete message %*ph %*ph %*ph\n", - 4, data, - 4 * (head + available - 1 > size ? - size - head : available - 1), &cmds[head], - 4 * (head + available - 1 > size ? - available - 1 - size + head : 0), &cmds[0]); + CT_ERROR(ct, "Incomplete message %*ph %*ph %*ph\n", + 4, data, + 4 * (head + available - 1 > size ? + size - head : available - 1), &cmds[head], + 4 * (head + available - 1 > size ? + available - 1 - size + head : 0), &cmds[0]); goto corrupted; } @@ -639,8 +639,8 @@ static int ct_read(struct intel_guc_ct *ct, u32 *data) return 0; corrupted: - DRM_ERROR("CT: Corrupted descriptor addr=%#x head=%u tail=%u size=%u\n", - desc->addr, desc->head, desc->tail, desc->size); + CT_ERROR(ct, "Corrupted descriptor addr=%#x head=%u tail=%u size=%u\n", + desc->addr, desc->head, desc->tail, desc->size); desc->is_in_error = 1; return -EPIPE; } -- 2.19.2 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Switch to CT_ERROR in ct_read 2020-01-17 8:20 ` [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Switch to CT_ERROR in ct_read Michal Wajdeczko @ 2020-01-17 9:51 ` Piotr Piórkowski 0 siblings, 0 replies; 11+ messages in thread From: Piotr Piórkowski @ 2020-01-17 9:51 UTC (permalink / raw) To: Michal Wajdeczko; +Cc: intel-gfx Michal Wajdeczko <michal.wajdeczko@intel.com> wrote on pią [2020-sty-17 08:20:38 +0000]: > As we now have "ct" available in ct_read function we can switch > from generic DRM_ERROR to our custom CT_ERROR. > > Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> > Cc: Chris Wilson <chris@chris-wilson.co.uk> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c > index b84b6ec37b8d..09467728bc9b 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c > @@ -620,12 +620,12 @@ static int ct_read(struct intel_guc_ct *ct, u32 *data) > /* message len with header */ > len = ct_header_get_len(data[0]) + 1; > if (unlikely(len > (u32)available)) { > - DRM_ERROR("CT: incomplete message %*ph %*ph %*ph\n", > - 4, data, > - 4 * (head + available - 1 > size ? > - size - head : available - 1), &cmds[head], > - 4 * (head + available - 1 > size ? > - available - 1 - size + head : 0), &cmds[0]); > + CT_ERROR(ct, "Incomplete message %*ph %*ph %*ph\n", > + 4, data, > + 4 * (head + available - 1 > size ? > + size - head : available - 1), &cmds[head], > + 4 * (head + available - 1 > size ? > + available - 1 - size + head : 0), &cmds[0]); > goto corrupted; > } > > @@ -639,8 +639,8 @@ static int ct_read(struct intel_guc_ct *ct, u32 *data) > return 0; > > corrupted: > - DRM_ERROR("CT: Corrupted descriptor addr=%#x head=%u tail=%u size=%u\n", > - desc->addr, desc->head, desc->tail, desc->size); > + CT_ERROR(ct, "Corrupted descriptor addr=%#x head=%u tail=%u size=%u\n", > + desc->addr, desc->head, desc->tail, desc->size); > desc->is_in_error = 1; > return -EPIPE; > } LGTM Reviewed-by: Piotr Piórkowski <piotr.piorkowski@intel.com> > -- > 2.19.2 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] [PATCH v2 5/5] drm/i915/guc: Introduce CT_DEBUG 2020-01-17 8:20 [Intel-gfx] [PATCH v2 0/5] Misc GuC CT improvements - part II Michal Wajdeczko ` (3 preceding siblings ...) 2020-01-17 8:20 ` [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Switch to CT_ERROR in ct_read Michal Wajdeczko @ 2020-01-17 8:20 ` Michal Wajdeczko 2020-01-17 8:51 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Misc GuC CT improvements - part II (rev2) Patchwork ` (3 subsequent siblings) 8 siblings, 0 replies; 11+ messages in thread From: Michal Wajdeczko @ 2020-01-17 8:20 UTC (permalink / raw) To: intel-gfx As we now have "ct" available almost in all functions we can start using dev variants of logs also for debug. Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> --- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 41 +++++++++++------------ 1 file changed, 19 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c index 09467728bc9b..873246d0bbfc 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c @@ -10,9 +10,10 @@ #define CT_ERROR(_ct, _fmt, ...) \ DRM_DEV_ERROR(ct_to_dev(_ct), "CT: " _fmt, ##__VA_ARGS__) #ifdef CONFIG_DRM_I915_DEBUG_GUC -#define CT_DEBUG_DRIVER(...) DRM_DEBUG_DRIVER(__VA_ARGS__) +#define CT_DEBUG(_ct, _fmt, ...) \ + DRM_DEV_DEBUG_DRIVER(ct_to_dev(_ct), "CT: " _fmt, ##__VA_ARGS__) #else -#define CT_DEBUG_DRIVER(...) do { } while (0) +#define CT_DEBUG(...) do { } while (0) #endif struct ct_request { @@ -81,7 +82,6 @@ static inline const char *guc_ct_buffer_type_to_str(u32 type) static void guc_ct_buffer_desc_init(struct guc_ct_buffer_desc *desc, u32 cmds_addr, u32 size) { - CT_DEBUG_DRIVER("CT: init addr=%#x size=%u\n", cmds_addr, size); memset(desc, 0, sizeof(*desc)); desc->addr = cmds_addr; desc->size = size; @@ -90,8 +90,6 @@ static void guc_ct_buffer_desc_init(struct guc_ct_buffer_desc *desc, static void guc_ct_buffer_desc_reset(struct guc_ct_buffer_desc *desc) { - CT_DEBUG_DRIVER("CT: desc %p reset head=%u tail=%u\n", - desc, desc->head, desc->tail); desc->head = 0; desc->tail = 0; desc->is_in_error = 0; @@ -189,8 +187,7 @@ int intel_guc_ct_init(struct intel_guc_ct *ct) return err; } - CT_DEBUG_DRIVER("CT: vma base=%#x\n", - intel_guc_ggtt_offset(guc, ct->vma)); + CT_DEBUG(ct, "vma base=%#x\n", intel_guc_ggtt_offset(guc, ct->vma)); /* store pointers to desc and cmds */ for (i = 0; i < ARRAY_SIZE(ct->ctbs); i++) { @@ -224,7 +221,7 @@ void intel_guc_ct_fini(struct intel_guc_ct *ct) int intel_guc_ct_enable(struct intel_guc_ct *ct) { struct intel_guc *guc = ct_to_guc(ct); - u32 base; + u32 base, cmds, size; int err; int i; @@ -239,9 +236,10 @@ int intel_guc_ct_enable(struct intel_guc_ct *ct) */ for (i = 0; i < ARRAY_SIZE(ct->ctbs); i++) { GEM_BUG_ON((i != CTB_SEND) && (i != CTB_RECV)); - guc_ct_buffer_desc_init(ct->ctbs[i].desc, - base + PAGE_SIZE/4 * i + PAGE_SIZE/2, - PAGE_SIZE/4); + cmds = base + PAGE_SIZE / 4 * i + PAGE_SIZE / 2; + size = PAGE_SIZE / 4; + CT_DEBUG(ct, "%d: addr=%#x size=%u\n", i, cmds, size); + guc_ct_buffer_desc_init(ct->ctbs[i].desc, cmds, size); } /* @@ -356,9 +354,8 @@ static int ct_write(struct intel_guc_ct *ct, (want_response ? GUC_CT_MSG_SEND_STATUS : 0) | (action[0] << GUC_CT_MSG_ACTION_SHIFT); - CT_DEBUG_DRIVER("CT: writing %*ph %*ph %*ph\n", - 4, &header, 4, &fence, - 4 * (len - 1), &action[1]); + CT_DEBUG(ct, "writing %*ph %*ph %*ph\n", + 4, &header, 4, &fence, 4 * (len - 1), &action[1]); cmds[tail] = header; tail = (tail + 1) % size; @@ -553,8 +550,8 @@ int intel_guc_ct_send(struct intel_guc_ct *ct, const u32 *action, u32 len, CT_ERROR(ct, "Sending action %#x failed (err=%d status=%#X)\n", action[0], ret, status); } else if (unlikely(ret)) { - CT_DEBUG_DRIVER("CT: send action %#x returned %d (%#x)\n", - action[0], ret, ret); + CT_DEBUG(ct, "send action %#x returned %d (%#x)\n", + action[0], ret, ret); } mutex_unlock(&guc->send_mutex); @@ -611,7 +608,7 @@ static int ct_read(struct intel_guc_ct *ct, u32 *data) /* beware of buffer wrap case */ if (unlikely(available < 0)) available += size; - CT_DEBUG_DRIVER("CT: available %d (%u:%u)\n", available, head, tail); + CT_DEBUG(ct, "available %d (%u:%u)\n", available, head, tail); GEM_BUG_ON(available < 0); data[0] = cmds[head]; @@ -633,7 +630,7 @@ static int ct_read(struct intel_guc_ct *ct, u32 *data) data[i] = cmds[head]; head = (head + 1) % size; } - CT_DEBUG_DRIVER("CT: received %*ph\n", 4 * len, data); + CT_DEBUG(ct, "received %*ph\n", 4 * len, data); desc->head = head * 4; return 0; @@ -693,13 +690,13 @@ static int ct_handle_response(struct intel_guc_ct *ct, const u32 *msg) return -EPROTO; } - CT_DEBUG_DRIVER("CT: response fence %u status %#x\n", fence, status); + CT_DEBUG(ct, "response fence %u status %#x\n", fence, status); spin_lock(&ct->requests.lock); list_for_each_entry(req, &ct->requests.pending, link) { if (unlikely(fence != req->fence)) { - CT_DEBUG_DRIVER("CT: request %u awaits response\n", - req->fence); + CT_DEBUG(ct, "request %u awaits response\n", + req->fence); continue; } if (unlikely(datalen > req->response_len)) { @@ -727,7 +724,7 @@ static void ct_process_request(struct intel_guc_ct *ct, struct intel_guc *guc = ct_to_guc(ct); int ret; - CT_DEBUG_DRIVER("CT: request %x %*ph\n", action, 4 * len, payload); + CT_DEBUG(ct, "request %x %*ph\n", action, 4 * len, payload); switch (action) { case INTEL_GUC_ACTION_DEFAULT: -- 2.19.2 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Misc GuC CT improvements - part II (rev2) 2020-01-17 8:20 [Intel-gfx] [PATCH v2 0/5] Misc GuC CT improvements - part II Michal Wajdeczko ` (4 preceding siblings ...) 2020-01-17 8:20 ` [Intel-gfx] [PATCH v2 5/5] drm/i915/guc: Introduce CT_DEBUG Michal Wajdeczko @ 2020-01-17 8:51 ` Patchwork 2020-01-17 9:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork ` (2 subsequent siblings) 8 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2020-01-17 8:51 UTC (permalink / raw) To: Michal Wajdeczko; +Cc: intel-gfx == Series Details == Series: Misc GuC CT improvements - part II (rev2) URL : https://patchwork.freedesktop.org/series/72071/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2efc33c45510 drm/i915/guc: Don't GEM_BUG_ON on corrupted G2H CTB -:53: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tail >= size' #53: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:592: + if (unlikely(!IS_ALIGNED(head, 4) || + !IS_ALIGNED(tail, 4) || + !IS_ALIGNED(size, 4) || + (tail >= size) || (head >= size))) { -:53: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'head >= size' #53: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:592: + if (unlikely(!IS_ALIGNED(head, 4) || + !IS_ALIGNED(tail, 4) || + !IS_ALIGNED(size, 4) || + (tail >= size) || (head >= size))) { total: 0 errors, 0 warnings, 2 checks, 66 lines checked 3fb92bd3cd12 drm/i915/guc: Don't pass CTB while writing 8eb488a458c8 drm/i915/guc: Don't pass CTB while reading 292d1303bf00 drm/i915/guc: Switch to CT_ERROR in ct_read d31956e86e8b drm/i915/guc: Introduce CT_DEBUG _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Misc GuC CT improvements - part II (rev2) 2020-01-17 8:20 [Intel-gfx] [PATCH v2 0/5] Misc GuC CT improvements - part II Michal Wajdeczko ` (5 preceding siblings ...) 2020-01-17 8:51 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Misc GuC CT improvements - part II (rev2) Patchwork @ 2020-01-17 9:16 ` Patchwork 2020-01-17 9:16 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork 2020-01-20 11:30 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork 8 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2020-01-17 9:16 UTC (permalink / raw) To: Michal Wajdeczko; +Cc: intel-gfx == Series Details == Series: Misc GuC CT improvements - part II (rev2) URL : https://patchwork.freedesktop.org/series/72071/ State : success == Summary == CI Bug Log - changes from CI_DRM_7758 -> Patchwork_16144 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_16144: ### IGT changes ### #### Suppressed #### The following results come from untrusted machines, tests, or statuses. They do not affect the overall result. * igt@gem_exec_gttfill@basic: - {fi-ehl-1}: [PASS][1] -> [FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-ehl-1/igt@gem_exec_gttfill@basic.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/fi-ehl-1/igt@gem_exec_gttfill@basic.html Known issues ------------ Here are the changes found in Patchwork_16144 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_module_load@reload-with-fault-injection: - fi-cfl-8700k: [PASS][3] -> [INCOMPLETE][4] ([i915#505]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-cfl-8700k/igt@i915_module_load@reload-with-fault-injection.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/fi-cfl-8700k/igt@i915_module_load@reload-with-fault-injection.html * igt@i915_selftest@live_blt: - fi-ivb-3770: [PASS][5] -> [DMESG-FAIL][6] ([i915#725]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-ivb-3770/igt@i915_selftest@live_blt.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/fi-ivb-3770/igt@i915_selftest@live_blt.html #### Possible fixes #### * igt@gem_exec_create@basic: - fi-icl-dsi: [DMESG-WARN][7] ([i915#109]) -> [PASS][8] [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-icl-dsi/igt@gem_exec_create@basic.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/fi-icl-dsi/igt@gem_exec_create@basic.html * igt@i915_pm_rpm@module-reload: - fi-skl-6770hq: [FAIL][9] ([i915#178]) -> [PASS][10] [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html * igt@i915_selftest@live_blt: - fi-hsw-4770: [DMESG-FAIL][11] ([i915#553] / [i915#725]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-hsw-4770/igt@i915_selftest@live_blt.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/fi-hsw-4770/igt@i915_selftest@live_blt.html * igt@kms_chamelium@hdmi-hpd-fast: - fi-kbl-7500u: [FAIL][13] ([fdo#111096] / [i915#323]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096 [i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109 [i915#178]: https://gitlab.freedesktop.org/drm/intel/issues/178 [i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323 [i915#505]: https://gitlab.freedesktop.org/drm/intel/issues/505 [i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553 [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725 [i915#937]: https://gitlab.freedesktop.org/drm/intel/issues/937 Participating hosts (47 -> 45) ------------------------------ Additional (3): fi-kbl-soraka fi-byt-j1900 fi-byt-n2820 Missing (5): fi-hsw-4770r fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7758 -> Patchwork_16144 CI-20190529: 20190529 CI_DRM_7758: d19270ce1f367fbfc1ff3b539bcb50e11ded181f @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5371: 1b2816124ec3dbd53b81725d39292f45d41d895b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16144: d31956e86e8b1f2a2df9e92a86c6bb1344e5584a @ git://anongit.freedesktop.org/gfx-ci/linux == Kernel 32bit build == Warning: Kernel 32bit buildtest failed: https://intel-gfx-ci.01.org/Patchwork_16144/build_32bit.log CALL scripts/checksyscalls.sh CALL scripts/atomic/check-atomics.sh CHK include/generated/compile.h Kernel: arch/x86/boot/bzImage is ready (#1) Building modules, stage 2. MODPOST 122 modules ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! scripts/Makefile.modpost:93: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1 Makefile:1282: recipe for target 'modules' failed make: *** [modules] Error 2 == Linux commits == d31956e86e8b drm/i915/guc: Introduce CT_DEBUG 292d1303bf00 drm/i915/guc: Switch to CT_ERROR in ct_read 8eb488a458c8 drm/i915/guc: Don't pass CTB while reading 3fb92bd3cd12 drm/i915/guc: Don't pass CTB while writing 2efc33c45510 drm/i915/guc: Don't GEM_BUG_ON on corrupted G2H CTB == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BUILD: warning for Misc GuC CT improvements - part II (rev2) 2020-01-17 8:20 [Intel-gfx] [PATCH v2 0/5] Misc GuC CT improvements - part II Michal Wajdeczko ` (6 preceding siblings ...) 2020-01-17 9:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork @ 2020-01-17 9:16 ` Patchwork 2020-01-20 11:30 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork 8 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2020-01-17 9:16 UTC (permalink / raw) To: Michal Wajdeczko; +Cc: intel-gfx == Series Details == Series: Misc GuC CT improvements - part II (rev2) URL : https://patchwork.freedesktop.org/series/72071/ State : warning == Summary == CALL scripts/checksyscalls.sh CALL scripts/atomic/check-atomics.sh CHK include/generated/compile.h Kernel: arch/x86/boot/bzImage is ready (#1) Building modules, stage 2. MODPOST 122 modules ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined! scripts/Makefile.modpost:93: recipe for target '__modpost' failed make[1]: *** [__modpost] Error 1 Makefile:1282: recipe for target 'modules' failed make: *** [modules] Error 2 == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/build_32bit.log _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for Misc GuC CT improvements - part II (rev2) 2020-01-17 8:20 [Intel-gfx] [PATCH v2 0/5] Misc GuC CT improvements - part II Michal Wajdeczko ` (7 preceding siblings ...) 2020-01-17 9:16 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork @ 2020-01-20 11:30 ` Patchwork 8 siblings, 0 replies; 11+ messages in thread From: Patchwork @ 2020-01-20 11:30 UTC (permalink / raw) To: Michal Wajdeczko; +Cc: intel-gfx == Series Details == Series: Misc GuC CT improvements - part II (rev2) URL : https://patchwork.freedesktop.org/series/72071/ State : success == Summary == CI Bug Log - changes from CI_DRM_7758_full -> Patchwork_16144_full ==================================================== Summary ------- **SUCCESS** No regressions found. Known issues ------------ Here are the changes found in Patchwork_16144_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_busy@busy-vcs1: - shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#112080]) +16 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb4/igt@gem_busy@busy-vcs1.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-iclb6/igt@gem_busy@busy-vcs1.html * igt@gem_ctx_persistence@vcs1-mixed-process: - shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#109276] / [fdo#112080]) +4 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb2/igt@gem_ctx_persistence@vcs1-mixed-process.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-iclb6/igt@gem_ctx_persistence@vcs1-mixed-process.html * igt@gem_exec_schedule@pi-distinct-iova-bsd: - shard-iclb: [PASS][5] -> [SKIP][6] ([i915#677]) +1 similar issue [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb5/igt@gem_exec_schedule@pi-distinct-iova-bsd.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-iclb4/igt@gem_exec_schedule@pi-distinct-iova-bsd.html * igt@gem_exec_schedule@preempt-other-chain-bsd: - shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#112146]) +6 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb6/igt@gem_exec_schedule@preempt-other-chain-bsd.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html * igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive: - shard-hsw: [PASS][9] -> [TIMEOUT][10] ([fdo#112271] / [i915#530]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-hsw5/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-hsw5/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html * igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing: - shard-kbl: [PASS][11] -> [TIMEOUT][12] ([fdo#112271] / [i915#530]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-kbl6/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-kbl3/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html * igt@gem_persistent_relocs@forked-thrash-inactive: - shard-iclb: [PASS][13] -> [TIMEOUT][14] ([fdo#112271] / [i915#530]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb5/igt@gem_persistent_relocs@forked-thrash-inactive.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-iclb1/igt@gem_persistent_relocs@forked-thrash-inactive.html * igt@i915_selftest@live_execlists: - shard-skl: [PASS][15] -> [DMESG-FAIL][16] ([i915#656]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-skl1/igt@i915_selftest@live_execlists.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-skl10/igt@i915_selftest@live_execlists.html * igt@kms_color@pipe-b-ctm-0-25: - shard-skl: [PASS][17] -> [DMESG-WARN][18] ([i915#109]) [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-skl9/igt@kms_color@pipe-b-ctm-0-25.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-skl2/igt@kms_color@pipe-b-ctm-0-25.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([i915#180]) +5 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_flip@flip-vs-suspend-interruptible: - shard-apl: [PASS][21] -> [DMESG-WARN][22] ([i915#180]) +6 similar issues [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-apl7/igt@kms_flip@flip-vs-suspend-interruptible.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible.html * igt@kms_plane_alpha_blend@pipe-b-coverage-7efc: - shard-skl: [PASS][23] -> [FAIL][24] ([fdo#108145] / [i915#265]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html * igt@kms_psr2_su@frontbuffer: - shard-iclb: [PASS][25] -> [SKIP][26] ([fdo#109642] / [fdo#111068]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb2/igt@kms_psr2_su@frontbuffer.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-iclb6/igt@kms_psr2_su@frontbuffer.html * igt@kms_psr@psr2_primary_page_flip: - shard-iclb: [PASS][27] -> [SKIP][28] ([fdo#109441]) [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-iclb1/igt@kms_psr@psr2_primary_page_flip.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-skl: [PASS][29] -> [INCOMPLETE][30] ([i915#69]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-skl9/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-skl9/igt@kms_vblank@pipe-a-ts-continuation-suspend.html * igt@prime_vgem@fence-wait-bsd2: - shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#109276]) +20 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb1/igt@prime_vgem@fence-wait-bsd2.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-iclb8/igt@prime_vgem@fence-wait-bsd2.html #### Possible fixes #### * igt@gem_ctx_persistence@processes: - shard-iclb: [FAIL][33] ([i915#570]) -> [PASS][34] [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb4/igt@gem_ctx_persistence@processes.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-iclb2/igt@gem_ctx_persistence@processes.html * igt@gem_ctx_persistence@vcs1-queued: - shard-iclb: [SKIP][35] ([fdo#109276] / [fdo#112080]) -> [PASS][36] +3 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb5/igt@gem_ctx_persistence@vcs1-queued.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-iclb4/igt@gem_ctx_persistence@vcs1-queued.html * igt@gem_ctx_shared@exec-single-timeline-bsd: - shard-iclb: [SKIP][37] ([fdo#110841]) -> [PASS][38] [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb2/igt@gem_ctx_shared@exec-single-timeline-bsd.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-iclb5/igt@gem_ctx_shared@exec-single-timeline-bsd.html * igt@gem_exec_async@concurrent-writes-bsd: - shard-iclb: [SKIP][39] ([fdo#112146]) -> [PASS][40] +8 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb4/igt@gem_exec_async@concurrent-writes-bsd.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-iclb6/igt@gem_exec_async@concurrent-writes-bsd.html * igt@gem_exec_balancer@hang: - shard-iclb: [INCOMPLETE][41] ([i915#140]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb2/igt@gem_exec_balancer@hang.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-iclb5/igt@gem_exec_balancer@hang.html * igt@gem_exec_balancer@smoke: - shard-iclb: [SKIP][43] ([fdo#110854]) -> [PASS][44] [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb5/igt@gem_exec_balancer@smoke.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-iclb1/igt@gem_exec_balancer@smoke.html * igt@gem_exec_parallel@vcs1-fds: - shard-iclb: [SKIP][45] ([fdo#112080]) -> [PASS][46] +11 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb5/igt@gem_exec_parallel@vcs1-fds.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-iclb1/igt@gem_exec_parallel@vcs1-fds.html * igt@gem_exec_schedule@out-order-bsd2: - shard-iclb: [SKIP][47] ([fdo#109276]) -> [PASS][48] +26 similar issues [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb8/igt@gem_exec_schedule@out-order-bsd2.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-iclb2/igt@gem_exec_schedule@out-order-bsd2.html * igt@gem_exec_schedule@pi-common-bsd: - shard-iclb: [SKIP][49] ([i915#677]) -> [PASS][50] +1 similar issue [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb4/igt@gem_exec_schedule@pi-common-bsd.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-iclb6/igt@gem_exec_schedule@pi-common-bsd.html * igt@gem_persistent_relocs@forked-interruptible-thrash-inactive: - shard-kbl: [TIMEOUT][51] ([fdo#112271] / [i915#530]) -> [PASS][52] [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-kbl4/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-kbl3/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html * igt@gem_persistent_relocs@forked-thrashing: - shard-kbl: [INCOMPLETE][53] ([fdo#103665] / [i915#530]) -> [PASS][54] [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-kbl6/igt@gem_persistent_relocs@forked-thrashing.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-kbl7/igt@gem_persistent_relocs@forked-thrashing.html * igt@gen9_exec_parse@allowed-all: - shard-skl: [DMESG-WARN][55] ([i915#716]) -> [PASS][56] [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-skl8/igt@gen9_exec_parse@allowed-all.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-skl1/igt@gen9_exec_parse@allowed-all.html * igt@i915_pm_dc@dc6-psr: - shard-iclb: [FAIL][57] ([i915#454]) -> [PASS][58] [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb4/igt@i915_pm_dc@dc6-psr.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-iclb4/igt@i915_pm_dc@dc6-psr.html * igt@i915_pm_rps@reset: - shard-iclb: [FAIL][59] ([i915#413]) -> [PASS][60] [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb4/igt@i915_pm_rps@reset.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-iclb4/igt@i915_pm_rps@reset.html * igt@i915_selftest@live_execlists: - shard-kbl: [INCOMPLETE][61] ([fdo#103665] / [fdo#112175] / [fdo#112259]) -> [PASS][62] [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-kbl6/igt@i915_selftest@live_execlists.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-kbl3/igt@i915_selftest@live_execlists.html * igt@kms_color@pipe-b-ctm-blue-to-red: - shard-skl: [DMESG-WARN][63] ([i915#109]) -> [PASS][64] [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-skl3/igt@kms_color@pipe-b-ctm-blue-to-red.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-skl2/igt@kms_color@pipe-b-ctm-blue-to-red.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-apl: [DMESG-WARN][65] ([i915#180]) -> [PASS][66] [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-apl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-apl8/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_cursor_crc@pipe-c-cursor-suspend: - shard-kbl: [DMESG-WARN][67] ([i915#180]) -> [PASS][68] +4 similar issues [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-kbl2/igt@kms_cursor_crc@pipe-c-cursor-suspend.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html * igt@kms_flip@plain-flip-ts-check-interruptible: - shard-skl: [FAIL][69] ([i915#34]) -> [PASS][70] +1 similar issue [69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-skl9/igt@kms_flip@plain-flip-ts-check-interruptible.html [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-skl4/igt@kms_flip@plain-flip-ts-check-interruptible.html * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes: - shard-iclb: [INCOMPLETE][71] ([i915#140] / [i915#250]) -> [PASS][72] [71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb8/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-iclb2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min: - shard-skl: [FAIL][73] ([fdo#108145]) -> [PASS][74] +2 similar issues [73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-skl7/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html * igt@kms_psr2_su@page_flip: - shard-iclb: [SKIP][75] ([fdo#109642] / [fdo#111068]) -> [PASS][76] [75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb8/igt@kms_psr2_su@page_flip.html [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-iclb2/igt@kms_psr2_su@page_flip.html * igt@kms_psr@psr2_sprite_plane_move: - shard-iclb: [SKIP][77] ([fdo#109441]) -> [PASS][78] +3 similar issues [77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7758/shard-iclb8/igt@kms_psr@psr2_sprite_plane_move.html [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665 [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841 [fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080 [fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146 [fdo#112175]: https://bugs.freedesktop.org/show_bug.cgi?id=112175 [fdo#112259]: https://bugs.freedesktop.org/show_bug.cgi?id=112259 [fdo#112271]: https://bugs.freedesktop.org/show_bug.cgi?id=112271 [i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109 [i915#140]: https://gitlab.freedesktop.org/drm/intel/issues/140 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#250]: https://gitlab.freedesktop.org/drm/intel/issues/250 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#34]: https://gitlab.freedesktop.org/drm/intel/issues/34 [i915#413]: https://gitlab.freedesktop.org/drm/intel/issues/413 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#530]: https://gitlab.freedesktop.org/drm/intel/issues/530 [i915#570]: https://gitlab.freedesktop.org/drm/intel/issues/570 [i915#656]: https://gitlab.freedesktop.org/drm/intel/issues/656 [i915#677]: https://gitlab.freedesktop.org/drm/intel/issues/677 [i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69 [i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716 Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Build changes ------------- * CI: CI-20190529 -> None * Linux: CI_DRM_7758 -> Patchwork_16144 CI-20190529: 20190529 CI_DRM_7758: d19270ce1f367fbfc1ff3b539bcb50e11ded181f @ git://anongit.freedesktop.org/gfx-ci/linux IGT_5371: 1b2816124ec3dbd53b81725d39292f45d41d895b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_16144: d31956e86e8b1f2a2df9e92a86c6bb1344e5584a @ git://anongit.freedesktop.org/gfx-ci/linux piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_16144/index.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-01-20 11:30 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-01-17 8:20 [Intel-gfx] [PATCH v2 0/5] Misc GuC CT improvements - part II Michal Wajdeczko 2020-01-17 8:20 ` [Intel-gfx] [PATCH v2 1/5] drm/i915/guc: Don't GEM_BUG_ON on corrupted G2H CTB Michal Wajdeczko 2020-01-17 8:20 ` [Intel-gfx] [PATCH v2 2/5] drm/i915/guc: Don't pass CTB while writing Michal Wajdeczko 2020-01-17 8:20 ` [Intel-gfx] [PATCH v2 3/5] drm/i915/guc: Don't pass CTB while reading Michal Wajdeczko 2020-01-17 8:20 ` [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Switch to CT_ERROR in ct_read Michal Wajdeczko 2020-01-17 9:51 ` Piotr Piórkowski 2020-01-17 8:20 ` [Intel-gfx] [PATCH v2 5/5] drm/i915/guc: Introduce CT_DEBUG Michal Wajdeczko 2020-01-17 8:51 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Misc GuC CT improvements - part II (rev2) Patchwork 2020-01-17 9:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork 2020-01-17 9:16 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork 2020-01-20 11:30 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).