* [PATCH] dt-bindings: soc: ti: pruss: Add dma-coherent property
@ 2021-07-30 3:19 Suman Anna
2021-08-03 10:17 ` Grygorii Strashko
2021-08-03 19:28 ` Rob Herring
0 siblings, 2 replies; 4+ messages in thread
From: Suman Anna @ 2021-07-30 3:19 UTC (permalink / raw)
To: Santosh Shilimkar, Rob Herring
Cc: devicetree, Grzegorz Jaszczyk, Grygorii Strashko,
Vignesh Raghavendra, Lokesh Vutla, Kishon Vijay Abraham I,
linux-arm-kernel
Update the PRUSS schema file to include the dma-coherent property
that indicates the coherency of the IP. The PRUSS IPs on 66AK2G
SoCs do use this property.
Signed-off-by: Suman Anna <s-anna@ti.com>
---
Hi Santosh,
This patch updates the PRUSS binding in preparation for adding the
PRUSS nodes for 66AK2G SoCs. Without this, the dtbs_check would
complain about the undefined dma-coherent property. Patch is top
of the AM64 ICSSG binding update patch [1].
regards
Suman
[1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210623165032.31223-2-s-anna@ti.com/
.../devicetree/bindings/soc/ti/ti,pruss.yaml | 37 +++++++++++++------
1 file changed, 25 insertions(+), 12 deletions(-)
diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
index 47d7fd24bc56..9d128b9e7deb 100644
--- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
+++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
@@ -85,6 +85,8 @@ properties:
dma-ranges:
maxItems: 1
+ dma-coherent: true
+
power-domains:
description: |
This property is as per sci-pm-domain.txt.
@@ -324,18 +326,29 @@ additionalProperties: false
# - interrupt-controller
# - pru
-if:
- properties:
- compatible:
- contains:
- enum:
- - ti,k2g-pruss
- - ti,am654-icssg
- - ti,j721e-icssg
- - ti,am642-icssg
-then:
- required:
- - power-domains
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - ti,k2g-pruss
+ - ti,am654-icssg
+ - ti,j721e-icssg
+ - ti,am642-icssg
+ then:
+ required:
+ - power-domains
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - ti,k2g-pruss
+ then:
+ required:
+ - dma-coherent
examples:
- |
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: soc: ti: pruss: Add dma-coherent property
2021-07-30 3:19 [PATCH] dt-bindings: soc: ti: pruss: Add dma-coherent property Suman Anna
@ 2021-08-03 10:17 ` Grygorii Strashko
2021-08-03 19:28 ` Rob Herring
1 sibling, 0 replies; 4+ messages in thread
From: Grygorii Strashko @ 2021-08-03 10:17 UTC (permalink / raw)
To: Suman Anna, Santosh Shilimkar, Rob Herring
Cc: Kishon Vijay Abraham I, Lokesh Vutla, Vignesh Raghavendra,
Grzegorz Jaszczyk, linux-arm-kernel, devicetree
On 30/07/2021 06:19, Suman Anna wrote:
> Update the PRUSS schema file to include the dma-coherent property
> that indicates the coherency of the IP. The PRUSS IPs on 66AK2G
> SoCs do use this property.
>
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
> Hi Santosh,
>
> This patch updates the PRUSS binding in preparation for adding the
> PRUSS nodes for 66AK2G SoCs. Without this, the dtbs_check would
> complain about the undefined dma-coherent property. Patch is top
> of the AM64 ICSSG binding update patch [1].
>
> regards
> Suman
>
> [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210623165032.31223-2-s-anna@ti.com/
>
> .../devicetree/bindings/soc/ti/ti,pruss.yaml | 37 +++++++++++++------
> 1 file changed, 25 insertions(+), 12 deletions(-)
>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
--
Best regards,
grygorii
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: soc: ti: pruss: Add dma-coherent property
2021-07-30 3:19 [PATCH] dt-bindings: soc: ti: pruss: Add dma-coherent property Suman Anna
2021-08-03 10:17 ` Grygorii Strashko
@ 2021-08-03 19:28 ` Rob Herring
2021-08-03 19:32 ` Suman Anna
1 sibling, 1 reply; 4+ messages in thread
From: Rob Herring @ 2021-08-03 19:28 UTC (permalink / raw)
To: Suman Anna
Cc: Santosh Shilimkar, Grygorii Strashko, Kishon Vijay Abraham I,
Lokesh Vutla, Vignesh Raghavendra, Grzegorz Jaszczyk,
linux-arm-kernel, devicetree
On Thu, Jul 29, 2021 at 10:19:01PM -0500, Suman Anna wrote:
> Update the PRUSS schema file to include the dma-coherent property
> that indicates the coherency of the IP. The PRUSS IPs on 66AK2G
> SoCs do use this property.
>
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
> Hi Santosh,
>
> This patch updates the PRUSS binding in preparation for adding the
> PRUSS nodes for 66AK2G SoCs. Without this, the dtbs_check would
> complain about the undefined dma-coherent property. Patch is top
> of the AM64 ICSSG binding update patch [1].
New required properties are not backwards compatible. You are kind of
saying that here (not used yet?), but make that clear in the commit msg.
With that fixed,
Reviewed-by: Rob Herring <robh@kernel.org>
>
> regards
> Suman
>
> [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210623165032.31223-2-s-anna@ti.com/
>
> .../devicetree/bindings/soc/ti/ti,pruss.yaml | 37 +++++++++++++------
> 1 file changed, 25 insertions(+), 12 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> index 47d7fd24bc56..9d128b9e7deb 100644
> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> @@ -85,6 +85,8 @@ properties:
> dma-ranges:
> maxItems: 1
>
> + dma-coherent: true
> +
> power-domains:
> description: |
> This property is as per sci-pm-domain.txt.
> @@ -324,18 +326,29 @@ additionalProperties: false
> # - interrupt-controller
> # - pru
>
> -if:
> - properties:
> - compatible:
> - contains:
> - enum:
> - - ti,k2g-pruss
> - - ti,am654-icssg
> - - ti,j721e-icssg
> - - ti,am642-icssg
> -then:
> - required:
> - - power-domains
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - ti,k2g-pruss
> + - ti,am654-icssg
> + - ti,j721e-icssg
> + - ti,am642-icssg
> + then:
> + required:
> + - power-domains
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - ti,k2g-pruss
> + then:
> + required:
> + - dma-coherent
>
> examples:
> - |
> --
> 2.32.0
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dt-bindings: soc: ti: pruss: Add dma-coherent property
2021-08-03 19:28 ` Rob Herring
@ 2021-08-03 19:32 ` Suman Anna
0 siblings, 0 replies; 4+ messages in thread
From: Suman Anna @ 2021-08-03 19:32 UTC (permalink / raw)
To: Rob Herring
Cc: Santosh Shilimkar, Grygorii Strashko, Kishon Vijay Abraham I,
Lokesh Vutla, Vignesh Raghavendra, Grzegorz Jaszczyk,
linux-arm-kernel, devicetree
On 8/3/21 2:28 PM, Rob Herring wrote:
> On Thu, Jul 29, 2021 at 10:19:01PM -0500, Suman Anna wrote:
>> Update the PRUSS schema file to include the dma-coherent property
>> that indicates the coherency of the IP. The PRUSS IPs on 66AK2G
>> SoCs do use this property.
>>
>> Signed-off-by: Suman Anna <s-anna@ti.com>
>> ---
>> Hi Santosh,
>>
>> This patch updates the PRUSS binding in preparation for adding the
>> PRUSS nodes for 66AK2G SoCs. Without this, the dtbs_check would
>> complain about the undefined dma-coherent property. Patch is top
>> of the AM64 ICSSG binding update patch [1].
>
> New required properties are not backwards compatible. You are kind of
> saying that here (not used yet?), but make that clear in the commit msg.
OK. Yeah, we haven't added the K2G dts nodes yet, and the new required property
is only applicable for that SoC and not others.
regards
Suman
>
> With that fixed,
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
>>
>> regards
>> Suman
>>
>> [1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210623165032.31223-2-s-anna@ti.com/
>>
>> .../devicetree/bindings/soc/ti/ti,pruss.yaml | 37 +++++++++++++------
>> 1 file changed, 25 insertions(+), 12 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>> index 47d7fd24bc56..9d128b9e7deb 100644
>> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
>> @@ -85,6 +85,8 @@ properties:
>> dma-ranges:
>> maxItems: 1
>>
>> + dma-coherent: true
>> +
>> power-domains:
>> description: |
>> This property is as per sci-pm-domain.txt.
>> @@ -324,18 +326,29 @@ additionalProperties: false
>> # - interrupt-controller
>> # - pru
>>
>> -if:
>> - properties:
>> - compatible:
>> - contains:
>> - enum:
>> - - ti,k2g-pruss
>> - - ti,am654-icssg
>> - - ti,j721e-icssg
>> - - ti,am642-icssg
>> -then:
>> - required:
>> - - power-domains
>> +allOf:
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - ti,k2g-pruss
>> + - ti,am654-icssg
>> + - ti,j721e-icssg
>> + - ti,am642-icssg
>> + then:
>> + required:
>> + - power-domains
>> +
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - ti,k2g-pruss
>> + then:
>> + required:
>> + - dma-coherent
>>
>> examples:
>> - |
>> --
>> 2.32.0
>>
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-08-03 19:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-30 3:19 [PATCH] dt-bindings: soc: ti: pruss: Add dma-coherent property Suman Anna
2021-08-03 10:17 ` Grygorii Strashko
2021-08-03 19:28 ` Rob Herring
2021-08-03 19:32 ` Suman Anna
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).