From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Chen-Yu Tsai <wenst@chromium.org>,
kernel@collabora.com,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 1/3] arm64: dts: mediatek: asurada: Add display regulators
Date: Wed, 21 Sep 2022 15:58:46 +0200 [thread overview]
Message-ID: <9234e731-8c2f-b599-39b1-bf5115a16931@collabora.com> (raw)
In-Reply-To: <20220921134806.lbg5meuy4fn6pifm@notapiano>
Il 21/09/22 15:48, Nícolas F. R. A. Prado ha scritto:
> On Fri, Sep 09, 2022 at 09:46:33AM +0200, AngeloGioacchino Del Regno wrote:
>> Il 08/09/22 19:11, Nícolas F. R. A. Prado ha scritto:
>>> Add the regulators present on the Asurada platform that are used to
>>> power the internal and external displays.
>>>
>>> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>>>
>>> ---
>>>
>>> .../boot/dts/mediatek/mt8192-asurada.dtsi | 114 ++++++++++++++++++
>>> 1 file changed, 114 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi
>>> index 4b314435f8fd..1d99e470ea1a 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi
>>
>> ..snip..
>>
>>> @@ -56,6 +116,18 @@ pp3300_ldo_z: regulator-3v3-z {
>>> vin-supply = <&ppvar_sys>;
>>> };
>>
>> Can you please add a comment here advertising that this regulator
>> will not only provide power to the MIPI bridge, but *also* to the
>> display panel itself?
>>
>> This is to make sure that everyone understands what's going on, and
>> also that we ourselves don't forget about that.
>>
>> Probably something like:
>> /* pp3300_mipibrdg also enables pp3300_panel */
>>
>> I would then propose to add a "regulator-fixed" that has no GPIO
>> but with vin-supply as this one.
>>
>> pp3300_panel: regulator-3v3-panel {
>> compatible = "regulator-fixed";
>> regulator-name = "pp3300_panel";
>> regulator-min-microvolt = <3300000>;
>> regulator-max-microvolt = <3300000>;
>>
>> vin-supply = <&pp3300_mipibrdg>;
>> };
>>
>> I would also test assigning this regulator to the panel node, as this
>> will make sure to cover future corner cases (think about PM suspend/resume).
>>
>> P.S.: If you add the pp3300_panel regulator-fixed with that vin-supply,
>> maybe the proposed comment would become a bit overkill. Your choice!
>
> Hi Angelo,
>
> thanks for the feedback.
>
> I think the current layout makes more sense based on my understanding of the
> power routing here: a single power line output by the pp3300_mipibrdg regulator
> powers both the ANX chip as well as the panel. So I'm going to keep it the way
> it is for now. If there are any other concerns please let me know.
>
As we discussed, I agree on this decision. Please go on.
Cheers!
> Thanks,
> Nícolas
>
>>
>> Cheers,
>> Angelo
>>
>>> + pp3300_mipibrdg: regulator-3v3-mipibrdg {
>>> + compatible = "regulator-fixed";
>>> + regulator-name = "pp3300_mipibrdg";
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pp3300_mipibrdg_en_pins>;
>>> + regulator-min-microvolt = <3300000>;
>>> + regulator-max-microvolt = <3300000>;
>>> + enable-active-high;
>>> + regulator-boot-on;
>>> + gpio = <&pio 127 GPIO_ACTIVE_HIGH>;
>>> + };
>>> +
>>> /* separately switched 3.3V power rail */
>>> pp3300_u: regulator-3v3-u {
>>> compatible = "regulator-fixed";
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-21 14:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 17:11 [PATCH 0/3] arm64: dts: mediatek: asurada: Enable internal display Nícolas F. R. A. Prado
2022-09-08 17:11 ` [PATCH 1/3] arm64: dts: mediatek: asurada: Add display regulators Nícolas F. R. A. Prado
2022-09-09 7:46 ` AngeloGioacchino Del Regno
2022-09-21 13:48 ` Nícolas F. R. A. Prado
2022-09-21 13:58 ` AngeloGioacchino Del Regno [this message]
2022-09-21 14:20 ` Chen-Yu Tsai
2022-09-27 21:13 ` Nícolas F. R. A. Prado
2022-09-08 17:11 ` [PATCH 2/3] arm64: dts: mediatek: asurada: Add display backlight Nícolas F. R. A. Prado
2022-09-09 7:46 ` AngeloGioacchino Del Regno
2022-09-08 17:11 ` [PATCH 3/3] arm64: dts: mediatek: asurada: Enable internal display Nícolas F. R. A. Prado
2022-09-12 10:32 ` [PATCH 0/3] " Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9234e731-8c2f-b599-39b1-bf5115a16931@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nfraprado@collabora.com \
--cc=robh+dt@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).