From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: andrew.murray@arm.com, mathieu.poirier@linaro.org
Cc: alexander.shishkin@linux.intel.com, mike.leach@linaro.org,
Al.Grant@arm.com, linux-arm-kernel@lists.infradead.org,
Sudeep.Holla@arm.com
Subject: Re: [PATCH v1 5/5] coresight: etm4x: save/restore state across CPU low power states
Date: Thu, 20 Jun 2019 18:00:48 +0100 [thread overview]
Message-ID: <9adb65af-a898-462b-ecbc-af972d9331a6@arm.com> (raw)
In-Reply-To: <20190620165427.GH20984@e119886-lin.cambridge.arm.com>
On 20/06/2019 17:54, Andrew Murray wrote:
> On Thu, Jun 20, 2019 at 10:47:38AM -0600, Mathieu Poirier wrote:
>> On Thu, 20 Jun 2019 at 10:34, Sudeep Holla <sudeep.holla@arm.com> wrote:
>>>
>>> On Thu, Jun 20, 2019 at 10:14:04AM -0600, Mathieu Poirier wrote:
>>>> On Thu, 20 Jun 2019 at 09:41, Sudeep Holla <sudeep.holla@arm.com> wrote:
...
>> Then all we have to do is make the ACPI/DT property that indicate the
>> method used to deal with tracer idling mandatory. That way people are
>> conscious of the choice they are making. To be backward compatible
>> with current systems we default to the TRCPDCR.PU method but print a
>> warning message, just like we do for obsolete DT bindings.
>
> I'll respin the series based on this approach. I'll also flip the
> 'disable_pm_save' module option to 'enable_pm_save' - thus allowing any
> one to use software save/restore if they wish.
If you are going to add a firmware property, please get a consensus on the
name here, before respinning to avoid another churn :-). How about one of :
"arm,coresight-etm-looses-state"
"arm,coresight-etm-needs-save-restore"
or something better long the line.
Cheers
Suzuki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-20 17:00 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 12:54 [PATCH v1 0/5] coresight: etm4x: save/restore ETMv4 context across CPU low power states Andrew Murray
2019-06-18 12:54 ` [PATCH v1 1/5] coresight: etm4x: remove superfluous setting of os_unlock Andrew Murray
2019-06-19 10:42 ` Suzuki K Poulose
2019-06-18 12:54 ` [PATCH v1 2/5] coresight: etm4x: use explicit barriers on enable/disable Andrew Murray
2019-06-18 22:34 ` Mathieu Poirier
2019-06-19 8:32 ` Suzuki K Poulose
2019-06-20 10:25 ` Andrew Murray
2019-06-18 12:54 ` [PATCH v1 3/5] coresight: etm4x: use octal permissions for module_params Andrew Murray
2019-06-19 10:43 ` Suzuki K Poulose
2019-06-18 12:54 ` [PATCH v1 4/5] coresight: etm4x: improve clarity of etm4_os_unlock comment Andrew Murray
2019-06-19 10:46 ` Suzuki K Poulose
2019-06-20 10:29 ` Andrew Murray
2019-06-18 12:54 ` [PATCH v1 5/5] coresight: etm4x: save/restore state across CPU low power states Andrew Murray
2019-06-18 13:21 ` Sudeep Holla
2019-06-19 10:38 ` Suzuki K Poulose
2019-06-19 11:07 ` Sudeep Holla
2019-06-19 16:22 ` Mathieu Poirier
2019-06-20 11:41 ` Andrew Murray
2019-06-20 14:55 ` Mathieu Poirier
2019-06-20 15:41 ` Sudeep Holla
2019-06-20 16:14 ` Mathieu Poirier
2019-06-20 16:34 ` Sudeep Holla
2019-06-20 16:47 ` Mathieu Poirier
2019-06-20 16:52 ` Sudeep Holla
2019-06-20 16:54 ` Andrew Murray
2019-06-20 17:00 ` Suzuki K Poulose [this message]
2019-06-20 17:10 ` Mathieu Poirier
2019-06-21 9:29 ` Andrew Murray
2019-06-21 15:30 ` Mathieu Poirier
2019-06-20 17:11 ` Sudeep Holla
2019-06-20 18:00 ` Mathieu Poirier
2019-06-20 16:48 ` Sudeep Holla
2019-06-18 22:55 ` Mathieu Poirier
2019-06-20 11:07 ` Andrew Murray
2019-06-20 14:49 ` Mathieu Poirier
2019-06-20 15:11 ` Andrew Murray
2019-06-20 15:26 ` Mathieu Poirier
2019-06-25 10:07 ` Suzuki K Poulose
2019-06-25 19:57 ` Mathieu Poirier
2019-06-26 10:21 ` Mike Leach
2019-06-26 16:57 ` Mathieu Poirier
2019-06-27 8:12 ` Andrew Murray
2019-06-27 8:17 ` Andrew Murray
2019-06-20 16:45 ` [PATCH v1 0/5] coresight: etm4x: save/restore ETMv4 context " Suzuki K Poulose
2019-06-20 16:57 ` Andrew Murray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9adb65af-a898-462b-ecbc-af972d9331a6@arm.com \
--to=suzuki.poulose@arm.com \
--cc=Al.Grant@arm.com \
--cc=Sudeep.Holla@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrew.murray@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).