From: Alex Lyakas <alex@zadara.com>
To: linux-block@vger.kernel.org
Cc: axboe@kernel.dk
Subject: [PATCH] block: preserve BIO_REFFED flag in bio_reset()
Date: Sat, 6 Apr 2019 16:03:20 +0300 [thread overview]
Message-ID: <1554555800-14392-1-git-send-email-alex@zadara.com> (raw)
Commit dac56212e8127dbc0bff7be35c508bc280213309 titled
"bio: skip atomic inc/dec of ->bi_cnt for most use cases"
made __bi_cnt dependent on the new BIO_REFFED flag.
bio_reset() does not reset __bi_cnt, but it does reset the BIO_REFFED flag.
But __bi_cnt depends now on the BIO_REFFED flag, so bio_reset()
needs to preserve this flag.
Signed-off-by: Alex Lyakas <alex@zadara.com>
---
block/bio.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/block/bio.c b/block/bio.c
index b64cedc..96f8dca 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -301,11 +301,17 @@ void bio_init(struct bio *bio, struct bio_vec *table,
void bio_reset(struct bio *bio)
{
unsigned long flags = bio->bi_flags & (~0UL << BIO_RESET_BITS);
+ bool bio_reffed = bio_flagged(bio, BIO_REFFED);
bio_uninit(bio);
memset(bio, 0, BIO_RESET_BYTES);
bio->bi_flags = flags;
+
+ /* we are not resetting __bi_cnt, but it depends on correct BIO_REFFED */
+ if (bio_reffed)
+ bio_set_flag(bio, BIO_REFFED);
+
atomic_set(&bio->__bi_remaining, 1);
}
EXPORT_SYMBOL(bio_reset);
--
1.9.1
next reply other threads:[~2019-04-06 13:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-06 13:03 Alex Lyakas [this message]
2019-04-06 18:58 ` [PATCH] block: preserve BIO_REFFED flag in bio_reset() Jens Axboe
2019-04-07 7:42 ` Alex Lyakas
2019-04-07 7:56 ` Christoph Hellwig
2019-04-07 14:35 ` Alex Lyakas
2019-04-08 6:30 ` Christoph Hellwig
2019-05-13 8:08 ` Christoph Hellwig
2019-04-07 19:38 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1554555800-14392-1-git-send-email-alex@zadara.com \
--to=alex@zadara.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).