From: Jens Axboe <axboe@kernel.dk>
To: Alex Lyakas <alex@zadara.com>, linux-block@vger.kernel.org
Subject: Re: [PATCH] block: preserve BIO_REFFED flag in bio_reset()
Date: Sat, 6 Apr 2019 12:58:54 -0600 [thread overview]
Message-ID: <ae3ac0dc-92ef-36f9-ff0d-ef41e6deacb1@kernel.dk> (raw)
In-Reply-To: <1554555800-14392-1-git-send-email-alex@zadara.com>
On 4/6/19 7:03 AM, Alex Lyakas wrote:
> Commit dac56212e8127dbc0bff7be35c508bc280213309 titled
> "bio: skip atomic inc/dec of ->bi_cnt for most use cases"
> made __bi_cnt dependent on the new BIO_REFFED flag.
>
> bio_reset() does not reset __bi_cnt, but it does reset the BIO_REFFED flag.
> But __bi_cnt depends now on the BIO_REFFED flag, so bio_reset()
> needs to preserve this flag.
Looks good to me, applied, thanks.
--
Jens Axboe
next prev parent reply other threads:[~2019-04-06 18:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-06 13:03 [PATCH] block: preserve BIO_REFFED flag in bio_reset() Alex Lyakas
2019-04-06 18:58 ` Jens Axboe [this message]
2019-04-07 7:42 ` Alex Lyakas
2019-04-07 7:56 ` Christoph Hellwig
2019-04-07 14:35 ` Alex Lyakas
2019-04-08 6:30 ` Christoph Hellwig
2019-05-13 8:08 ` Christoph Hellwig
2019-04-07 19:38 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae3ac0dc-92ef-36f9-ff0d-ef41e6deacb1@kernel.dk \
--to=axboe@kernel.dk \
--cc=alex@zadara.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).