From: Christoph Hellwig <hch@infradead.org>
To: Alex Lyakas <alex@zadara.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org
Subject: Re: [PATCH] block: preserve BIO_REFFED flag in bio_reset()
Date: Mon, 13 May 2019 01:08:38 -0700 [thread overview]
Message-ID: <20190513080838.GA5962@infradead.org> (raw)
In-Reply-To: <20190408063052.GA9257@infradead.org>
On Sun, Apr 07, 2019 at 11:30:52PM -0700, Christoph Hellwig wrote:
> On Sun, Apr 07, 2019 at 05:35:45PM +0300, Alex Lyakas wrote:
> > Hi Christoph,
> >
> > I understand and agree with your concern.
> >
> > Looking at the code, bi_flags is 16-bits wide, and only top 3 bits are
> > preserved by bio_reset(). These bits are used to indicate a bvec pool.
> > So we don't have any free bits to move the BIO_REFFED to. Unless we
> > make bi_flags wider.
>
> I think we just need to move BIO_REFFED around. Something like the
> untested patch below should do the job, although blk_types.h could
> use some additional cleanup in this area..
Any comments?
next prev parent reply other threads:[~2019-05-13 8:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-06 13:03 [PATCH] block: preserve BIO_REFFED flag in bio_reset() Alex Lyakas
2019-04-06 18:58 ` Jens Axboe
2019-04-07 7:42 ` Alex Lyakas
2019-04-07 7:56 ` Christoph Hellwig
2019-04-07 14:35 ` Alex Lyakas
2019-04-08 6:30 ` Christoph Hellwig
2019-05-13 8:08 ` Christoph Hellwig [this message]
2019-04-07 19:38 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190513080838.GA5962@infradead.org \
--to=hch@infradead.org \
--cc=alex@zadara.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).