linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Song Liu <songliubraving@fb.com>
To: "Guilherme G. Piccoli" <gpiccoli@canonical.com>
Cc: Song Liu <liu.song.a23@gmail.com>,
	linux-raid <linux-raid@vger.kernel.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"dm-devel@redhat.com" <dm-devel@redhat.com>,
	Jay Vosburgh <jay.vosburgh@canonical.com>,
	NeilBrown <neilb@suse.com>
Subject: Re: [PATCH v2 1/2] md raid0/linear: Introduce new array state 'broken'
Date: Mon, 19 Aug 2019 18:57:04 +0000	[thread overview]
Message-ID: <1725F15D-7CA2-4B8D-949A-4D8078D53AA9@fb.com> (raw)
In-Reply-To: <1f16110b-b798-806f-638b-57bbbedfea49@canonical.com>



> On Aug 19, 2019, at 11:30 AM, Guilherme G. Piccoli <gpiccoli@canonical.com> wrote:
> 
> On 19/08/2019 15:10, Song Liu wrote:
>> [...]
>> 
>> If we merge this with the MD_BROKEN patch, would the code look simpler?
>> 
>> Thanks,
>> Song
>> 
> 
> Hi Song, I don't believe it changes the complexity/"appearance" of the
> code. Both patches are "relatives" in the ideas' realm, but their code
> is different in nature. My goal in splitting them was to make more
> bisect-able changes.
> 
> But feel free to merge them in a single patch or let me know if you
> prefer that way and I can do it.
> 
> There's also a chance I haven't understood your statement/question
> correctly heh - if that's the case, please clarify me!

I was thinking, if we can set MD_BROKEN when the device fails, we can 
just test MD_BROKEN in array_state_show() (instead of iterating through 
all devices). 

Would this work?

Thanks,
Song

  reply	other threads:[~2019-08-19 18:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-16 13:40 [PATCH v2 1/2] md raid0/linear: Introduce new array state 'broken' Guilherme G. Piccoli
2019-08-16 13:41 ` [PATCH v2 2/2] mdadm: Introduce new array state 'broken' for raid0/linear Guilherme G. Piccoli
2019-08-19 18:10 ` [PATCH v2 1/2] md raid0/linear: Introduce new array state 'broken' Song Liu
2019-08-19 18:30   ` Guilherme G. Piccoli
2019-08-19 18:57     ` Song Liu [this message]
2019-08-19 19:11       ` Guilherme G. Piccoli
2019-08-19 21:57         ` Song Liu
2019-08-21 14:16           ` Guilherme G. Piccoli
2019-08-21 16:14             ` Song Liu
2019-08-21 18:06               ` Song Liu
2019-08-21 19:10               ` Guilherme G. Piccoli
2019-08-21 19:22                 ` Song Liu
2019-08-22 16:16                   ` Guilherme G. Piccoli
2019-08-22  8:49 ` Guoqing Jiang
2019-08-22 15:35   ` Guilherme G. Piccoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1725F15D-7CA2-4B8D-949A-4D8078D53AA9@fb.com \
    --to=songliubraving@fb.com \
    --cc=dm-devel@redhat.com \
    --cc=gpiccoli@canonical.com \
    --cc=jay.vosburgh@canonical.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=liu.song.a23@gmail.com \
    --cc=neilb@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).