From: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
To: "Guilherme G. Piccoli" <gpiccoli@canonical.com>,
linux-raid@vger.kernel.org
Cc: linux-block@vger.kernel.org, dm-devel@redhat.com,
jay.vosburgh@canonical.com, NeilBrown <neilb@suse.com>,
Song Liu <songliubraving@fb.com>
Subject: Re: [PATCH v2 1/2] md raid0/linear: Introduce new array state 'broken'
Date: Thu, 22 Aug 2019 10:49:52 +0200 [thread overview]
Message-ID: <ca2096ca-8cb2-468f-89d4-24cd059b8a6b@cloud.ionos.com> (raw)
In-Reply-To: <20190816134059.29751-1-gpiccoli@canonical.com>
Hi,
On 8/16/19 3:40 PM, Guilherme G. Piccoli wrote:
> +static bool linear_is_missing_dev(struct mddev *mddev)
> +{
> + struct md_rdev *rdev;
> + static int already_missing;
> + int def_disks, work_disks = 0;
> +
> + def_disks = mddev->raid_disks;
> + rdev_for_each(rdev, mddev)
> + if (rdev->bdev->bd_disk->flags & GENHD_FL_UP)
> + work_disks++;
> +
> + if (unlikely(def_disks - work_disks)) {
If my understanding is correct, after enter the branch,
> + if (already_missing < (def_disks - work_disks)) {
the above is always true since already_missing should be '0', right?
If so, maybe the above checking is pointless.
> + already_missing = def_disks - work_disks;
> + pr_warn("md: %s: linear array has %d missing/failed members\n",
> + mdname(mddev), already_missing);
> + }
> + return true;
> + }
> +
> + already_missing = 0;
> + return false;
> +}
> +.
I'd suggest something like, just FYI.
bool already_missing = false;
int missing_disks;
missing_disks = def_disks - work_disks;
if (unlikely(missing_disks)) {
already_missing = true;
pr_warn("md: %s: linear array has %d missing/failed members\n", mdname(mddev), missing_disks);
}
return already_missing;
Thanks,
Guoqing
next prev parent reply other threads:[~2019-08-22 8:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-16 13:40 [PATCH v2 1/2] md raid0/linear: Introduce new array state 'broken' Guilherme G. Piccoli
2019-08-16 13:41 ` [PATCH v2 2/2] mdadm: Introduce new array state 'broken' for raid0/linear Guilherme G. Piccoli
2019-08-19 18:10 ` [PATCH v2 1/2] md raid0/linear: Introduce new array state 'broken' Song Liu
2019-08-19 18:30 ` Guilherme G. Piccoli
2019-08-19 18:57 ` Song Liu
2019-08-19 19:11 ` Guilherme G. Piccoli
2019-08-19 21:57 ` Song Liu
2019-08-21 14:16 ` Guilherme G. Piccoli
2019-08-21 16:14 ` Song Liu
2019-08-21 18:06 ` Song Liu
2019-08-21 19:10 ` Guilherme G. Piccoli
2019-08-21 19:22 ` Song Liu
2019-08-22 16:16 ` Guilherme G. Piccoli
2019-08-22 8:49 ` Guoqing Jiang [this message]
2019-08-22 15:35 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca2096ca-8cb2-468f-89d4-24cd059b8a6b@cloud.ionos.com \
--to=guoqing.jiang@cloud.ionos.com \
--cc=dm-devel@redhat.com \
--cc=gpiccoli@canonical.com \
--cc=jay.vosburgh@canonical.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).