From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org,
Jeffle Xu <jefflexu@linux.alibaba.com>,
Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com, Hannes Reinecke <hare@suse.de>,
Ming Lei <ming.lei@redhat.com>
Subject: [PATCH V5 00/12] block: support bio based io polling
Date: Thu, 1 Apr 2021 10:19:15 +0800 [thread overview]
Message-ID: <20210401021927.343727-1-ming.lei@redhat.com> (raw)
Hi Jens,
Add per-task io poll context for holding HIPRI blk-mq/underlying bios
queued from bio based driver's io submission context, and reuse one bio
padding field for storing 'cookie' returned from submit_bio() for these
bios. Also explicitly end these bios in poll context by adding two
new bio flags.
In this way, we needn't to poll all underlying hw queues any more,
which is implemented in Jeffle's patches. And we can just poll hw queues
in which there is HIPRI IO queued.
Usually io submission and io poll share same context, so the added io
poll context data is just like one stack variable, and the cost for
saving bios is cheap.
V5:
- fix one use-after-free issue in case that polling is from another
context: adds one new cookie of BLK_QC_T_NOT_READY for preventing
this issue in patch 8/12
- add reviewed-by & tested-by tag
V4:
- cover one more test_bit(QUEUE_FLAG_POLL, ...) suggested by
Jeffle(01/12)
- drop patch of 'block: add helper of blk_create_io_context'
- add new helper of blk_create_io_poll_context() (03/12)
- drain submission queues in exit_io_context(), suggested by
Jeffle(08/13)
- considering shared io context case for blk_bio_poll_io_drain()
(08/13)
- fix one issue in blk_bio_poll_pack_groups() as suggested by
Jeffle(08/13)
- add reviewed-by tag
V3:
- fix cookie returned for bio based driver, as suggested by Jeffle Xu
- draining pending bios when submission context is exiting
- patch style and comment fix, as suggested by Mike
- allow poll context data to be NULL by always polling on submission queue
- remove RFC, and reviewed-by
V2:
- address queue depth scalability issue reported by Jeffle via bio
group list. Reuse .bi_end_io for linking bios which share same
.bi_end_io, and support 32 such groups in submit queue. With this way,
the scalability issue caused by kfifio is solved. Before really
ending bio, .bi_end_io is recovered from the group head.
Jeffle Xu (4):
block/mq: extract one helper function polling hw queue
block: add queue_to_disk() to get gendisk from request_queue
block: add poll_capable method to support bio-based IO polling
dm: support IO polling for bio-based dm device
Ming Lei (8):
block: add helper of blk_queue_poll
block: add one helper to free io_context
block: create io poll context for submission and poll task
block: add req flag of REQ_POLL_CTX
block: add new field into 'struct bvec_iter'
block: prepare for supporting bio_list via other link
block: use per-task poll context to implement bio based io polling
blk-mq: limit hw queues to be polled in each blk_poll()
block/bio.c | 5 +
block/blk-core.c | 258 ++++++++++++++++++++++++++--
block/blk-ioc.c | 15 +-
block/blk-mq.c | 308 +++++++++++++++++++++++++++++++++-
block/blk-sysfs.c | 16 +-
block/blk.h | 58 +++++++
drivers/md/dm-table.c | 24 +++
drivers/md/dm.c | 14 ++
drivers/nvme/host/core.c | 2 +-
include/linux/bio.h | 132 ++++++++-------
include/linux/blk_types.h | 30 +++-
include/linux/blkdev.h | 4 +
include/linux/bvec.h | 8 +
include/linux/device-mapper.h | 1 +
include/linux/iocontext.h | 2 +
include/trace/events/kyber.h | 6 +-
16 files changed, 788 insertions(+), 95 deletions(-)
--
2.29.2
next reply other threads:[~2021-04-01 2:21 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 2:19 Ming Lei [this message]
2021-04-01 2:19 ` [PATCH V5 01/12] block: add helper of blk_queue_poll Ming Lei
2021-04-01 2:19 ` [PATCH V5 02/12] block: add one helper to free io_context Ming Lei
2021-04-01 2:19 ` [PATCH V5 03/12] block: create io poll context for submission and poll task Ming Lei
2021-04-12 10:19 ` Christoph Hellwig
2021-04-01 2:19 ` [PATCH V5 04/12] block: add req flag of REQ_POLL_CTX Ming Lei
2021-04-01 2:19 ` [PATCH V5 05/12] block: add new field into 'struct bvec_iter' Ming Lei
2021-04-12 9:26 ` Christoph Hellwig
2021-04-13 9:36 ` Ming Lei
2021-04-01 2:19 ` [PATCH V5 06/12] block/mq: extract one helper function polling hw queue Ming Lei
2021-04-12 9:29 ` Christoph Hellwig
2021-04-01 2:19 ` [PATCH V5 07/12] block: prepare for supporting bio_list via other link Ming Lei
2021-04-12 10:18 ` Christoph Hellwig
2021-04-12 11:37 ` Ming Lei
2021-04-01 2:19 ` [PATCH V5 08/12] block: use per-task poll context to implement bio based io polling Ming Lei
2021-04-12 9:54 ` Christoph Hellwig
2021-04-12 10:20 ` Ming Lei
2021-04-12 10:29 ` Christoph Hellwig
2021-04-12 11:42 ` Ming Lei
2021-04-12 10:16 ` Christoph Hellwig
2021-04-12 10:37 ` Ming Lei
2021-04-01 2:19 ` [PATCH V5 09/12] blk-mq: limit hw queues to be polled in each blk_poll() Ming Lei
2021-04-01 2:19 ` [PATCH V5 10/12] block: add queue_to_disk() to get gendisk from request_queue Ming Lei
2021-04-12 12:52 ` Jens Axboe
2021-04-01 2:19 ` [PATCH V5 11/12] block: add poll_capable method to support bio-based IO polling Ming Lei
2021-04-12 9:38 ` Christoph Hellwig
2021-04-14 8:38 ` JeffleXu
2021-04-14 11:24 ` Ming Lei
2021-04-15 1:34 ` JeffleXu
2021-04-15 7:43 ` Ming Lei
2021-04-15 9:21 ` JeffleXu
2021-04-15 10:06 ` Ming Lei
2021-04-15 11:21 ` JeffleXu
2021-04-15 13:08 ` Ming Lei
2021-04-16 8:00 ` [PATCH] block: introduce QUEUE_FLAG_POLL_CAP flag Jeffle Xu
2021-04-16 8:42 ` JeffleXu
2021-04-16 9:07 ` Ming Lei
2021-04-16 10:20 ` JeffleXu
2021-04-17 14:06 ` JeffleXu
2021-04-19 2:21 ` Ming Lei
2021-04-19 5:40 ` JeffleXu
2021-04-19 13:36 ` Ming Lei
2021-04-20 7:25 ` JeffleXu
2021-04-01 2:19 ` [PATCH V5 12/12] dm: support IO polling for bio-based dm device Ming Lei
2021-04-09 15:39 ` [PATCH V5 00/12] block: support bio based io polling Ming Lei
2021-04-12 9:46 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210401021927.343727-1-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).