From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org,
Jeffle Xu <jefflexu@linux.alibaba.com>,
Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com, Hannes Reinecke <hare@suse.de>,
Ming Lei <ming.lei@redhat.com>
Subject: [PATCH V5 05/12] block: add new field into 'struct bvec_iter'
Date: Thu, 1 Apr 2021 10:19:20 +0800 [thread overview]
Message-ID: <20210401021927.343727-6-ming.lei@redhat.com> (raw)
In-Reply-To: <20210401021927.343727-1-ming.lei@redhat.com>
There is a hole at the end of 'struct bvec_iter', so put a new field
here and we can save cookie returned from submit_bio() here for
supporting bio based polling.
This way can avoid to extend bio unnecessarily.
Meantime add two helpers to get/set this field.
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
block/blk.h | 10 ++++++++++
include/linux/bvec.h | 8 ++++++++
2 files changed, 18 insertions(+)
diff --git a/block/blk.h b/block/blk.h
index 35901cee709d..c1d8456656df 100644
--- a/block/blk.h
+++ b/block/blk.h
@@ -395,4 +395,14 @@ static inline void blk_create_io_poll_context(struct request_queue *q)
bio_poll_ctx_alloc(ioc);
}
+static inline unsigned int bio_get_private_data(struct bio *bio)
+{
+ return bio->bi_iter.bi_private_data;
+}
+
+static inline void bio_set_private_data(struct bio *bio, unsigned int data)
+{
+ bio->bi_iter.bi_private_data = data;
+}
+
#endif /* BLK_INTERNAL_H */
diff --git a/include/linux/bvec.h b/include/linux/bvec.h
index ff832e698efb..547ad7526960 100644
--- a/include/linux/bvec.h
+++ b/include/linux/bvec.h
@@ -43,6 +43,14 @@ struct bvec_iter {
unsigned int bi_bvec_done; /* number of bytes completed in
current bvec */
+
+ /*
+ * There is a hole at the end of bvec_iter, add one new field to hold
+ * something which isn't related with 'bvec_iter', so that we can
+ * avoid extending bio. So far this new field is used for bio based
+ * polling, we will store returning value of submit_bio() here.
+ */
+ unsigned int bi_private_data;
};
struct bvec_iter_all {
--
2.29.2
next prev parent reply other threads:[~2021-04-01 2:22 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 2:19 [PATCH V5 00/12] block: support bio based io polling Ming Lei
2021-04-01 2:19 ` [PATCH V5 01/12] block: add helper of blk_queue_poll Ming Lei
2021-04-01 2:19 ` [PATCH V5 02/12] block: add one helper to free io_context Ming Lei
2021-04-01 2:19 ` [PATCH V5 03/12] block: create io poll context for submission and poll task Ming Lei
2021-04-12 10:19 ` Christoph Hellwig
2021-04-01 2:19 ` [PATCH V5 04/12] block: add req flag of REQ_POLL_CTX Ming Lei
2021-04-01 2:19 ` Ming Lei [this message]
2021-04-12 9:26 ` [PATCH V5 05/12] block: add new field into 'struct bvec_iter' Christoph Hellwig
2021-04-13 9:36 ` Ming Lei
2021-04-01 2:19 ` [PATCH V5 06/12] block/mq: extract one helper function polling hw queue Ming Lei
2021-04-12 9:29 ` Christoph Hellwig
2021-04-01 2:19 ` [PATCH V5 07/12] block: prepare for supporting bio_list via other link Ming Lei
2021-04-12 10:18 ` Christoph Hellwig
2021-04-12 11:37 ` Ming Lei
2021-04-01 2:19 ` [PATCH V5 08/12] block: use per-task poll context to implement bio based io polling Ming Lei
2021-04-12 9:54 ` Christoph Hellwig
2021-04-12 10:20 ` Ming Lei
2021-04-12 10:29 ` Christoph Hellwig
2021-04-12 11:42 ` Ming Lei
2021-04-12 10:16 ` Christoph Hellwig
2021-04-12 10:37 ` Ming Lei
2021-04-01 2:19 ` [PATCH V5 09/12] blk-mq: limit hw queues to be polled in each blk_poll() Ming Lei
2021-04-01 2:19 ` [PATCH V5 10/12] block: add queue_to_disk() to get gendisk from request_queue Ming Lei
2021-04-12 12:52 ` Jens Axboe
2021-04-01 2:19 ` [PATCH V5 11/12] block: add poll_capable method to support bio-based IO polling Ming Lei
2021-04-12 9:38 ` Christoph Hellwig
2021-04-14 8:38 ` JeffleXu
2021-04-14 11:24 ` Ming Lei
2021-04-15 1:34 ` JeffleXu
2021-04-15 7:43 ` Ming Lei
2021-04-15 9:21 ` JeffleXu
2021-04-15 10:06 ` Ming Lei
2021-04-15 11:21 ` JeffleXu
2021-04-15 13:08 ` Ming Lei
2021-04-16 8:00 ` [PATCH] block: introduce QUEUE_FLAG_POLL_CAP flag Jeffle Xu
2021-04-16 8:42 ` JeffleXu
2021-04-16 9:07 ` Ming Lei
2021-04-16 10:20 ` JeffleXu
2021-04-17 14:06 ` JeffleXu
2021-04-19 2:21 ` Ming Lei
2021-04-19 5:40 ` JeffleXu
2021-04-19 13:36 ` Ming Lei
2021-04-20 7:25 ` JeffleXu
2021-04-01 2:19 ` [PATCH V5 12/12] dm: support IO polling for bio-based dm device Ming Lei
2021-04-09 15:39 ` [PATCH V5 00/12] block: support bio based io polling Ming Lei
2021-04-12 9:46 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210401021927.343727-6-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
--cc=jefflexu@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).