linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Andrea Gelmini <andrea.gelmini@gelma.net>
Cc: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Fix typos
Date: Wed, 28 Nov 2018 18:02:47 +0100	[thread overview]
Message-ID: <20181128170247.GW2842@twin.jikos.cz> (raw)
In-Reply-To: <20181128161709.GA9917@glet>

On Wed, Nov 28, 2018 at 05:17:09PM +0100, Andrea Gelmini wrote:
> On Wed, Nov 28, 2018 at 04:56:20PM +0100, David Sterba wrote:
> > Thanks, such patches are accepted once in a while when the amount of new
> > typo fixes becomes noticeable.
> 
> About this patch (and the others sent to this m/l), I don't
> care to have them committed with my name.

You've put your time to find and fix the typos so you deserve the
credit. Because you sent them with the signed-off-by line I will use
that and maybe write a short changelog but otherwise I don't see a
reason why you should not be mentioned.

> Feel free to copy/integrate/commit with your/someone else name.

Unless you really want to stay out of the linux git history, I'm somehow
obliged by the development process to stick with the patch author name.

> It's just - probably - the best way to let the real devs to know
> about the typos, but it's not valuable effort that must be
> recognized.

The typos can be annoying and distracting while reading code or prevent
some function names to be greppable (which is usually the reason to fix
them). My first patch to linux was also fixing typos, and see where I am
now :)

  reply	other threads:[~2018-11-28 17:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-28 11:05 [PATCH] Fix typos Andrea Gelmini
2018-11-28 11:23 ` Nikolay Borisov
2018-11-28 13:24   ` Brendan Hide
2018-11-28 13:41     ` Nikolay Borisov
2018-11-28 15:56 ` David Sterba
2018-11-28 16:17   ` Andrea Gelmini
2018-11-28 17:02     ` David Sterba [this message]
2018-11-28 17:12       ` Andrea Gelmini
2018-12-13 21:59         ` David Sterba
2018-12-29 15:29           ` Andrea Gelmini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181128170247.GW2842@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=andrea.gelmini@gelma.net \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).