linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brendan Hide <brendan@swiftspirit.co.za>
To: Nikolay Borisov <nborisov@suse.com>,
	Andrea Gelmini <andrea.gelmini@gelma.net>,
	linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Fix typos
Date: Wed, 28 Nov 2018 15:24:32 +0200	[thread overview]
Message-ID: <6fce869c-79fe-465e-2bda-84222e5e09a3@swiftspirit.co.za> (raw)
In-Reply-To: <54384bb2-e602-a1d5-ea6f-96513d7e1f3a@suse.com>



On 11/28/18 1:23 PM, Nikolay Borisov wrote:
> 
> 
> On 28.11.18 г. 13:05 ч., Andrea Gelmini wrote:
>> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
>> ---

<snip>

>>
>> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
>> index bab2f1983c07..babbd75d91d2 100644
>> --- a/fs/btrfs/inode.c
>> +++ b/fs/btrfs/inode.c
>> @@ -104,7 +104,7 @@ static void __endio_write_update_ordered(struct inode *inode,
>>   
>>   /*
>>    * Cleanup all submitted ordered extents in specified range to handle errors
>> - * from the fill_dellaloc() callback.
>> + * from the fill_delalloc() callback.
> 
> This is a pure whitespace fix which is generally frowned upon. What you
> can do though, is replace 'fill_delalloc callback' with
> 'btrfs_run_delalloc_range' since the callback is gone already.
> 
>>    *
>>    * NOTE: caller must ensure that when an error happens, it can not call
>>    * extent_clear_unlock_delalloc() to clear both the bits EXTENT_DO_ACCOUNTING
>> @@ -1831,7 +1831,7 @@ void btrfs_clear_delalloc_extent(struct inode *vfs_inode,
> 
> <snip>
> 
>> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
>> index 410c7e007ba8..d7b6c2b09a0c 100644
>> --- a/fs/btrfs/ioctl.c
>> +++ b/fs/btrfs/ioctl.c
>> @@ -892,7 +892,7 @@ static int create_snapshot(struct btrfs_root *root, struct inode *dir,
>>    *  7. If we were asked to remove a directory and victim isn't one - ENOTDIR.
>>    *  8. If we were asked to remove a non-directory and victim isn't one - EISDIR.
>>    *  9. We can't remove a root or mountpoint.
>> - * 10. We don't allow removal of NFS sillyrenamed files; it's handled by
>> + * 10. We don't allow removal of NFS silly renamed files; it's handled by
>>    *     nfs_async_unlink().
>>    */
>>   
>> @@ -3522,7 +3522,7 @@ static int btrfs_extent_same_range(struct inode *src, u64 loff, u64 olen,
>>   					       false);
>>   	/*
>>   	 * If one of the inodes has dirty pages in the respective range or
>> -	 * ordered extents, we need to flush dellaloc and wait for all ordered
>> +	 * ordered extents, we need to flush delalloc and wait for all ordered
> 
> Just whitespace fix, drop it.
> 
> <snip>
> 

If the spelling is changed, surely that is not a whitespace fix?

  reply	other threads:[~2018-11-28 13:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-28 11:05 [PATCH] Fix typos Andrea Gelmini
2018-11-28 11:23 ` Nikolay Borisov
2018-11-28 13:24   ` Brendan Hide [this message]
2018-11-28 13:41     ` Nikolay Borisov
2018-11-28 15:56 ` David Sterba
2018-11-28 16:17   ` Andrea Gelmini
2018-11-28 17:02     ` David Sterba
2018-11-28 17:12       ` Andrea Gelmini
2018-12-13 21:59         ` David Sterba
2018-12-29 15:29           ` Andrea Gelmini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6fce869c-79fe-465e-2bda-84222e5e09a3@swiftspirit.co.za \
    --to=brendan@swiftspirit.co.za \
    --cc=andrea.gelmini@gelma.net \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=nborisov@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).