Re: [PATCH] Fix typos

[Nikolay Borisov <nborisov@suse.com>]

On 28.11.18 г. 13:05 ч., Andrea Gelmini wrote:
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
> ---
> 
> Stupid fixes. Made on 4.20-rc4, and ported on linux-next (next-20181128).
> 
> 
>  fs/btrfs/backref.c         |  4 ++--
>  fs/btrfs/check-integrity.c |  2 +-
>  fs/btrfs/compression.c     |  4 ++--
>  fs/btrfs/ctree.c           |  4 ++--
>  fs/btrfs/dev-replace.c     |  2 +-
>  fs/btrfs/disk-io.c         |  4 ++--
>  fs/btrfs/extent-tree.c     | 28 ++++++++++++++--------------
>  fs/btrfs/extent_io.c       |  4 ++--
>  fs/btrfs/extent_io.h       |  2 +-
>  fs/btrfs/extent_map.c      |  2 +-
>  fs/btrfs/file.c            |  6 +++---
>  fs/btrfs/free-space-tree.c |  2 +-
>  fs/btrfs/inode.c           | 10 +++++-----
>  fs/btrfs/ioctl.c           |  4 ++--
>  fs/btrfs/lzo.c             |  2 +-
>  fs/btrfs/qgroup.c          | 14 +++++++-------
>  fs/btrfs/qgroup.h          |  4 ++--
>  fs/btrfs/raid56.c          |  2 +-
>  fs/btrfs/ref-verify.c      |  6 +++---
>  fs/btrfs/relocation.c      |  2 +-
>  fs/btrfs/scrub.c           |  2 +-
>  fs/btrfs/send.c            |  4 ++--
>  fs/btrfs/super.c           |  8 ++++----
>  fs/btrfs/transaction.c     |  4 ++--
>  fs/btrfs/tree-checker.c    |  6 +++---
>  fs/btrfs/tree-log.c        |  4 ++--
>  fs/btrfs/volumes.c         |  8 ++++----
>  27 files changed, 72 insertions(+), 72 deletions(-)
> 
> diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
> index 4a15f87dbbb4..78556447e1d5 100644
> --- a/fs/btrfs/backref.c
> +++ b/fs/btrfs/backref.c
> @@ -591,7 +591,7 @@ unode_aux_to_inode_list(struct ulist_node *node)
>  }
>  
>  /*

<snip>

> @@ -9807,7 +9807,7 @@ void btrfs_dec_block_group_ro(struct btrfs_block_group_cache *cache)
>  }
>  
>  /*
> - * checks to see if its even possible to relocate this block group.
> + * checks to see if it's even possible to relocate this block group.
>   *
>   * @return - false if not enough space can be found for relocation, true
>   * otherwise
> @@ -9872,7 +9872,7 @@ bool btrfs_can_relocate(struct btrfs_fs_info *fs_info, u64 bytenr)
>  	 * ok we don't have enough space, but maybe we have free space on our
>  	 * devices to allocate new chunks for relocation, so loop through our
>  	 * alloc devices and guess if we have enough space.  if this block
> -	 * group is going to be restriped, run checks against the target
> +	 * group is going to be restripped, run checks against the target

Drop this hunk, here we mean to restripe the changes and not restrip
them. So restriped is the correct past tense of the verb.

>  	 * profile instead of the current one.
>  	 */
>  	can_reloc = false;
> @@ -10424,7 +10424,7 @@ int btrfs_read_block_groups(struct btrfs_fs_info *info)
>  		 * check for two cases, either we are full, and therefore
>  		 * don't need to bother with the caching work since we won't
>  		 * find any space, or we are empty, and we can just add all
> -		 * the space in and be done with it.  This saves us _alot_ of
> +		 * the space in and be done with it.  This saves us _a_lot_ of

This should be _a lot_

>  		 * time, particularly in the full case.
>  		 */
>  		if (found_key.offset == btrfs_block_group_used(&cache->item)) {
> @@ -10700,7 +10700,7 @@ int btrfs_remove_block_group(struct btrfs_trans_handle *trans,
>  
>  	mutex_lock(&trans->transaction->cache_write_mutex);
>  	/*
> -	 * make sure our free spache cache IO is done before remove the
> +	 * make sure our free space cache IO is done before remove the

I think there should be a 'we' before 'remove'

>  	 * free space inode
>  	 */
>  	spin_lock(&trans->transaction->dirty_bgs_lock);
> @@ -11217,7 +11217,7 @@ static int btrfs_trim_free_extents(struct btrfs_device *device,
>  	if (!blk_queue_discard(bdev_get_queue(device->bdev)))
>  		return 0;
>  
> -	/* Not writeable = nothing to do. */
> +	/* Not writable = nothing to do. */

This comment is redundant so could be removed altogether

>  	if (!test_bit(BTRFS_DEV_STATE_WRITEABLE, &device->dev_state))
>  		return 0;
>  
> diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
> index aef3c9866ff0..1493f0c102ec 100644

<snip>

> diff --git a/fs/btrfs/free-space-tree.c b/fs/btrfs/free-space-tree.c
> index e5089087eaa6..13e71efcfe21 100644
> --- a/fs/btrfs/free-space-tree.c
> +++ b/fs/btrfs/free-space-tree.c
> @@ -550,7 +550,7 @@ static void free_space_set_bits(struct btrfs_block_group_cache *block_group,
>  
>  /*
>   * We can't use btrfs_next_item() in modify_free_space_bitmap() because
> - * btrfs_next_leaf() doesn't get the path for writing. We can forgo the fancy
> + * btrfs_next_leaf() doesn't get the path for writing. We can forgot the fancy

Drop this hunk, the meaning is we can eschew the fancy tree walking.

>   * tree walking in btrfs_next_leaf() anyways because we know exactly what we're
>   * looking for.
>   */
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index bab2f1983c07..babbd75d91d2 100644
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -104,7 +104,7 @@ static void __endio_write_update_ordered(struct inode *inode,
>  
>  /*
>   * Cleanup all submitted ordered extents in specified range to handle errors
> - * from the fill_dellaloc() callback.
> + * from the fill_delalloc() callback.

This is a pure whitespace fix which is generally frowned upon. What you
can do though, is replace 'fill_delalloc callback' with
'btrfs_run_delalloc_range' since the callback is gone already.

>   *
>   * NOTE: caller must ensure that when an error happens, it can not call
>   * extent_clear_unlock_delalloc() to clear both the bits EXTENT_DO_ACCOUNTING
> @@ -1831,7 +1831,7 @@ void btrfs_clear_delalloc_extent(struct inode *vfs_inode,

<snip>

> diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
> index 410c7e007ba8..d7b6c2b09a0c 100644
> --- a/fs/btrfs/ioctl.c
> +++ b/fs/btrfs/ioctl.c
> @@ -892,7 +892,7 @@ static int create_snapshot(struct btrfs_root *root, struct inode *dir,
>   *  7. If we were asked to remove a directory and victim isn't one - ENOTDIR.
>   *  8. If we were asked to remove a non-directory and victim isn't one - EISDIR.
>   *  9. We can't remove a root or mountpoint.
> - * 10. We don't allow removal of NFS sillyrenamed files; it's handled by
> + * 10. We don't allow removal of NFS silly renamed files; it's handled by
>   *     nfs_async_unlink().
>   */
>  
> @@ -3522,7 +3522,7 @@ static int btrfs_extent_same_range(struct inode *src, u64 loff, u64 olen,
>  					       false);
>  	/*
>  	 * If one of the inodes has dirty pages in the respective range or
> -	 * ordered extents, we need to flush dellaloc and wait for all ordered
> +	 * ordered extents, we need to flush delalloc and wait for all ordered

Just whitespace fix, drop it.

<snip>